From: "Arnd Bergmann" <arnd@arndb.de>
To: "Daniel Sneddon" <daniel.sneddon@linux.intel.com>,
"Arnd Bergmann" <arnd@kernel.org>,
x86@kernel.org, "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Sean Christopherson" <seanjc@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Josh Poimboeuf" <jpoimboe@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
"Michal Luczaj" <mhal@rbox.co>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header
Date: Wed, 09 Aug 2023 20:26:17 +0200 [thread overview]
Message-ID: <c67fa35a-590f-404c-8104-5afbf14ad282@app.fastmail.com> (raw)
In-Reply-To: <f66ef6d0-18f7-ebef-0297-ad2f2d578aff@linux.intel.com>
On Wed, Aug 9, 2023, at 18:54, Daniel Sneddon wrote:
> HI Arnd,
>
> On 8/9/23 06:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The declaration got placed in the .c file of the caller, but that
>> causes a warning for the definition:
>>
>> arch/x86/kernel/cpu/bugs.c:682:6: error: no previous prototype for 'gds_ucode_mitigated' [-Werror=missing-prototypes]
>
> When I build with gcc 9.4 and the x86_64_defconfig I don't see this warning even
> without this patch. I'm curious why you're seeing it and I'm not. Any ideas?
The warning is currently disabled by default, unless you build with
'make W=1'. I'm in the process of getting my last patches out to
change this so the warning is enabled by default though, so I was
phrasing this based on the future behavior. Sorry if this was confusing.
Arnd
next prev parent reply other threads:[~2023-08-09 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:04 [PATCH 1/2] x86/speculation: add cpu_show_gds() prototype Arnd Bergmann
2023-08-09 13:05 ` [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header Arnd Bergmann
2023-08-09 16:54 ` Daniel Sneddon
2023-08-09 18:26 ` Arnd Bergmann [this message]
2023-08-09 19:16 ` Daniel Sneddon
2023-08-09 19:20 ` Daniel Sneddon
2023-08-09 15:46 ` [PATCH 1/2] x86/speculation: add cpu_show_gds() prototype Daniel Sneddon
2023-08-09 22:13 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c67fa35a-590f-404c-8104-5afbf14ad282@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®