From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50B0C347504 for ; Mon, 9 Mar 2026 11:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773056122; cv=none; b=iDCTpHdTIvOK3tbJOPoX2xKsht5oX3rWhu+h1Fhadp0fGH2Q/Nr6OzzSpQBVf4XeN9UQCbiLFBLk7UPiBB58eNMLu5L95iXGthMax180jdjfc/QJPZJy9uH7XpEgZ72UOvyd7QykrsbHjrVBbb1Ik8ZeRrY8yaF/QJDKsKpbN4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773056122; c=relaxed/simple; bh=IjKB0RY1F7a9g2zBFRyurkKPqU1OSnC1fFvV7yeNsx4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jdJTyK7SF/anazef0MOwl9p8vo6Yl1T8fk57BKXKTfhehgIWoN9BDxtY94irRZlBj7Y8c77WUSj3YfqO2Z2vKXSgLT2Km5DmXMxGepcP7hiIEHIDAg51urDv/wkuS/WdibPsH+jCryQgWC5rltv/N5G5bFBvd7vJP2IVQaOK+iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jl8hfwlC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=geXjl7xS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jl8hfwlC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="geXjl7xS" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629AIexv1587337 for ; Mon, 9 Mar 2026 11:35:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G3+rstJ/ZdS7C8kBoFMmuPACxGCxopy6Lc4ZaIJW+ZY=; b=jl8hfwlCwYb8dApe yTiKjIcLS/poBp86vwfjLXe04EVGEb5ymRgl1pD0B5r7fOHGGtpnfApXh4cWBqGk nq2phhZkWCv9utPft0N6Nl9eo+kHwgMTaN1ANPuxlig4QUUmDq0S/xJtqzYO5C+9 3Y10UkZmxstGGiJZx622xkoJ4LxTKDHNc3ssk0Tf3AdVOr8fhitSKVgtJWjdCdnK KMmi3w6rXLi8itMip9irWe/yeqIhLKyfxRnzA2AZhsci27Mlyu7F/o9+6zWj0OQo IoeRWjr2QfF7e0jkpAogumXvD/9k1wtuuwGitBlLMyQspsVz7UPWjP20RMi3uGLw a8nTFg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csqcy9aq4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 11:35:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae44db60c2so81005185ad.2 for ; Mon, 09 Mar 2026 04:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773056120; x=1773660920; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G3+rstJ/ZdS7C8kBoFMmuPACxGCxopy6Lc4ZaIJW+ZY=; b=geXjl7xSvfxo4L4uw9hfxsxTqBU2W4OjtwmjMA/ZXvWTvA0pqtbRm1U49MqTI1Fxsx KZEoGv4YO5QEkrdpUHRcO+KYJWghl2pJvocjwuxVkHtDclQBRW/UafUjFtXt06k6p/io 8CnsOq0aGCZRgSdv6ApJBfq07EMvOhfP7lWFnmGvVnB93x506mKa3JSzQ7sxDXZqu5c5 z9QmaWumOCgnBLr9CmrZ+gcZ5i3k55MBTJg2Y7LfBdFJJi1lKMAByumyCuWmuY18jvrp j2GWp8zYaDHJRpDgShEIH0sUQx/tkoJYTFuugpf8DuKX4IT1s3YrXzxnMPGAL9UM4ZxQ 7QJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773056120; x=1773660920; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G3+rstJ/ZdS7C8kBoFMmuPACxGCxopy6Lc4ZaIJW+ZY=; b=fr82cFFa6iA9jtVj1t34pUavDOW/u90CxLirsMTYE7xQOqR3VYZyfboE/tV2Hk1Ikg Y0jWyTM1XKg7EQvmexizqRxsptxtyMxN3M+CPgTCbAecIolhnBSe4MWF+uY/0GBPILTW 7EJDbB+UX62adG7/buKof78mp6cGhG6DRDCsJ+K2KecymNErCQw6jjmH+tXgIkUOHWW2 wfPzkFV/BSiGHpN8SwgA40RFd4x8cvhm/9yW794Do1fMoC3ERMR+JXI9I2LqHsb5fSmQ d5tsuogq4/RO2Tlo7sIyz9n8mnDqTxKLJ2aLJru+MfraByniz58MhkG0ep6kUq85dX8t rxng== X-Forwarded-Encrypted: i=1; AJvYcCXOqRVBaTPqkUXqDeP+el/Uw5vvVPCEHwqEJCfh9ho0txNoS9hnVFRcXsHIrfUVgCukzbcVfr0lY7PlMok=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/S1TL7NN/jQJlUXmOcOQ0XMNTOrGfjVaow17Mc4pgQj/5WUhG zItaGfgZNCBg89d3S5HZfId+xbr6wMgz6ZKWNrXffAuCmRVUdpUuV13Ysva/DlKra4EzNwnF7MY bddfHdV9P4dSWkYLi1pDcu2aMbxJTblUyjfeler/uJ+YoSjR+EdxFnZxDJyljospW22U= X-Gm-Gg: ATEYQzy2PtcZWUhNXZng/ZHIC3sOd5dFqiwgeOveAAN20nKhFUxdvAuTk4K6/ruPQ4n bPdKuqjgriPY5GSA+UMIjZYWOHoacUl6sg8joWk8j4MPwTnekI2A6WgtCC/K8sRnHh+9eTV9psP f001ADQ6jDKUsCqRKoUB/ZX0SZlAkjOa9t1v7lRB3nvvoBk0nViGj0aphxLgU4n22EMP0FtcBg9 mLt7Xh0QTFOhHgkQeTJ+UKuTUgGU9yAPJPccEbDeOmwQfDDQb0ne9amij7qerBgT+VxUa9HxRZK 670ONNb1JFUwxJDEM+CdTRS09n2jsm0N1R6K7aCyEk1YWr4tvZKzTuR0E9KYhiQaKRrDksn396E fGE55v5rkKALSAJzcn8ZZ/HVWknbM1w2rTJj7x/RHaU+4vjS0BnWA9Yz5YFcVlxhsfURrtu9k69 6EgUD3Nh1EOMrWSKLSSUNYhuZkTWljaU1tlHyweP4= X-Received: by 2002:a17:903:182:b0:2ae:4fb6:bb21 with SMTP id d9443c01a7336-2ae8242e961mr120563635ad.15.1773056119683; Mon, 09 Mar 2026 04:35:19 -0700 (PDT) X-Received: by 2002:a17:903:182:b0:2ae:4fb6:bb21 with SMTP id d9443c01a7336-2ae8242e961mr120563325ad.15.1773056119026; Mon, 09 Mar 2026 04:35:19 -0700 (PDT) Received: from [10.190.200.237] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae840aefbdsm149900975ad.82.2026.03.09.04.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 04:35:18 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 17:05:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 1/5] dt-bindings: embedded-controller: Add EC bindings for Qualcomm reference devices To: Krzysztof Kozlowski Cc: robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-2-sibi.sankar@oss.qualcomm.com> <20260309-amorphous-archetypal-impala-8a0e1d@quoll> Content-Language: en-US From: Sibi Sankar In-Reply-To: <20260309-amorphous-archetypal-impala-8a0e1d@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDEwNiBTYWx0ZWRfX/HpQLrcnlaEM GBu2me93VdyGR1CMwOXCKoewfB81qqhWCJpN7QnhxIENIBP6lMgDxOEUvUGNZn3bpxi2RHcedxs 4b8Nnyumr396ZAojCYslTNIWAbJr10nGZI5OjnGmyAtRjpRZZomqVWtlW/5nMEikXsI1S2Hn52m kP0S2uIG1qLXaKYCPI5w7n56mjiDtAQN9SItm3iNdxPO3EueGe2j02Vrt9q4FzlxeLnL7T9HHkr olzedUGMKbAkWj01cwbfiQCKkr+hf8IbHDyuCxIH87RleyqbK99qYmLXWdksV26NC16gLV4nNnR M1eUL3a26tV3K1puEyS0RyifciJHxdfJfyrvfYMJy4hJhBRkczOjknKs2fbdZKEUZRZUuFSA0iv 5OnIy+Er2VhKxWZKg6O2ZH+qoQqqCDJOH5ur0IEfIKHnSZMFs4ZS8wa862MRuVzW3zEEM5wdTRK UyeUEz0K51vK77JKIkw== X-Authority-Analysis: v=2.4 cv=QJtlhwLL c=1 sm=1 tr=0 ts=69aeb078 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=gEfo2CItAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=1qf01Qjrl_d0v0_Yp50A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-ORIG-GUID: QATHTEznzCBV-JYjhUgS0L6uoY_T4dkq X-Proofpoint-GUID: QATHTEznzCBV-JYjhUgS0L6uoY_T4dkq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090106 On 3/9/2026 12:53 PM, Krzysztof Kozlowski wrote: > On Mon, Mar 09, 2026 at 05:06:42AM +0530, Sibi Sankar wrote: >> From: Maya Matuszczyk >> >> Add bindings for the EC firmware running on Hamoa/Purwa and Glymur >> reference devices, which run on IT8987 and Nuvoton MCUs respectively. >> >> Signed-off-by: Maya Matuszczyk >> Co-developed-by: Sibi Sankar >> Signed-off-by: Sibi Sankar >> --- >> .../embedded-controller/qcom,hamoa-ec.yaml | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> >> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> new file mode 100644 >> index 000000000000..ea093b71d269 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Hamoa Embedded Controller. > Please implement the feedback from v2. Ack, sorry missed it. > >> + >> +maintainers: >> + - Sibi Sankar >> + >> +description: >> + Qualcomm Snapdragon based Hamoa/Purwa and Glymur reference devices have an >> + EC running on IT8987 and Nuvoton MCU chips respectively. The EC handles things >> + like fan control, temperature sensors, access to EC internal state changes. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,glymur-nuvoton-ec > nuvoton is name of the company, so it's too generic to describe a > component. It's like calling it "qcom,glymur-qcom-ec". How many EC do > you have there? Ack, will get this updated. >> + - qcom,hamoa-it8987-ec > I don't understand this compatible. You already have hamoa. > >> + - const: qcom,hamoa-ec > So which EC is this? Will update the compatibles when consensus is achieved on patch 4 thread. > > Best regards, > Krzysztof >