From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933577AbcGKGKH (ORCPT ); Mon, 11 Jul 2016 02:10:07 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:34476 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757712AbcGKGKE (ORCPT ); Mon, 11 Jul 2016 02:10:04 -0400 Subject: Re: [PATCH v7 0/11] Output raw touch data via V4L2 To: Nick Dyer , Dmitry Torokhov References: <1467977164-17551-1-git-send-email-nick@shmanahar.org> Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Benjamin Tissoires , Benson Leung , Alan Bowens , Javier Martinez Canillas , Chris Healy , Henrik Rydberg , Andrew Duggan , James Chen , Dudley Du , Andrew de los Reyes , sheckylin@chromium.org, Peter Hutterer , Florian Echtler , mchehab@osg.samsung.com, jon.older@itdev.co.uk, nick.dyer@itdev.co.uk From: Hans Verkuil Message-ID: Date: Mon, 11 Jul 2016 08:09:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1467977164-17551-1-git-send-email-nick@shmanahar.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 01:25 PM, Nick Dyer wrote: > This is a series of patches to add output of raw touch diagnostic data via V4L2 > to the Atmel maXTouch and Synaptics RMI4 drivers. > > It's a rewrite of the previous implementation which output via debugfs: it now > uses a V4L2 device in a similar way to the sur40 driver. > > We have a utility which can read the data and display it in a useful format: > https://github.com/ndyer/heatmap/commits/heatmap-v4l > > These patches are also available from > https://github.com/ndyer/linux/commits/v4l-touch-v7-2016-07-08 > > I will also send a patch to update v4l2-compliance. The series looks good, but it needs to be rebased due to this change: http://www.spinics.net/lists/linux-media/msg101733.html Regarding patch 3/11: as you may know we're moving from DocBook to sphinx for the documentation in 4.8. The git branch with that code is here: https://git.linuxtv.org/media_tree.git/log/?h=docs-next If you can redo this patch 3/11 on top of that branch, then that would be great. Regards, Hans > > Changes in v7: > - Tested by Andrew Duggan and Chris Healy. > - Update bus_info to add "rmi4:" bus. > - Fix code style issues in sur40 changes. > > Changes in v6: > - Remove BUF_TYPE_TOUCH_CAPTURE, as discussed with Hans V touch devices will > use BUF_TYPE_VIDEO_CAPTURE. > - Touch devices should now register CAP_VIDEO_CAPTURE: CAP_TOUCH just says that > this is a touch device, not a video device, but otherwise it acts the same. > - Add some code to v4l_s_fmt() to set sensible default values for fields not > used by touch. > - Improve naming/doc of RMI4 F54 report types. > - Various minor DocBook fixes, and split to separate patch. > - Update my email address. > - Rework sur40 changes so that PIX_FMT_GREY is supported for backward > compatibility. Florian is it possible for you to test? > > Changes in v5 (Hans Verkuil review): > - Update v4l2-core: > - Add VFL_TYPE_TOUCH, V4L2_BUF_TYPE_TOUCH_CAPTURE and V4L2_CAP_TOUCH > - Change V4L2_INPUT_TYPE_TOUCH_SENSOR to V4L2_INPUT_TYPE_TOUCH > - Improve DocBook documentation > - Add FMT definitions for touch data > - Note this will need the latest version of the heatmap util > - Synaptics RMI4 driver: > - Remove some less important non full frame report types > - Switch report type names to const char * array > - Move a static array to inside context struct > - Split sur40 changes to a separate commit > > Changes in v4: > - Address nits from the input side in atmel_mxt_ts patches (Dmitry Torokhov) > - Add Synaptics RMI4 F54 support patch > > Changes in v3: > - Address V4L2 review comments from Hans Verkuil > - Run v4l-compliance and fix all issues - needs minor patch here: > https://github.com/ndyer/v4l-utils/commit/cf50469773f > > Changes in v2: > - Split pixfmt changes into separate commit and add DocBook > - Introduce VFL_TYPE_TOUCH_SENSOR and /dev/v4l-touch > - Remove "single node" support for now, it may be better to treat it as > metadata later > - Explicitly set VFL_DIR_RX > - Fix Kconfig > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >