From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3658B2E62B3 for ; Sun, 24 May 2026 18:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647409; cv=none; b=AMjBeCHy7FJOIiNK0aXLefFdPqQs48f/grkw73jrvXn1PeLJB9UqLVazKR3yp9oGTRxpIWFW3eRBYyekBkN080G9Eo2gADpfG6xsBtyNE/AJLKsZDBLUlCOrQzx8C9XXdMLgVpxfg45sX2/V/ZBYw1ZxxS1rM9TgcKdaoEKYiQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647409; c=relaxed/simple; bh=p/8AOHBhq/TICjwqQxKfP5erT+mxulFxJXRiyVWlMl4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JqxPEbozcWe6TqUy+caKQK9CAV99y+7f6UL3dPjm3E7iv/43JaUjdqeeXLlDIV/EC38nOSsLDOg35VeaEKpxngb3LIFPkOm2bGf0MY1zRzsOsQWNEBUg/Ej2VAjeeCT5Lzku3tbXisFwicKM0jSiT0nSnm/Obet1V4Uc8kE7908= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eUzrNBcc; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eUzrNBcc" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4903974854dso29544135e9.3 for ; Sun, 24 May 2026 11:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779647405; x=1780252205; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bPIXJAikdFwElV0lTaJirkt4kwhQPmCoEKgc7GdTY7s=; b=eUzrNBcc0gfe+Wz3NlPznTK8J7qfy1ZJYDHdir7Z1fuW92T4qaXDrhLAm8jxPsroGy 3BniFZ3aCqRV8z8wynpn3SDpg3FrZhxvaKOPiaucYVBlHu392jKmAwDOS5/Nnx5LgZV7 SRMmhrSW6ELHxpUN3lkjq9i/y52BTjX2422O2ve1At+Fu3TrmYwl5Y3CCoX+MsQ3RWOp tMF10IrwcapN0YpSKKyExO01r0hJWqs2bxRv1J73OTAcYLpWp3z52nbKgJ4/mIk5ZQbG KiTO2pGYVNXWd3bGSkyee4QWmmcnOJgQbM+Og0fV2tTpOT1Oest7MmSURaRPKtKq2vTN 3PQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779647405; x=1780252205; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bPIXJAikdFwElV0lTaJirkt4kwhQPmCoEKgc7GdTY7s=; b=gZo1lUygCe2JiKrPM0rhzR0SGg5fQMzizbFo3fhJu9wJoswtB+OHpEin+sOCf+mn1l CeAeyWkre9gXhq672voMgBEXdguswWUcR3cWNMVDQbT6pEIasPm9UMFODoUw4Sm9DIhj /gAgYBcvbeP24REenfrcD9IKH9wl/8EZSjJLy5tAX5/Gpi2d3DLxQUtaC0dGFRmWzJUT 7nYZmwgch8MEI8dxSDY4erx0DuVOYxI0hUS5SXENiWzPYafgw000tm0DZNhBirT7M9Ur ZjMuIpLreInzam0iWnjeFXIxlmAbWaaDVJVytPiiZqOkqdiitlRYUnlVY62WwazWI3sV p2Og== X-Forwarded-Encrypted: i=1; AFNElJ/3UneTvQiHlRjiODbrMsh3Xkg9QmaXJQOBHMrcjQkOQ6mzBzIShVtQAzv+sorEMUdOwShbYpJBIlys9SI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5/tnnpWOkWtxnip9M91cHMM/pKhCmVKH3DV6JHNZNrA5kh5YR ehaAmOm4jMhMeyPQ/+1rZRGDjVw1sAvjuyWy34mUPraGK2poUUzn4YwG X-Gm-Gg: Acq92OH48hJvKfL5sEy74kwpEJf9F+WGwUIKXNHPqv1B0BMXfDtztve7QAfrXrdXSeF 2vxCIX/ObKrbhuMmKWzuqL5wMzr5MjOYA29Odtwq/VOa5EYwOKDeOTSzgINBP6bdP251nF4rBNf Qyx5plTACtBit0/3yKdnDAlydKxqctBsFTiw/ly8R1M+JVRkSKMVpZQ5C8v+bUFtRGs5AX4Q7i7 rTzGi9KJ9hdTkmum6hoNRwmGlceCQHqTsFPba48NzbEyOaMPGR8xZ5+9ppJdgtdNTTVyXFecqUe pRfrV+6RDlvl1fkmHvPeJvxTwr07zSU9G4c8Zzq/x0kULo5SfX03RnZ9AVd02SXcov3723n29yk BU6+lPju0Bdv2IkFmqAKZxSeaZMjmwbEUFMejB9ObKZaozu/y1nwOR7mfVNmadMMMrEbjI0mb+5 OE8s79Pxgp3kAb7IYJ+tvtbS3AnkAmQaS06OFgM6I+eA== X-Received: by 2002:a05:600c:8b84:b0:490:5466:8576 with SMTP id 5b1f17b1804b1-490546689a7mr115352745e9.1.1779647405405; Sun, 24 May 2026 11:30:05 -0700 (PDT) Received: from [192.168.1.50] ([79.119.240.27]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904561a160sm222864685e9.9.2026.05.24.11.30.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 May 2026 11:30:05 -0700 (PDT) Message-ID: Date: Sun, 24 May 2026 21:30:01 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 0/2] staging: rtl8723bs: Fix error handling in _rtw_pktfile_read() To: Minu Jin , gregkh@linuxfoundation.org Cc: andriy.shevchenko@linux.intel.com, dan.carpenter@linaro.org, abrahamadekunle50@gmail.com, zxcv2569763104@gmail.com, milospuric856@gmail.com, karanja99erick@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260127153811.1592900-1-s9430939@naver.com> Content-Language: en-US From: Bitterblue Smith In-Reply-To: <20260127153811.1592900-1-s9430939@naver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/01/2026 17:38, Minu Jin wrote: > This series improves error handling in _rtw_pktfile_read() and cleans up > the code style to comply with kernel standards. > > 1. The first patch combines the logic change and caller updates. > The function change and the caller updates must be in the same > patch. If they are separated, the code will not work correctly > or will cause errors at that specific point in the history. > > 2. The second patch focuses purely on code style cleanup (changing uint > to unsigned int) as requested by Andy Shevchenko. > > Regarding the logic change in _rtw_pktfile_read(): > > The original code used a ternary operator to read whatever data was > available, even if it was less than requested. This could lead to > callers processing incomplete data without knowing it. > > I have changed this to return -EINVAL when the remaining data is insufficient. > This is safer because most callers expect the exact amount of data and > should not proceed with a partial read. > > Testing and Verification: > > I do not have access to the physical RTL8723BS hardware. However, I have > performed a rigorous manual audit of the data path and verified the > changes using Smatch static analysis. The analysis confirmed that no > new warnings or logical regressions were introduced in the modified files. > Hi! I have some bad news: https://bbs.archlinux.org/viewtopic.php?id=313401 [quote] Hey everyone, I recently upgraded my system, and now I’m having a strange issue with my WiFi (Realtek RTL8723BS). now I can no longer connect to any WiFi networks as a client. however, creating an Access Point (AP) still works fine, but whenever I try to connect to an existing network, the connection fails. dmesg logs: Every time I attempt a connection, dmesg gets spammed with this error: [ 1083.925640] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 [ 1084.921217] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 [ 1085.921434] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 [ 1086.922320] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 .... Has anyone encountered this specific "coalesce" error with the rtl8723bs driver? I'm looking for advice on whether this is a known bug in recent kernels or if there's a specific module parameter I should try to bypass this. System Info: Chipset: RTL8723BS (SDIO) Kernel version: 7.0.3-zen1-2-zen update: I fixed the issue after kernel downgrade [/quote]