mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Jiayuan Chen <mrpre@163.com>,
	linux-kselftest@vger.kernel.org, song@kernel.org,
	bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, martin.lau@linux.dev, andrii@kernel.org,
	ast@kernel.org, kpsingh@kernel.org, jolsa@kernel.org
Subject: Re: [PATCH kselftest] fix single bpf test
Date: Mon, 25 Nov 2024 13:11:46 +0000	[thread overview]
Message-ID: <c685c171-0d2d-4ef1-82ca-386c3a2e3df6@sirena.org.uk> (raw)
In-Reply-To: <93d96c99-4712-4054-a36f-3c65c80ab3f8@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

On Fri, Nov 22, 2024 at 08:14:58AM -0700, Shuah Khan wrote:

> The commit 7a6eb7c34a78 went in 4 years ago? DO we have a better
> story for the LLVM tool chain to get rid of skipping bpf and sched_ext?

> Running make -C tools/testing/selftests/bpf/ gave me the following error.
> Does this mean we still can't include bpf in default run?

> make -C tools/testing/selftests/bpf/
> make: Entering directory '/linux/linux_6.12/tools/testing/selftests/bpf'
> 
> Auto-detecting system features:
> ...                                    llvm: [ OFF ]

The toolchain is in a better place now and we can run with released LLVM
versions.  The detection above is still needed since the LLVM version
needed is a bit newer than the version needed for the kernel itself,
it's LLVM 18 for BPF, and not everyone has LLVM.

>   GEN     /linux/linux_6.12/tools/testing/selftests/bpf/tools/build/bpftool/vmlinux.h
> libbpf: failed to find '.BTF' ELF section in /linux/linux_6.12/vmlinux
> Error: failed to load BTF from /linux/linux_6.12/vmlinux: No data available
> make[1]: *** [Makefile:209: /linux/linux_6.12/tools/testing/selftests/bpf/tools/build/bpftool/vmlinux.h] Error 195
> make[1]: *** Deleting file '/linux/linux_6.12/tools/testing/selftests/bpf/tools/build/bpftool/vmlinux.h'
> make: *** [Makefile:369: /linux/linux_6.12/tools/testing/selftests/bpf/tools/sbin/bpftool] Error 2
> make: Leaving directory '/linux/linux_6.12/tools/testing/selftests/bpf'

This bit still needs some attention - the build needs a kernel binary
with BTF information built in via CONFIG_DEBUG_INFO_BTF.  That is
enabled by the config fragment for BTF tests but it's not compatible
with the arm64 defconfig since that sets CONFIG_DEBUG_INFO_REDUCED which
isn't compatible with _BTF, and in general having it missing should be
handled a bit more gracefully.  I believe some of the tests would run
happily without the BTF information.  

TBH I'm a bit surprised we even tried to do this bit with LLVM not
available...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2024-11-25 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 14:06 Jiayuan Chen
2024-11-22 15:14 ` Shuah Khan
2024-11-25 13:11   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c685c171-0d2d-4ef1-82ca-386c3a2e3df6@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mrpre@163.com \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®