From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 534F640B37B for ; Mon, 13 Jul 2026 12:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944689; cv=none; b=SMbOB8E8lactbNEzY6B8IprVLqJzFSHcVARo7z7bz97nukpkQYxMoSHyig/CCy5w8BreL/kcrdZYNw7wAbPt9IiAPBFUkMf/bML+d1cCeN6sfIsbdBms+IdXwtuQN+iItx10RfCY9DB6FyElxzYTM/dHQNcrCIxMWtJHWng8FrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783944689; c=relaxed/simple; bh=SfoFKS8KBOkFvyPTBlc5AJg3enF1kFrvZdjwd6ZzLuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XPpsKttwRUuTXC9Jqa2/3uN/Y+rfj52M8kLiqqZn9yylmzCI+i93yjLrkldaD7s86pRLaxobZaATQHARkwUolkJW+ocx+kI4SXmjjtIUKb6vx5xPqT20YrujLD87tP/zjPUrK8vJHNftgdi2Q33yVZAQQpIFm+Nr1NXoQx41wug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.170]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4gzLrG2tKQzYQtwd for ; Mon, 13 Jul 2026 20:11:10 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id F23124056D for ; Mon, 13 Jul 2026 20:11:23 +0800 (CST) Received: from [10.166.163.161] (unknown [10.166.163.161]) by APP3 (Coremail) with UTF8SMTPA id _Ch0CgCHUaLr1VRqGX9OBA--.12823S2; Mon, 13 Jul 2026 20:11:23 +0800 (CST) Message-ID: Date: Mon, 13 Jul 2026 20:11:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() To: Marc Zyngier Cc: tglx@kernel.org, jason@lakedaemon.net, lpieralisi@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260702033050.1583-1-shikemeng@huaweicloud.com> <20260702033050.1583-4-shikemeng@huaweicloud.com> <87fr216nx2.wl-maz@kernel.org> <86ldbopl97.wl-maz@kernel.org> From: Kemeng Shi In-Reply-To: <86ldbopl97.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_Ch0CgCHUaLr1VRqGX9OBA--.12823S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Ww15XrW3KrWUXr15Cr1rZwb_yoW5JF45pF WrJas29rWxJFyUWwnF9w1kua4rK39rt3yjkayUW3Z7urn5GF9rCF48trW3ury0kr17J3WU Z3WFgFWruF4UAaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyGb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxkF7I0En4kS14v26r126r1DMxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw2 0EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x02 67AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1RBT5UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ 在 2026/7/6 16:36:52, Marc Zyngier 写道: > On Fri, 03 Jul 2026 02:44:53 +0100, > Kemeng Shi wrote: >> >> 在 2026/7/3 6:12:57, Marc Zyngier 写道: >>>> When its_irq_gic_domain_alloc() fails, the following >>>> its_vpe_irq_domain_free() skips calling its_vep_teardown() for the >>>> corresponding irq. Call its_vpe_teardown() when its_irq_gic_domain_alloc() >>>> is failedto avoid the leak issue. >>>> >>>> Fixes: 7d75bbb4bc1ad ("irqchip/gic-v3-its: Add VPE irq domain allocation/teardown") >>>> Signed-off-by: Kemeng Shi >>>> --- >>>> drivers/irqchip/irq-gic-v3-its.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c >>>> index 3e4edcb64065..8968bedefdba 100644 >>>> --- a/drivers/irqchip/irq-gic-v3-its.c >>>> +++ b/drivers/irqchip/irq-gic-v3-its.c >>>> @@ -4666,8 +4666,10 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq >>>> break; >>>> err = its_irq_gic_domain_alloc(domain, virq + i, >>>> vm->vpes[i]->vpe_db_lpi); >>>> - if (err) >>>> + if (err) { >>>> + its_vpe_teardown(vm->vpes[i]); >>>> break; >>>> + } >>> There is already a spot for error handling in this function, we don't >>> need a second one. >> When its_irq_gic_domain_alloc() fails at index i, its_vpe_init(vpes[i]) >> has already succeeded but the exisiting its_vpe_irq_domain_free(domain, virq, i) >> only tears down VPEs with index [0, i - 1], so its_vpe_teardown(vpes[i]) is still >> needed. >> So I guess you mean we can increase index when its_irq_gic_domain_alloc() fails to >> free the resource with existing error handling? >> Please correct me if I'm miss anything. > > What I mean is this. > > M. > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index b57d81ad33a0a..4b1a3b497d7c4 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -4674,8 +4674,10 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq > irqd_set_resend_when_in_progress(irq_get_irq_data(virq + i)); > } > > - if (err) > + if (err) { > + its_vpe_teardown(vm->vpes[i]); > its_vpe_irq_domain_free(domain, virq, i); > + } > > return err; > } > Thanks for explanation. I will improve this in next version.