mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nishant Malpani <nish.malpani25@gmail.com>, jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: light: tsl2563: Wrap comment description
Date: Sat, 21 Mar 2020 04:51:33 -0700	[thread overview]
Message-ID: <c68e74af78fa0f73a9dc4cf5535a2dc16b99b729.camel@perches.com> (raw)
In-Reply-To: <9129a6c25f772bdfba28d556190e5511c7005e8a.1584518000.git.nish.malpani25@gmail.com>

On Wed, 2020-03-18 at 13:33 +0530, Nishant Malpani wrote:
> This patch wraps the comment description at 75 chars. Fixes the
> following warning generated by checkpatch.pl:
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)

Please do not scan files as patches.

checkpatch does not emit this message on a file
when used properly with the -f option.

> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
[]
> @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
>  }
>  
>  /*
> - * "Normalized" ADC value is one obtained with 400ms of integration time and
> - * 16x gain. This function returns the number of bits of shift needed to
> - * convert between normalized values and HW values obtained using given
> + * "Normalized" ADC value is one obtained with 400ms of integration time
> + * and 16x gain. This function returns the number of bits of shift needed
> + * to convert between normalized values and HW values obtained using given
>   * timing and gain settings.
>   */
>  static int tsl2563_adc_shiftbits(u8 timing)


  reply	other threads:[~2020-03-21 11:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  8:03 [PATCH 0/2] iio: light: tsl2563: Fix checkpatch warnings Nishant Malpani
2020-03-18  8:03 ` [PATCH 1/2] iio: light: tsl2563: Wrap comment description Nishant Malpani
2020-03-21 11:51   ` Joe Perches [this message]
2020-03-21 13:10     ` Nishant Malpani
2020-03-18  8:03 ` [PATCH 2/2] iio: light: tsl2563: Rename macro to fix typo Nishant Malpani
2020-03-21 11:13   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c68e74af78fa0f73a9dc4cf5535a2dc16b99b729.camel@perches.com \
    --to=joe@perches.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nish.malpani25@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®