From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2005DC433FE for ; Fri, 22 Apr 2022 17:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbiDVRmM (ORCPT ); Fri, 22 Apr 2022 13:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231478AbiDVRmI (ORCPT ); Fri, 22 Apr 2022 13:42:08 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1FF7E7F43; Fri, 22 Apr 2022 10:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650649148; x=1682185148; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0fpFqQYd/Wbv3V4oC9q2pZUt7Qc5kv653iWEvAomgFI=; b=ZuOLpuMQZNe3m4hwMlM6YJDxrTrvA4No229fI8Wj6+VtHUtlX/v6LHj6 dFK4pXs+qSKOxMFm+LNejCvXgLWodhvYGTVedSCg5bMbh3BnC/S+3Kvct uWGvDElzSfkbn6kJ0K6ucyB7ANX8x79HYBdYMnbR+Y6fmHEZpqwZ3jN0c 0=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 22 Apr 2022 10:35:21 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 10:35:20 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 22 Apr 2022 10:35:18 -0700 Received: from [10.111.175.210] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 22 Apr 2022 10:35:15 -0700 Message-ID: Date: Fri, 22 Apr 2022 10:35:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Content-Language: en-US To: Doug Anderson CC: Sankeerth Billakanti , quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Bjorn Andersson , quic_vproddut , David Airlie , linux-arm-msm , LKML , dri-devel , Stephen Boyd , Sean Paul , Sean Paul , Steev Klimaszewski , "Dmitry Baryshkov" , "Aravind Venkateswaran (QUIC)" , "Kuogee Hsieh (QUIC)" , freedreno References: <1650618666-15342-1-git-send-email-quic_sbillaka@quicinc.com> <1650618666-15342-3-git-send-email-quic_sbillaka@quicinc.com> <83129bad-44a9-bec7-f931-8067ef1b9d4d@quicinc.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug On 4/22/2022 9:10 AM, Doug Anderson wrote: > Hi, > > On Fri, Apr 22, 2022 at 9:05 AM Abhinav Kumar wrote: >> >> Hi Doug >> >> For the lockdep error, the splat looks similar to what kuogee fixed >> recently. >> >> Can you please check if below patch is present in your tree? >> >> https://patchwork.freedesktop.org/patch/481396/ > > Indeed I did have that in my tree already, but the lockdep splat is > still there. I think the problem is that we're now calling > dp_hpd_plug_handle() directly in dp_bridge_enable() > > -Doug Yes, now i understood this particular issue better and not sure how this wasn't caught. Perhaps some difference in the USE flags. Sankeerth didnt have lockdebug and thats why didnt hit this. I have discussed with kuogee about why this change is needed and why this wasnt being done in get_modes(). It seems like originally, this was done for a quirk in the DP compliance equipment that it did not publish the fail safe mode ( even though some other modes were present ). Typically, any sink (as long as EDID read went through ) adds the 640x480 fail safe mode. We could have done it in get_modes() even earlier but not sure how it was missed or was there some other reason. Nonetheless, kuogee will post the change to move this to get_modes() shortly. Thanks Abhinav