From: Jens Axboe <axboe@kernel.dk>
To: Yang Ruibin <11162571@vivo.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v6] pktcdvd: Remove unnecessary debugfs_create_dir() error check in pkt_debugfs_dev_new()
Date: Mon, 26 Aug 2024 14:16:18 -0600 [thread overview]
Message-ID: <c698f351-5fdd-47c8-8450-54af72c7ad4c@kernel.dk> (raw)
In-Reply-To: <20240826062653.2137887-1-11162571@vivo.com>
On 8/26/24 12:26 AM, Yang Ruibin wrote:
> Remove the debugfs_create_dir() error check.
> It's safe to pass in errors that it gives you.
Please make it:
Remove the debugfs_create_dir() error check. It's safe to pass in error
pointers to the debugfs API, hence the user isn't supposed to include
error checking of the return values.
Note both the rewording, and that commit messages should be formatted to
72-74 char line lengths, not tiny ones.
--
Jens Axboe
prev parent reply other threads:[~2024-08-26 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 6:26 Yang Ruibin
2024-08-26 20:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c698f351-5fdd-47c8-8450-54af72c7ad4c@kernel.dk \
--to=axboe@kernel.dk \
--cc=11162571@vivo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome