From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678AbdK2LwG (ORCPT ); Wed, 29 Nov 2017 06:52:06 -0500 Received: from mail-sn1nam02on0086.outbound.protection.outlook.com ([104.47.36.86]:54016 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752191AbdK2LwD (ORCPT ); Wed, 29 Nov 2017 06:52:03 -0500 Subject: Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit To: Geert Uytterhoeven , Michal Simek , "David S . Miller" CC: Arnd Bergmann , , , , References: <1511949669-30379-1-git-send-email-geert+renesas@glider.be> From: Michal Simek Message-ID: Date: Wed, 29 Nov 2017 12:51:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511949669-30379-1-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23498.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(2980300002)(438002)(24454002)(189002)(199003)(316002)(4326008)(6246003)(58126008)(33646002)(189998001)(54906003)(106466001)(110136005)(50466002)(76176999)(50986999)(54356999)(31696002)(65826007)(86362001)(5660300001)(36756003)(64126003)(8936002)(63266004)(31686004)(6666003)(2950100002)(47776003)(230700001)(65956001)(65806001)(83506002)(229853002)(23676004)(2486003)(53546010)(9786002)(36386004)(106002)(81156014)(478600001)(81166006)(77096006)(356003)(2906002)(305945005)(8676002)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR02MB3392;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT035;1:V8vXCgYXzM2LcwQwZqGWQY5PnV1nAk5LPxjaenAk5r2+fioFTp8i8T7dfZnqPuQ6GAgFCNxGJO+YXeeUqneIjRc4eQFRGa4RL0xjdXwBf3qoEXfdf0zYCsYpKfjlGiPk X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3f53fcd-a9a2-4324-ed8c-08d5371f9a27 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603269);SRVR:MWHPR02MB3392; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3392;3:IozaHIPFatTWDzJjKtecbitenPmgjESYyzh2Ld9R7GrBLobEQ/IAZHFscelwlduw2XRXDS7w3CTx+aUwfgibZTcwSzZ19XDBZL0INL0155GXnIONfOucPFQZ6gbd+oLLbRXe68/EyjI6qNJmVuRM+CR5+euN+qFtcUHZzZKn6hsrQlkdHEP0aJIeQSAdk4kifnYZqeqwgvhR/HyCAMDa+coAf7TWoZR6EZECC6ym9PPjWi9WUCtr7GOasevHyua0fUszkindtvCBubjt0dTD9dmW68G3xc/yKMkgwE7Ef3HKSTSfLsLnSuSvjY/LZ0oeThMKBYlHTpsrQrDwgPjz0IezEDttyJrXDsclOJf0y+c=;25:ElPgkGleu0ovqqueovGsW3Aj8mEOSvEnHADPHAugLCQHZ8o94StbBMmIPoWCe1aReH3LQsxqR3djkCiSG8kQcaYfik8ThQ85tdbUI5da4WvsTadLcTOperuxCI/0Aj/0j0DrNbAdizjRoXr6sQzI/xmrOxlRSfUXz6HcUf9e9c0KkVkjd02dg4JRDmx+1ZpRiQkbv03xTHdBRS6u4GbD4Lo65iauDbWaaMgaLftXlNfQGCVhs+yRagh8cXjYarzazCOolCrPybr7JBHgSvsPkJGTt65YbkenfSrMoDmx0QEdC0bRpuMBOSdqarKHO2vaotFJOH6mbIUwXngndsexQA== X-MS-TrafficTypeDiagnostic: MWHPR02MB3392: X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3392;31:f332NVENyn4QDu9/OpraU6y3f1ch4IccqWENU98gqYTs4T06CmqStN8ZfIzeIdcyKbJOsjfSlDkDCMWzm9zUNEj7MLs1AsxJXObTPbAIyJP84u5/oCkO4IZFpJhGrN18y0XxBk/JOLCa6kNRR2kHcnIkcvgRNIq165b09hXCX4+HwtoT+Dnb+/KuvwDrVBqFo/VmDNJJ47jQmx+kdpoVrUVjzygq3lt9/EK2j2LQsA8=;20:3+cap+gzp79OgD5HQuGBD8hFVLYOvBfxNEo1NENrdV8W52E3/Ybsk2bzy6FqQkyG+BRfTcyt6fxGNx+StBjvSdCVYQDqZwgen0dHktpnRidl7jGSfAbjEMfPxbKeiz05BFCgX3JTKj0RPwK8HI/vKg8ns16nwQMRjR0MPnzvhyaOmYoVy6HD38F9/LZKJxZt5o6tHY3pgeb4sRv8NizQp6S5B5MEHGPqKZKnRJ4U5wUFXFRwZ61hfJ2zEbByuicJ1A3SHCNHyap63+jXTo6aeX6ryjiW9kKk5yO3YDknXqmjqYLSj2w6TpZto+lDgx51XvDDj53y8x/5cSgsfmPdCZV0OZgaK0im+V/DgyDS8U2KqqKqPMozSTx8P1eX7+4tpsgOvX72GRnNmdiZovQrL6IOLxywx54G33IXJeT+7KglWhuybiuFlWX6gVIg7hv8ozo/AeT2XEaOdAI4Vp4gSMTq2rw7nItsYiC5yUNA/94JZlPTZqeEuiq4VLWP9Yrb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231022)(93006095)(93004095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(6072148)(201708071742011);SRVR:MWHPR02MB3392;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:MWHPR02MB3392; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3392;4:OWeF+Exec7TdwPv6h3I/F6Zn12ijgZUr1WD3ajmhva1/ij6+rmKqSwl0o5nl+NslGBVgGxUHN4PPnKMkWJ02b+Tys9YDE6d5hksYnMlwj5J+e4WOksaMIpc9OXSLUMehH/IuLfiRKj6FB6tZ/QCKRaymH7H9RQmAqYCePQ0/yJ9tKsONaHBazGf0jPEx0PvuJdPM7WlILTG22vGF1nwxWUyHcL5Y+2sDBPPefTTJ74tre43hwrc3srtxwD7lS8cSt5zObbnfIJ+7CaOuans3Iw== X-Forefront-PRVS: 05066DEDBB X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAyTUIzMzkyOzIzOk9FU3BqelZVWUdhN2lCRDYvN3E2WkE5Yk9L?= =?utf-8?B?YVQ4L0dYVTVpaDRxSk1RZ3c2dE14NFhEUXpGOFh1bmNKNXhDY2R0Q3lZc3Yr?= =?utf-8?B?UTdoYWc4cWFWbzJvbnZTMm5jMTByejZNVS9nOXE1WW53ZkJydEJGOWsxU0dV?= =?utf-8?B?dDFkS2xOMVdGby9qNG0veFRSVGRENGRzNnZOVk9NN2RCdkRra1pSd2o4R0xX?= =?utf-8?B?TXJQSnV2b2k5N3IyazlnUDJ6ajF1MFlTNlVqR2tDejBLblVPM1J2NnlURE9n?= =?utf-8?B?cG9MazNIN2gxT2pVakZFVzcyTEgvWHRDa3g0aUdaa1JvVTY3K3c0UWlQSHVB?= =?utf-8?B?ektjeGlsVERHbThNM3ZXZ3ZtamJSYkdqSlJoRGoxUG1sZTZwL2xXR3VvZkdL?= =?utf-8?B?Wk5mcW9WMFh3WXFSWWlyOFdEYmptYkNmb3IyWGtYQ0N3czVFMCtBU0MrRE16?= =?utf-8?B?dDRmUzduajFZNlFIMlZyM0VaNnlidXFyMnIzLzZSU3crcXNQV2FITHJLRUx1?= =?utf-8?B?YWFJVnBsOVZqS3JseXNhUGJnRWFlY0RkR3phcGxPUSt3WkdSWEY3OWVlQUhE?= =?utf-8?B?a2FCNTNjOXdPS2svZTB5ZGhOQlRYMEMrUVBYVFlyakI0Y1NIbWIxR09oa3Zx?= =?utf-8?B?V2xBQmtHZW9yMThXSG9aUXlmSGVhc0VDblBBU0tHbWxtUnRjendFOEhyS0c3?= =?utf-8?B?Qkd1RXVwMlVnZzNhY1FJMUNGL042T1lrczVjQ0dUaEkxbVdzczRVMS92U1ls?= =?utf-8?B?NTIrRm1TVmNXM2VYaGJLQ1dtSUR4a053bjBWcVIxUjlxV2ltZW5VMnVTZjJZ?= =?utf-8?B?UEZFbHVEbVZteHRZZm96MjZKclVQUDZxTFg3UHpHc3djcmU2TW9POHBaWEdt?= =?utf-8?B?UXZGK3NPOStnVGtWQ040MU50eHlkblI0S2xiVDJFanJwRG5PdmhqRVZnR3Nn?= =?utf-8?B?YUs2Y0xiOFc2VXYyU0JFMHN0S24wU1YzU01TUXpZVDZHQWR2aHRRMldaanRE?= =?utf-8?B?cFRjajNncUhCeHl2YzZuU3NIbUxzYko4aVVjd3dOZ2FRZ0JCV25LRnY1cWFC?= =?utf-8?B?Yzg2dnhqRENpb0JWOFZjbGpqWXhFTTFrK1FzT2p5aEMyQ2lSM2x1NHlNcGRt?= =?utf-8?B?M0pkazJDcDVsay90WkZvRFU2RG1wTVFwUTVLaUdmQkwxU2J0aFYrQThKNU1i?= =?utf-8?B?VEttem9aWGJsOWtHUGFpNzRaeXUxQ1NDYnR1ZGFJSTA5d0JpUHdaUmVJZEww?= =?utf-8?B?dVRIVE03aTU3MlVCci8xTmtzVllrWmNnUEVmZWM5M2kxdUlRRzV4ZVRjczdE?= =?utf-8?B?VGtvbkxBTFV3aW5KSFV5T3M2Nm5qRmZWSXIxaWRmMUdHemZ3ZjQzUjFJT01P?= =?utf-8?B?K2V1U2wxLzY5UFBhNkRGLzZnOVphRURVZ28vWVc2dG94VksxQVZOYmxmMms1?= =?utf-8?B?Z1dybEhnL1Zra2lyN0pCckd0WW1SRW5jTjNlT2Jvck9QK3I4dDQ4MWhtMzFY?= =?utf-8?B?RGFmR2l3QVJiUVo2MnNKd1IyQzc3UjZMY2Vhc2lHcVZ2RXRsRjY4M1U0ZWly?= =?utf-8?B?OEJuNjc4SlB6VFUwcGhHY0I2RTZ5Q2FiSEpWbHFieXV1cURaaWh1czR4YWZl?= =?utf-8?B?SjZLQzc1em0vVk1PVlZlZml6TUFQYmtRNUxLQVJUTk5LVUh2UXJFeUlVVmFn?= =?utf-8?B?c0xCMWQyUVhTTk9ZZ2dDZnp5YXM1MFBObjBJLzZXL1NsSldwWXp0bXl3L0pa?= =?utf-8?B?R1ZuT3hza1g2dnhsNVhpZz09?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3392;6:sC6umOuq+Hz44/HETih5m9SQCHRs0+YD5HSUPZNGNcxbahb66GAvPkRQD7tlUPd54gvSl5VliHueBnC02C9CE+LtA2yZcnSJD3JAkc3Eh5ZQN+hx8tQ7P5BpXZynh4FtPO2rvmIae8YeUrjoAKtIQvP69b/AASaQsj0nxKtLrjCbB8sZion+4t0L3uSEskI1PMseoFQe+QeUJxOBI/gCo8wz76vcfFAxK9NbNp1g2iR8aXlKZIcFX+XPGKuul+fCagAwXbZpsgvpuMuGCPr7FzB4rA30wp1B0RmTYnG6pdo6JjN7O5PwMHW2zcnpyskH7ANpTfFs2qOuCQMXn05e8mn02M+KKdkUw6f+6m+a0o8=;5:+dPdMZmmENEoV6Kj5ywY6UKYc4pfPKHPdag3dr2HSNQJ/4QFDGbcBNh3YubbDoJ+oU47Uf3Rz6UnfCSXCiY3Pr6Y4xnYiYKb+nYn19IFuNzcHFuC8zAP7YldvTYCDTS6qDQcrLbO7oJQwciD5EHQNXUtUiNaWERZ3ro7SZ4mJwg=;24:QN15vs5fRbxp8BRf6TBzYkRqYkIzSWXCnTOEWMLINk6wLxgOa4leVPgcV1MtRcCog0QTLomXw022EeMwxbURwtmddgXf8SUIY6MF+MQUG/w=;7:/FLbQcC2Ht8g+uy5JIUjHAvUZlbr8TTGi5piFSKrCz2mN7Ulawg+p3TiYqd2bdD8nMhnnOlgALny5MKW8bsHzArBWvhr7/PC6c+xmoPoTemXexOlrvQRW8TyYiAA42DL5UPEkk7xK3VpGaNkaOqitgos3Eo3hOHXjkJBa7/3d+FPABGM3x6cAOu5PHfYS9wYYdI/duvQWa/MlNRT/VkeZMrFO3vkpBjS5Sv5W8P5JvZjsjEOikf1NIA69hNuX6/0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2017 11:52:00.9489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3f53fcd-a9a2-4324-ed8c-08d5371f9a27 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3392 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.11.2017 11:01, Geert Uytterhoeven wrote: > On 64-bit (e.g. powerpc64/allmodconfig): > > drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done': > drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > dev_kfree_skb_irq((struct sk_buff *)cur_p->app4); > ^ > > cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer. > > Note that several other fields in struct cdmac_bd are also too small to > hold physical addresses on 64-bit platforms. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/ethernet/xilinx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig > index 6d68c8a8f4f2ac7f..da4ec575ccf9ba4a 100644 > --- a/drivers/net/ethernet/xilinx/Kconfig > +++ b/drivers/net/ethernet/xilinx/Kconfig > @@ -34,6 +34,7 @@ config XILINX_AXI_EMAC > config XILINX_LL_TEMAC > tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver" > depends on (PPC || MICROBLAZE) > + depends on !64BIT || BROKEN > select PHYLIB > ---help--- > This driver supports the Xilinx 10/100/1000 LocalLink TEMAC > Yes. This IP is available only on big endian 32bit systems. Thanks, Michal