From: Dave Hansen <dave.hansen@intel.com>
To: Liang He <windhl@126.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
robh@kernel.org, frank.rowand@sony.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: Add missing of_node_put() in devicetree.c
Date: Wed, 15 Jun 2022 08:33:17 -0700 [thread overview]
Message-ID: <c69f2023-f518-72cd-9991-c672b40d3767@intel.com> (raw)
In-Reply-To: <20220615150325.3969911-1-windhl@126.com>
On 6/15/22 08:03, Liang He wrote:
> In dtb_setup_hpet(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when it
> is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
Seems like:
Fixes: ffb9fc68dff3 ("x86: dtb: Add device tree support for HPET")
and would be appropriate, right?
Also, how was this found, and what is the impact from not fixing it?
Was it causing horrible problems in production, or was it just something
that was found by inspection that's not causing any real problems in
practice?
next prev parent reply other threads:[~2022-06-15 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 15:03 Liang He
2022-06-15 15:33 ` Dave Hansen [this message]
2022-06-15 16:22 ` Rob Herring
2022-06-15 16:26 ` Rob Herring
2022-06-15 16:50 ` 和亮
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c69f2023-f518-72cd-9991-c672b40d3767@intel.com \
--to=dave.hansen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=frank.rowand@sony.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=windhl@126.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®