From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756587AbdABScr (ORCPT ); Mon, 2 Jan 2017 13:32:47 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:48430 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbdABScG (ORCPT ); Mon, 2 Jan 2017 13:32:06 -0500 X-Greylist: delayed 1047 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Jan 2017 13:32:06 EST Subject: Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask To: Andy Shevchenko , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Thomas Petazzoni , linux-kernel@vger.kernel.org References: <20170102113534.127692-1-andriy.shevchenko@linux.intel.com> <20170102113534.127692-3-andriy.shevchenko@linux.intel.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Mon, 2 Jan 2017 19:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170102113534.127692-3-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 02.01.2017 12:35, skrev Andy Shevchenko: > Usually it's not consumer's business to override resources passed from > provider, in particularly DMA coherent mask. > > Signed-off-by: Andy Shevchenko > --- > drivers/staging/fbtft/fbtft-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index e8bf0d1ec11f..226be8c09768 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -841,7 +841,6 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display, > if (txbuflen > 0) { > #ifdef CONFIG_HAS_DMA > if (dma) { > - dev->coherent_dma_mask = ~0; Can we make this conditional like in of_dma_configure(): if (!dev->coherent_dma_mask) dev->coherent_dma_mask = DMA_BIT_MASK(32); If not, I guess the mask has to be set before adding the spi device in fbtft_device.c to keep it from breaking. Noralf. > txbuf = dmam_alloc_coherent(dev, txbuflen, > &par->txbuf.dma, GFP_DMA); > } else