From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbcEUTS7 (ORCPT ); Sat, 21 May 2016 15:18:59 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47198 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbcEUTS4 (ORCPT ); Sat, 21 May 2016 15:18:56 -0400 Subject: Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check functionality test To: Matt Ranostay , sathyanarayanan.kuppuswamy@linux.intel.com References: <20160515183717.GA2674@d830.WORKGROUP> <573E07EA.8050007@linux.intel.com> Cc: Alison Schofield , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jonathan Cameron Message-ID: Date: Sat, 21 May 2016 20:18:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/16 21:19, Matt Ranostay wrote: > Reviewed-by: Matt Ranostay Applied to the togreg branch of iio.git. Thanks, Jonathan > > On Thu, May 19, 2016 at 11:37 AM, sathyanarayanan kuppuswamy > wrote: >> Looks Good. >> >> Reviewed-by:Kuppuswamy Sathyanarayanan >> >> >> >> On 05/15/2016 11:37 AM, Alison Schofield wrote: >>> >>> This driver does not call i2c_smbus_read|write_byte_data(), >>> so remove the corresponding functionality test. It uses regmap >>> to handle byte transfers transparently. >>> >>> Signed-off-by: Alison Schofield >>> --- >>> Found & fixed by inspection based on same defect recently fixed >>> in light/tpl0102 driver. >>> >>> >>> drivers/iio/light/jsa1212.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c >>> index 99a6281..e8a8931 100644 >>> --- a/drivers/iio/light/jsa1212.c >>> +++ b/drivers/iio/light/jsa1212.c >>> @@ -325,9 +325,6 @@ static int jsa1212_probe(struct i2c_client *client, >>> struct regmap *regmap; >>> int ret; >>> - if (!i2c_check_functionality(client->adapter, >>> I2C_FUNC_SMBUS_BYTE_DATA)) >>> - return -EOPNOTSUPP; >>> - >>> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); >>> if (!indio_dev) >>> return -ENOMEM; >> >> >> -- >> Sathyanarayanan Kuppuswamy >> Android kernel developer >>