From: Dan Murphy <dmurphy@ti.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: "Pavel Machek" <pavel@ucw.cz>,
robh+dt@kernel.org, jacek.anaszewski@gmail.com,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
"Vesa Jääskeläinen" <dachaac@gmail.com>
Subject: Re: [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention
Date: Tue, 2 Apr 2019 12:06:52 -0500 [thread overview]
Message-ID: <c6abe495-d7fe-a784-0b9b-1c690b01e008@ti.com> (raw)
In-Reply-To: <20190402181712.3eccdb4b@nic.cz>
Marek
On 4/2/19 11:17 AM, Marek Behun wrote:
> On Tue, 2 Apr 2019 06:40:53 -0500
> Dan Murphy <dmurphy@ti.com> wrote:
>
>> I have had off line conversations with Jacek about this brightness model node.
>>
>> Your concern was actually one of my concerns as well. Not only millions of entries but also having a huge
>> DT binary.
>>
>> We wanted to RFC this to get feedback. And this is why I have not added any support for this in the framework code.
>>
>> Dan
>>
>
> What if we just stuck to color spaces and defined channel curves in the
> device tree?
>
Vesa did a good summary of the current MC framework implementations that are being proposed
The thread also documents Pavel's requirements
https://lore.kernel.org/patchwork/patch/1037147/
And here is the series with a single brightness file and passing in multiple integers.
I did not document this code as I was pretty certain it was not the way to go.
https://patches.linaro.org/project/linux-leds/list/?series=18022
Dan
> The curve could then be defined via an array of integer pairs, which
> would be interpreted as points via which the curve passes and the curve
> would be approximated by linear segemts...
>
> led@0 {
> colorspace = <COLOR_SPACE_ID_RGB>;
> red-curve = <0 0>, <255 255>;
> green-curve = <0 0>, <255 128>;
> blue-curve = <0 0>, <255 128>;
> };
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-04-02 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 17:33 [RFC PATCH 0/5] MultiColor LED framework Documentation Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 1/5] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-04-01 17:33 ` [RFC PATCH 2/5] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-04-01 21:29 ` Pavel Machek
2019-04-02 11:40 ` Dan Murphy
2019-04-02 16:17 ` Marek Behun
2019-04-02 17:06 ` Dan Murphy [this message]
2019-04-02 20:40 ` Jacek Anaszewski
2019-04-02 19:51 ` Jacek Anaszewski
2019-04-01 17:33 ` [RFC PATCH 3/5] documention: leds: Add multicolor class documentation Dan Murphy
2019-04-01 21:18 ` Randy Dunlap
2019-04-01 21:27 ` Pavel Machek
2019-04-02 5:55 ` Marek Behun
2019-04-02 11:53 ` Dan Murphy
2019-04-02 15:56 ` Marek Behun
2019-04-01 17:33 ` [RFC PATCH 4/5] dt-bindings: leds: Add LED_COLOR_ID and COLOR_NAME definitions Dan Murphy
2019-04-01 17:34 ` [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-04-01 21:10 ` Randy Dunlap
2019-04-02 19:07 ` Dan Murphy
2019-04-02 5:44 ` Marek Behun
2019-04-02 11:55 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6abe495-d7fe-a784-0b9b-1c690b01e008@ti.com \
--to=dmurphy@ti.com \
--cc=dachaac@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®