mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Clayton <chris2553@googlemail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	NeilBrown <neilb@suse.de>,
	linux-kernel@vger.kernel.org, scsi <linux-scsi@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: 2.6.30-rc8 Oops whilst booting
Date: Mon, 8 Jun 2009 18:45:51 +0100	[thread overview]
Message-ID: <c6b1100b0906081045t47c77b94ubc89d450c3a75147@mail.gmail.com> (raw)
In-Reply-To: <1244480790.2716.7.camel@ht.satnam>

2009/6/8 Jaswinder Singh Rajput <jaswinder@kernel.org>:

> But reverting your patch Or if we return like this also fix chris
> problem :
>
> diff --git a/kernel/async.c b/kernel/async.c
> index 94dd36f..3b492cb 100644
> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -96,15 +96,13 @@ static async_cookie_t  __lowest_in_progress(struct list_head *running)
>        if (!list_empty(running)) {
>                entry = list_first_entry(running,
>                        struct async_entry, list);
> -               ret = entry->cookie;
> +               return entry->cookie;
>        }
>
>        if (!list_empty(&async_pending)) {
>                list_for_each_entry(entry, &async_pending, list)
> -                       if (entry->running == running) {
> -                               ret = entry->cookie;
> -                               break;
> -                       }
> +                       if (entry->running == running)
> +                               return entry->cookie;
>        }
>
>        return ret;
>
>
>

I can confirm that a kernel built with Jaswinder's patch applied
survived 200 boots without a panic.

Chris

-- 
No, Sir; there is nothing which has yet been contrived by man, by which
so much happiness is produced as by a good tavern or inn - Doctor Samuel
Johnson

  reply	other threads:[~2009-06-08 17:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-06 18:59 Chris Clayton
2009-06-06 21:15 ` Chris Clayton
2009-06-07 13:25   ` Jaswinder Singh Rajput
2009-06-07 18:38     ` Chris Clayton
2009-06-07 22:31       ` Jaswinder Singh Rajput
2009-06-07 22:55         ` NeilBrown
2009-06-08  8:08           ` Chris Clayton
2009-06-08 10:58             ` Chris Clayton
2009-06-08 11:34               ` Jaswinder Singh Rajput
2009-06-08 12:53                 ` Chris Clayton
2009-06-08 16:21                   ` Linus Torvalds
2009-06-08 16:51                     ` James Bottomley
2009-06-08 17:06                       ` Jaswinder Singh Rajput
2009-06-08 17:45                         ` Chris Clayton [this message]
2009-06-08 18:21                           ` Linus Torvalds
2009-06-08 19:17                             ` Chris Clayton
2009-06-08 20:03                               ` Chris Clayton
2009-06-08 17:21                       ` Linus Torvalds
2009-06-08 17:37                         ` Arjan van de Ven
2009-06-08 17:38                         ` James Bottomley
2009-06-08 17:06                     ` James Bottomley
2009-06-08 17:42                       ` Linus Torvalds
2009-06-08 17:49                         ` James Bottomley
2009-06-08 18:33                       ` Chris Clayton
2009-06-08 14:23             ` James Bottomley
2009-06-08 15:04               ` Chris Clayton
2009-06-08 15:17               ` Chris Clayton
2009-06-08 15:32                 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6b1100b0906081045t47c77b94ubc89d450c3a75147@mail.gmail.com \
    --to=chris2553@googlemail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=arjan@linux.intel.com \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®