From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E46433037 for ; Thu, 30 Jul 2026 13:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785417358; cv=none; b=jbCaHXJIus4jKIpn/G1r7apxl5/dgslLelgx/B/SYCXLj0FnJCm17ztJige1Bh7vcQb8ZqBCRtLvaK7ZAMCAJCDQOoh/5C4ITEC8zHSwefveCFd5SMw2oewg8If9VyOMkROhRZVR+GYKZRH8AZTWR+U6X7WSY4OkAPWPT6xp7a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785417358; c=relaxed/simple; bh=0Gay+noS6i9xPynkESz97KDMVs372rcQgMKKEzCCMis=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kjm3WPT53Hnq5vi7QwzMQHIojPBkAm/0lCGa6AwSTiIjl35J0os329uJ3etv6LlglRG3zsc0Hk+7dwGTPIYcpQTs8mgm57nZHurWjgyhOFr2nNIplGeIe75nzZhKZ2OUC4rrFv8mdGRdgr+e1yBNF/jYIzw2olkMt+j261Wt7VQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H7+JR+Wa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HxE8VSr3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H7+JR+Wa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HxE8VSr3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UDDIm31106597 for ; Thu, 30 Jul 2026 13:15:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TV/AlNePEDc1yVWzYXaWBBGXjMpgsekdNRwQeZJstU4=; b=H7+JR+WalzLgxJTU dflmv7r2rCk7iDtUG88n5PpgLqp0cRtMaaIzlvF0UYzQRWUtsGL+iFBaNtIMIvex yr1ZcuOzJDFyGIN3R2YeX+IOQUwE7jjKoIEyzq9k98aJsqsl3zjixxVUIM3CcEym ZNGUIrJ9e+1/74VdKHaeD81aqPMcyGyRwZR+vdIJtZhRTDLcYP1fuAwni2p9r0n9 spOpBKGkX/PZQ5PwYflz5pYOxvU1g8I27WrSVpMAg9yGWSviElnxzkpzHlVjVpUi bT0pBxlpEmruz1RlTb+50rBlFG9MxSsn4jiO6kTC8LbVfOQ8OWzSLM5bAV+HaKDL zB+d8A== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr6xk03ve-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 13:15:54 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0199faafso22510231cf.3 for ; Thu, 30 Jul 2026 06:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785417353; x=1786022153; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TV/AlNePEDc1yVWzYXaWBBGXjMpgsekdNRwQeZJstU4=; b=HxE8VSr3t1zxVWJkjc1oR8ZVEt1iV2I7yHOF7GoEAAF4EdUIvD4Z8Yawt+Bk186NFe UX1mdyzo2FbXm+b8AkgyAIZ44gH6MWtkArkFadUsRcBI+4JDtBvLAnnSqBqn/PYRRNz+ jOT9KtTH9pdfd+2u7fcLOmFUaDnegsZ7N1gajU7kEMItHKMJVLWZx1lh5g1t+mYWyang HFLRbjParEazfPbCQCkWtCI+NTuFuCayLtzsadZInzV3svMEx9chviUYmaRD3NqILtXD 2SSxeX6pwACtRX8J1YXGxTk4ORhaoNE1gxltvmVDdlOEgJjzOFHYySnVydRkryl2qXsR w64g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785417353; x=1786022153; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TV/AlNePEDc1yVWzYXaWBBGXjMpgsekdNRwQeZJstU4=; b=IZ33DMbDyNLiFxuG6njRFDrEE3F4MpJvZFMGWRNWdelZaxhbrJcCbUT64rxDLcthtM pW1t1ls5OHihyHpaYHqdwMlPrmFvUauk4U/JhGbDBtQfDHfdOTswRs8vXBID4pZ1mguM XrMTETHLIQFAulMm1hMEiWdTqr07oZry6BuK32Pd8ToQkYGZwKGeMgDxiWAJhrNnmaQJ 6caRjQSj1uQWWhLHkuBfsn71chsDLtdOjp3Pbk9JeYMygvKXVPof8gsTUv+dGWxvihrM Xywn6Thq6/we79Ap1CXXR3gvPXmH9z+2f2YVw72SoY8aUMck+f9fIyfPI8nQVGlKui4b wWdA== X-Forwarded-Encrypted: i=1; AHgh+RpdyRG8T+aQL34KgRMzEmEnJXekJL49s56txjkpJfhxsI0WdcGXDAJ2Ax42uKQSWfbl38JvyWJNzi0eGYA=@vger.kernel.org X-Gm-Message-State: AOJu0YyMzGeoBtHjD4/z5cwINzQRfhJrw1VUDVhRPUs+U1z6Xdq30rqJ mBNWWt4EHrDsSqJmoeqAjiKZzDNoUcTzQOpC6BXlGKhAX+0xATLTB28euvbcSqvL3QIEp9D01bf 0M4udR5tfcMGL3Ee0vslfMzcPVL5CJBwkara3d7tCIraU/YxpVF8s113efcWHRK2zVY0= X-Gm-Gg: AR+sD13jrPju2KXBnOq54KFmw1KQqSNdnCh4Mjwkx+4neoI8n+bLR9M6h7uzDdh64/y 2HLJxd/NiBHr9IJPZWTCaaA/r5f6CIER31q9Invp0dQBOXh0UNNkxIMGbOw84RInVEI4gfBZkaz a4+wWqayMUWmPm0T7h3PLi+8UjheHQVfliK5qGm5yiNzfU1byV0/Culf8SIlPU2eycVurlkY1z3 GgHnPSw6QS405O0aSOj8177ETISbiXjYkAhLc9nzgr3DzjNo5qG8VdBV3JMv5Nqhoiz1Mgv6G7q TDaJcG3/g+gCO79XIGGdzGAePO4aBn15TDrpxkijYJZx0aNpgSKdxry35xuh9sTL6muPyHZBQvY KELWz27GgO2th0CTXl56LFtfB3HLfCdZmenBmFwmDJrURU7KNU+NZtAMW+v2W52woiRCc0rDs X-Received: by 2002:ac8:5fca:0:b0:51c:ae7:fa1d with SMTP id d75a77b69052e-52b38378859mr28113301cf.5.1785417353196; Thu, 30 Jul 2026 06:15:53 -0700 (PDT) X-Received: by 2002:ac8:5fca:0:b0:51c:ae7:fa1d with SMTP id d75a77b69052e-52b38378859mr28112291cf.5.1785417352129; Thu, 30 Jul 2026 06:15:52 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a07cb79672sm665133a12.13.2026.07.30.06.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 06:15:50 -0700 (PDT) Message-ID: Date: Thu, 30 Jul 2026 16:15:47 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/5] media: qcom: camss: Add V4L2 meta format for CAMSS ISP parameters To: Loic Poulain , Bryan O'Donoghue Cc: Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org References: <20260724-camss-isp-ope-v5-0-e70ad4fa39ce@oss.qualcomm.com> <20260724-camss-isp-ope-v5-1-e70ad4fa39ce@oss.qualcomm.com> <31a77684-221e-452e-85a5-873b0cbbc118@kernel.org> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDEwMCBTYWx0ZWRfXyjyovrLQ+Qoc bSlHnHjB4IFmGagqz6lqmtVagVHQyfbwQlTJcvmHI3il0v0cE6GkLAVPetwWcAEGUn4KTeWgwyM V9ntXyKLe/dkSO0rrNquQfp5vw+Awaw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDEwMCBTYWx0ZWRfX9CSlUiux4lYl iRemvlHKCOZNCqua31YzVKHJO7x76Hi+MnjggFr8Ql/L6U0K2+fmVKTAg0DjUywbPUANQ1iIyAF 2MtVvo7Hqi7G0krjhs1/5z0V1WNBoJViiQsNt2HXO48P+ZD7sieDfWrWsr+wEf100utHufP83rc DKYFSIDYcv9pWj70cHGEhqGpgO1oJ5zLvigtIne96NgnHYj/YEESbPzOCfisj/SaBaWAaBb5/QZ CPuvmorf17wD92EOE1u+dlQZk7eUZRfv/YFZRM/FUSETBOnpzszg+z9S1G9HVukwRvbKOASPvYO hhf5u5BF0WpfWz00Lfb/ZGO2ppU3zW+Q57QeVSPYxZrJc2wQ1xDZjp0bOq7X5l71Sk53xvVa0Bx RghF2v9tu2iGz3kmYICbOey1gek8Sf/5xq80pnmdE+ceNN7X/+Rib9JkrSUo9ph1pGydqUTX28o nry2ypTowmk9Nq0hJsA== X-Authority-Analysis: v=2.4 cv=ToPWQjXh c=1 sm=1 tr=0 ts=6a6b4e8a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=MmO552b29xJCP9fHLIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: NZmaBsDY6OHb76kAhEbh3B42G3xNiw36 X-Proofpoint-ORIG-GUID: NZmaBsDY6OHb76kAhEbh3B42G3xNiw36 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_04,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 adultscore=0 phishscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300100 On 7/30/2026 3:34 PM, Loic Poulain wrote: > On Thu, Jul 30, 2026 at 1:57 PM Bryan O'Donoghue wrote: >> >> On 30/07/2026 12:44, Loic Poulain wrote: >>> On Wed, Jul 29, 2026 at 8:28 PM Gjorgji Rosikopulos (Consultant) >>> wrote: >>>> >>>> Hi Loic, >>>> >>>> On 7/24/2026 3:42 PM, Loic Poulain wrote: >>>>> Add a V4L2 meta format code (V4L2_META_FMT_QCOM_ISP_PARAMS) for the >>>>> Qualcomm CAMSS ISP parameter buffer. This format is used by the params >>>>> video node exposed by CAMSS offline ISP drivers (e.g. OPE) to carry >>>>> ISP tuning data such as white balance, color correction and chroma >>>>> enhancement settings. >>>>> >>>>> Signed-off-by: Loic Poulain >>>>> --- >>>>> drivers/media/v4l2-core/v4l2-ioctl.c | 1 + >>>>> include/uapi/linux/videodev2.h | 3 +++ >>>>> 2 files changed, 4 insertions(+) >>>>> >>>>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> index 98512ea4cc5b9d725e1851af2ed38df85bb4fa8c..7b6e9a9a514f037190d55d59409dd6cc97522943 100644 >>>>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >>>>> @@ -1471,6 +1471,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) >>>>> case V4L2_META_FMT_C3ISP_STATS: descr = "Amlogic C3 ISP Statistics"; break; >>>>> case V4L2_META_FMT_MALI_C55_PARAMS: descr = "ARM Mali-C55 ISP Parameters"; break; >>>>> case V4L2_META_FMT_MALI_C55_STATS: descr = "ARM Mali-C55 ISP 3A Statistics"; break; >>>>> + case V4L2_META_FMT_QCOM_ISP_PARAMS: descr = "Qualcomm CAMSS ISP Parameters"; break; >>>>> case V4L2_PIX_FMT_NV12_8L128: descr = "NV12 (8x128 Linear)"; break; >>>>> case V4L2_PIX_FMT_NV12M_8L128: descr = "NV12M (8x128 Linear)"; break; >>>>> case V4L2_PIX_FMT_NV12_10BE_8L128: descr = "10-bit NV12 (8x128 Linear, BE)"; break; >>>>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h >>>>> index add08188f06890182a5c399a223c1ab0a546cae1..011026194a20cde22a374e6fb2570cbc6bced230 100644 >>>>> --- a/include/uapi/linux/videodev2.h >>>>> +++ b/include/uapi/linux/videodev2.h >>>>> @@ -888,6 +888,9 @@ struct v4l2_pix_format { >>>>> #define V4L2_META_FMT_MALI_C55_PARAMS v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */ >>>>> #define V4L2_META_FMT_MALI_C55_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */ >>>>> >>>>> +/* Vendor specific - used for Qualcomm CAMSS offline ISP */ >>>> >>>> It seems that this is generic format for ISP parameters, can we update the comment and remove offline. The proposal: >>>> /* Vendor specific - used for Qualcomm CAMSS ISP */ >>> >>> Sure. >>> Loic >> >> Since these are not the full list and as I understand them not the full >> structures for OPE - qcom restricting the full formats ? - I'd request >> to move these to an OPE specific header. > > Yes, I think the params struct can be OPE-specific and defined in an > OPE-specific header. However, could we keep the enum in a generic > header so that we only have a single enum definition? We could then > extend it later with OPE-specific or non-OPE-specific parameters as > needed. The format V4L2_META_FMT_QCOM_ISP_PARAMS will be common (based on its name) across all ISP versions. This will make it confusing for userspace to know which header to use for a given ISP version. It would be better to have at least some protection in place to reject param types that aren't supported by a specific version. I think the simpler approach is to keep these as generic Qcom-specific params for now, and only split them out if we actually end up with the same blocks using different parameters across versions. But for sure that can be done latter when new params and ISP's are introduced. It was just an proposal. ~Gjorgji > > Regards, > Loic