From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbdHKOOI (ORCPT ); Fri, 11 Aug 2017 10:14:08 -0400 Received: from mout.web.de ([212.227.15.14]:51821 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbdHKOOG (ORCPT ); Fri, 11 Aug 2017 10:14:06 -0400 To: alsa-devel@alsa-project.org, Alex Deucher , "Gustavo A. R. Silva" , Jaroslav Kysela , Jose Abreu , Liam Girdwood , Mark Brown , Takashi Iwai , Vijendar Mukunda Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ASoC: dwc: Delete an error message for a failed memory allocation in dw_i2s_probe() Message-ID: Date: Fri, 11 Aug 2017 16:12:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/yDuCz7v6knXyGGmfP9fI563+9KnUDOODRCjDFHueUD0Q7aUfri BXGlq8YCePkwSorYI34APO/iajN9Ux/43/DrX8hiNh6gknsiTL5bwtQwL53p4YrrDUxAG26 +EV3kPyXa7DqCpxODx29UMgnSQ/pE8Cab2bTyfaUpgnwTaRnzAEJeIXmQYIb0F2lE8bKn9c Oqk4dEq5ojoIpeDrPxgqQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:LtEWGBRx4GQ=:VHe67uSwiM6dHpJYFNpw4c cv2dthwW1izuTYaQSw0n6tLMUmRzOD999HqyK/lB0RZl/oZe0Sewcx8b2agu+aLzoheQ6k23E wieri0jMOaXZpSPQe55r9jtR6PQceuw2nMiHIFMoxTzIjK/1nx45OHokYs51uEZ8YMCyjylQ9 czJUCEuFU92uhAEwAV6GUHO0UCR9rfRDb6zVcn2t2AOJIpWGJ1WZwlR4GsF+R6E5Ge7u3DsrU Dm4P4OeuiQLT5ksy8Zv0B7vZEYoxACxBcn3L/d1pVhr+2qOLcsKH7uR8MNHQRoRvHRbx21nDt lz0MSmroeO2bqKg9TX6huLLEevLG/GIl+HQmBbRruIdva7D1cmOr+XTEpyqBP8yembvYRLsU+ jlysfncrVntEc0SinQsreTDKBrtFnI/kqQwgM6NsffTM0OgPK2FHVmctipdHfzTqPuJUD4mKX uyIJ04nRdzltwvYndHS0snVhD/+hhROQFlYzrXeJ/ZJfyRIu9mgzJ3ZVxA4BFgbvUp4KvE0L8 E9aMgBTXMLLkwY2DLxHazaBYXz81ByYa/74nzh1CtonQSq5UF7jghareyMPZM56C1PiqPKM0o maCqXLpwLctp5BZpJ7pAEBE86RGMj8dryHZYRMx6GeXuDhPcMKLDm2iiO3UTsGaw4PuWWmDOO qUk2Tcox8Pn0ms+o70Kqri5d0pIOEQmFu3M5KqCimhd313ukaImHTg/JB80ebZZkiOrTm6PwU Mqo97wpRyRMzeRn0AIZLdUjZA88bwmU+ewhZ9lTD+09W6ngrmKCJItHwDgOfZfbmf+wNeQQot qNZzZfrJrbmaiJceF6Z4uz+mU9TtQso6DjyNm7y/12Gk0wlKYg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 11 Aug 2017 16:04:53 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/dwc/dwc-i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index eebe9d34e7a0..e27e21f8569a 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -617,10 +617,8 @@ static int dw_i2s_probe(struct platform_device *pdev) const char *clk_id; dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); - if (!dev) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!dev) return -ENOMEM; - } dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL); if (!dw_i2s_dai) -- 2.14.0