mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@amd.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: acme@kernel.org, eranian@google.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	irogers@google.com, adrian.hunter@intel.com,
	kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	santosh.shukla@amd.com, ananth.narayan@amd.com,
	sandipan.das@amd.com, namhyung@kernel.org,
	Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v3 00/10] perf/amd/ibs: Fix sample period computations
Date: Mon, 16 Dec 2024 12:12:50 +0530	[thread overview]
Message-ID: <c6bb1c11-c869-4e4d-82f1-f1efd2b2d7ec@amd.com> (raw)
In-Reply-To: <20241210093449.1662-1-ravi.bangoria@amd.com>

On 10-Dec-24 3:04 PM, Ravi Bangoria wrote:
> IBS Fetch and IBS Op PMUs have constraints on supported sample period
> values. The IBS hw behavior could be undefined if they are not followed.
> Currently, IBS driver does not honor them correctly and thus a malicious
> event could cause issues to the system. Fortunately, the IBS hw is very
> resilient so far and IBS PMUs are restricted to root only, so the attack
> vector is minimal. In any case, these are genuine bugs and must be fixed.
> 
> There were some conflicts with Namhyung's IBS patches[1] which are now
> in the tip tree, so rebased the series on tip/perf/core (02c56362a7d3).
> 
> v2: https://lore.kernel.org/r/20241206051713.991-1-ravi.bangoria@amd.com
> v2->v3:
>  - No code changes
>  - s/pmu/PMU/g
>  - Include unit test example in the commit description
> 
> [1]: https://lore.kernel.org/r/20241203180441.1634709-1-namhyung@kernel.org

Peter, Ingo, gentle ping.

Thanks,
Ravi

      parent reply	other threads:[~2024-12-16  6:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  9:34 Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 01/10] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 02/10] perf/amd/ibs: Remove pointless sample period check Ravi Bangoria
2024-12-18 13:35   ` Peter Zijlstra
2024-12-10  9:34 ` [PATCH v3 03/10] perf/amd/ibs: Fix ->config to sample period calculation for OP PMU Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 04/10] perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 05/10] perf/amd/ibs: Don't allow freq mode event creation through ->config interface Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 06/10] perf/amd/ibs: Add PMU specific minimum period Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 07/10] perf/amd/ibs: Add ->check_period() callback Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 08/10] perf/core: Introduce pmu->adjust_period() callback Ravi Bangoria
2024-12-18 13:52   ` Peter Zijlstra
2025-01-08 11:16     ` Ravi Bangoria
2024-12-10  9:34 ` [PATCH v3 09/10] perf test: Introduce DEFINE_SUITE_EXCLUSIVE() Ravi Bangoria
2024-12-13 19:55   ` Arnaldo Carvalho de Melo
2024-12-10  9:34 ` [PATCH v3 10/10] perf test amd ibs: Add sample period unit test Ravi Bangoria
2024-12-16  6:42 ` Ravi Bangoria [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6bb1c11-c869-4e4d-82f1-f1efd2b2d7ec@amd.com \
    --to=ravi.bangoria@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ananth.narayan@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sandipan.das@amd.com \
    --cc=santosh.shukla@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®