From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Tang Bin <tangbin@cmss.chinamobile.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe()
Date: Fri, 8 May 2020 23:30:05 +0300 [thread overview]
Message-ID: <c6c1f7e2-e8c6-d120-23de-fa1b566661d4@cogentembedded.com> (raw)
In-Reply-To: <20200508114858.GA4085349@kroah.com>
On 05/08/2020 02:48 PM, Greg KH wrote:
>> The function ehci_mxc_drv_probe() does not perform sufficient error
>> checking after executing platform_get_irq(), thus fix it.
>>
>> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
>> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>> ---
>> drivers/usb/host/ehci-mxc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
>> index a1eb5ee77..a0b42ba59 100644
>> --- a/drivers/usb/host/ehci-mxc.c
>> +++ b/drivers/usb/host/ehci-mxc.c
>> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>> }
>>
>> irq = platform_get_irq(pdev, 0);
>> + if (irq < 0)
>> + return irq;
>
> <= ?
I thought I've fixed the ambivalent zero bug some years ago...
Please don't do this...
MBR, Sergei
next prev parent reply other threads:[~2020-05-08 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 11:44 Tang Bin
2020-05-08 11:48 ` Greg KH
2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin
2020-05-08 14:31 ` Greg KH
2020-05-08 15:03 ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin
2020-05-08 20:27 ` Sergei Shtylyov
2020-05-09 1:13 ` Tang Bin
2020-05-08 20:30 ` Sergei Shtylyov [this message]
2020-05-08 13:51 ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Alan Stern
2020-05-13 12:55 ` Tang Bin
2020-05-13 13:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c1f7e2-e8c6-d120-23de-fa1b566661d4@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®