From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7BAC1CBEB9 for ; Fri, 28 Nov 2025 01:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295076; cv=none; b=uOyDrfY/zmShRKescYStqiH7meWnlv8ta1AxS2bvFohQ2RRsqkfSICQNI3CQMZxrKcmyBqNswoMf8z69km+7g054CWPwMJx+hkVTgDW7j4jTTWWE6EC7ng2enw01y4D+VjTT6wDiDtTbdwbX+s4G72HqCOodJFD8mXoo9r/WWnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295076; c=relaxed/simple; bh=P1FhVpK3AxAt+DDTr+OuLF9yrrXqdgHn6ibFEVhCvzE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=VkujfDP7kiE000kO5WU29XZAx+NNoKfwPfkI4aRASEyDlpUCuL8wT4+gYWEQzQNljF6/jz5/KldM15KwWl/lNduuVgn78b3Qwlc/XmrGIOPJlzWxMj0TWN+3GWOWufgb61yliMh+VNeqcP8GoTSVboOb6dzwBEx2NoZ+X6CB7G0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=huieEjMH; arc=none smtp.client-ip=115.124.30.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="huieEjMH" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1764295071; h=Message-ID:Date:MIME-Version:Subject:From:To:Content-Type; bh=c2ieEv/xIsEt38uURYmMANNeIDhTzIYb5HlDSR+msmM=; b=huieEjMHr+X+QGcyvLXmyXa5xK56P28HQegnBKMefmH+PBtNv3a2zpIgmJM299E+pYDhgWnwwRA3j9nL5oBPMDtIH4htwahdebqiaAWmbO4pYz36gVAaHdW8arnqRbUdNmNlDe8m+pjXH193W7zZQwpfXlWS7pEe0XbZDcKA39o= Received: from 30.221.130.183(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WtZP.Oh_1764295070 cluster:ay36) by smtp.aliyun-inc.com; Fri, 28 Nov 2025 09:57:51 +0800 Message-ID: Date: Fri, 28 Nov 2025 09:57:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs: get rid of raw bi_end_io() usage From: Gao Xiang To: Ming Lei , Christoph Hellwig Cc: linux-erofs@lists.ozlabs.org, LKML , Stephen Zhang References: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025/11/28 09:40, Gao Xiang wrote: > > > On 2025/11/28 08:58, Ming Lei wrote: >> On Thu, Nov 27, 2025 at 04:07:56PM +0800, Gao Xiang wrote: >>> These BIOs are actually harmless in practice, as they are all pseudo >>> BIOs and do not use advanced features like chaining.  Using the BIO >>> interface is a more friendly and unified approach for both bdev and >>> and file-backed I/Os. >>> >>> Let's use bio_endio() instead. >>> >>> Signed-off-by: Gao Xiang >>> --- >>> v2: >>>   - call bio_endio() unconditionally in erofs_fileio_ki_complete(). >> >> bio_endio() can cover bio not submitted yet, so: ( btw, nevertheless, it's not submitted, just with or without a given bio callback. ) I believe that is ok anyway. >> >> Reviewed-by: Ming Lei > > Thank you and Christoph for review! > > Thanks, > Gao Xiang