From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A4A5E7E644 for ; Tue, 26 Sep 2023 15:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232462AbjIZPUf (ORCPT ); Tue, 26 Sep 2023 11:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233293AbjIZPUc (ORCPT ); Tue, 26 Sep 2023 11:20:32 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4BE9199; Tue, 26 Sep 2023 08:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695741624; x=1727277624; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nB6ZESUpQait4Sao7+LPxqiHduWytkDaP5+UtQrukm0=; b=atupXXp2NYyjUrFRQwSMz5bbjfnU9AklX2fRZ98F81FxnAbXJOkGtAz/ /nHsTmg4FQDvYGkAxjcLjfErsjDdOTjqpWUZhNPuRJi4DNGc9e543ezkA VebxLhwP0W1dTC4VsByzEC8oTG9/zW1d1hC6qOLinENmcr6NpUAZ80EIg AUiN9qX5ncrJvKGUbufWdX78QhIQg5uQ0W6OkwDhTcJ5CI5nrY8cF/Ai6 /DVHNDVzrSNt/6FmkgluePPn+QUoUwGaeoP0jA2YEJhuf+C1Xo6BfB2NA 8nD+J/+0Bi4W7DzTi5Ejl7yedyifv13oXbBlwZ0YRMIIFlrI18Cc4dnPH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="412506676" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="412506676" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 08:20:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="783977450" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="783977450" Received: from linux.intel.com ([10.54.29.200]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 08:20:23 -0700 Received: from [10.209.130.196] (kliang2-mobl1.ccr.corp.intel.com [10.209.130.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id C7A72580BBE; Tue, 26 Sep 2023 08:20:21 -0700 (PDT) Message-ID: Date: Tue, 26 Sep 2023 11:20:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH 04/25] perf pmu-events: Add counter info into JSON files for SapphireRapids Content-Language: en-US To: weilin.wang@intel.com, Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Perry Taylor , Samantha Alt , Caleb Biggers , Mark Rutland References: <20230925061824.3818631-1-weilin.wang@intel.com> <20230925061824.3818631-5-weilin.wang@intel.com> From: "Liang, Kan" In-Reply-To: <20230925061824.3818631-5-weilin.wang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-09-25 2:18 a.m., weilin.wang@intel.com wrote: > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > index 2809f68d2..5614bc203 100755 > --- a/tools/perf/pmu-events/jevents.py > +++ b/tools/perf/pmu-events/jevents.py > @@ -655,7 +655,7 @@ def preprocess_one_file(parents: Sequence[str], item: os.DirEntry) -> None: > _bcs.add(pmu_name, metric=True) > _bcs.add(event.build_c_string(metric=True), metric=True) > if event.size: > - _bcs.add(event.build_c_string(metric=False, layout=True)) > + _bcs.add(event.build_c_string(metric=False, layout=True), metric=False) > What's it for? Seems should belong to a dedicated patch? Thanks, Kan > def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None: > """Process a JSON file during the main walk.""" > --