From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932348AbdJZQul (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Oct 2017 12:50:41 -0400
Received: from mout.web.de ([217.72.192.78]:53633 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932127AbdJZQui (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Oct 2017 12:50:38 -0400
Subject: Re: [PATCH] iio/light/max44000: Use common error handling code in
 max44000_probe()
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
        Crestez Dan Leonard <leonard.crestez@intel.com>,
        Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <28854212-d360-8636-4de5-017fbee0db36@users.sourceforge.net>
 <20171026172926.62d5ff87@archlinux>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c6c5a2d0-39e6-0792-a6d3-4f2861a7eb5a@users.sourceforge.net>
Date: Thu, 26 Oct 2017 18:50:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171026172926.62d5ff87@archlinux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:hygY/IvisxEXVsNpgDBjwxh+iPpuHM1b1sXind87ZLop3oZVpdC
 dGL6Hh/FPfQUpkXIf4MyFumoKVMlvil5/bLAGejOq9BpP7B7oY9UW4ZyNsBa5StfmtBQZQR
 iskUNViAMg5qQj2HPMCwUEr2o2Dze2WE5wNQotwqwzhACvmwJrrgdOc2pR2OLpyemeccnpR
 DdzFbJwMO1x4ptJemHxnw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yG4YSy1ikXs=:ZttI+nJSlzPTERHl4RXYgg
 lh7epA6GxKOFkRwV/3Uc6XwpUF32gOHSo+ws8t6r5+JPlBHyD/xsipntTsJU7W/OqiNcw6Hbg
 c2eI6mlf6E6PgQUyExThYvPjWao4OGpjP7LBfzTSKfT1FJc7c/28OG/w6TQCj2iApflVqBUil
 riSqz9tKbhWXmK9bBsywYPRsCMmQVb1r2w4RGzpDbezQjcPBRIEliL3lMneDv7ixWqxxbPmAc
 0gK0t+uTfjvrzYn0nJO0n+PH+I0asPuulszPt+r/iMUVXkYAymcm5wFC2MriHjPYwSaaVIJjD
 R6tuV4JRo50/nEhNNK06O9unntRzoec1SdrCOcIRmMTNGxkimRlt8905piFVu1mqN/kD62G8f
 ymIu7F8HmPUekqnN10cGnb9nrsHRl77NLdafsEdIrppeqNurYI1ssAilefAxwvY8MvYRpVex/
 OpvFWkq8WB2DwjYGnBCZ4SBFihC4iHG7AIHTh8zCWaBH7JXUP51BU+QJxtfl0yLpnX0qvBg+/
 cyIqxEIAoqoZofnoQ/JayjvawxMsEy4ETBUebNVifHEdom5HX7617FF0APhxFDCsPmpDE0Q4G
 N8IqZulOJdDJ8/B7HlMg16xkjbbkBZOP3WhR9+yj4U8lbQYC3eykgF/DIbUieFFsPLaLr6b5+
 AyUa/7BTh3XoZVVghZuseLKKnNgizIzsFHxEBxJjrXn4bewEj0Eib+xRnFcB8KLIWVINQN1em
 Ecw3AypRjBi5lQYlzto6UOS2i62ruc0ki/TuYm3PTJQhU88Lv3TEMjfk7a/KUz+dOvt7NNKbU
 Ms0R/mFfoDn+xghnyXeQenbdjBe/nMMkmkcLVqAt5h1eBp7XXs=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -596,6 +592,10 @@ static int max44000_probe(struct i2c_client *client,
>>  	}
>>  
>>  	return iio_device_register(indio_dev);
>> +
>> +report_failure:
>> +	dev_err(&client->dev, "failed to write init config: %d\n", ret);
> This reduces readability of the code for a very minor gain.

I got an other software development view on this aspect.


> Printing an error message is not a source of bugs

I find such a general information questionable.

It is also possible to discover various update candidates in this software area.


> or similar unlike unwinding some state, so a unified path makes little sense.

How does such a view fit to the section “7) Centralized exiting of functions”
in the document “coding-style.rst”?

Regards,
Markus