From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD54C388F7 for ; Fri, 13 Nov 2020 12:20:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CF6D2224B for ; Fri, 13 Nov 2020 12:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgKMMUi (ORCPT ); Fri, 13 Nov 2020 07:20:38 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7537 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbgKMMUh (ORCPT ); Fri, 13 Nov 2020 07:20:37 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CXcTg6xYLzhkB3; Fri, 13 Nov 2020 19:59:51 +0800 (CST) Received: from [10.174.179.81] (10.174.179.81) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Fri, 13 Nov 2020 19:59:57 +0800 Subject: Re: [PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill() To: Jakub Kicinski CC: , , , , References: <20201111135853.63997-1-wanghai38@huawei.com> <20201112095124.660733a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: "wanghai (M)" Message-ID: Date: Fri, 13 Nov 2020 19:59:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201112095124.660733a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.81] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/11/13 1:51, Jakub Kicinski 写道: > On Wed, 11 Nov 2020 21:58:53 +0800 Wang Hai wrote: >> If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), >> msg should be canceled by genlmsg_cancel(). >> +++ b/net/core/devlink.c >> @@ -1447,8 +1447,10 @@ static int devlink_nl_sb_port_pool_fill(struct sk_buff *msg, [...] >> return err; > I guess the driver would have to return -EMSGSIZE for this to matter, > which is quite unlikely but we should indeed fix. > > Still, returning in the middle of the function with an epilogue is what > got use here in the first place, so please use a goto. E.g. like this: > [...] > static int devlink_nl_cmd_sb_port_pool_get_doit(struct sk_buff *skb, > > . Thanks for your review,  I just sent v2 [PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()