From: <Conor.Dooley@microchip.com>
To: <xianting.tian@linux.alibaba.com>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<akpm@linux-foundation.org>, <anup@brainfault.org>,
<wangkefeng.wang@huawei.com>, <rppt@kernel.org>, <alex@ghiti.fr>,
<twd2.me@gmail.com>, <david@redhat.com>, <seanjc@google.com>,
<petr.pavlu@suse.com>, <atishp@rivosinc.com>
Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<guoren@kernel.org>, <jianghuaming.jhm@alibaba-inc.com>,
<mick@ics.forth.gr>
Subject: Re: [PATCH] RISC-V: Remove IORESOURCE_BUSY flag for no-map reserved memory
Date: Wed, 11 May 2022 11:32:23 +0000 [thread overview]
Message-ID: <c6c9c8d2-cc6b-cd5b-a066-44bd970f9292@microchip.com> (raw)
In-Reply-To: <20220511112413.559734-1-xianting.tian@linux.alibaba.com>
On 11/05/2022 12:24, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Commit 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree")
> added IORESOURCE_BUSY flag for no-map reserved memory, this casued
> devm_ioremap_resource() failed for the no-map reserved memory in subsequent
> operations of related driver, so remove the IORESOURCE_BUSY flag.
>
> The code to reproduce the issue,
> dts:
> mem0: memory@a0000000 {
> reg = <0x0 0xa0000000 0 0x1000000>;
> no-map;
> };
>
> &test {
> status = "okay";
> memory-region = <&mem0>;
> };
>
> code:
> np = of_parse_phandle(pdev->dev.of_node, "memory-region", 0);
> ret = of_address_to_resource(np, 0, &r);
> base = devm_ioremap_resource(&pdev->dev, &r);
> // base = -EBUSY
>
> Fixes: 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree")
> Reported-by: Huaming Jiang <jianghuaming.jhm@alibaba-inc.com>
> Reviewed-by: Guo Ren <guoren@kernel.org>
> CC: Nick Kossifidis <mick@ics.forth.gr>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Hey Xianting,
This resend is no different to the patch you sent 5 mins ago, right?
Thanks,
Conor.
next prev parent reply other threads:[~2022-05-11 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 11:24 Xianting Tian
2022-05-11 11:32 ` Conor.Dooley [this message]
2022-05-11 12:27 ` David Hildenbrand
2022-05-11 12:37 ` Xianting Tian
2022-05-11 12:43 ` Xianting Tian
-- strict thread matches above, loose matches on Subject: below --
2022-05-11 11:18 Xianting Tian
2022-05-12 2:32 ` Nick Kossifidis
2022-05-12 2:50 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c9c8d2-cc6b-cd5b-a066-44bd970f9292@microchip.com \
--to=conor.dooley@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=david@redhat.com \
--cc=guoren@kernel.org \
--cc=jianghuaming.jhm@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=petr.pavlu@suse.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=twd2.me@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®