mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] powerpc: Add generic PAGE_SIZE config symbols
Date: Wed, 18 May 2022 09:41:02 +0000	[thread overview]
Message-ID: <c6cbd41c-4cef-d4d7-324a-b4c3e2498262@csgroup.eu> (raw)
In-Reply-To: <20220505125123.2088143-1-mpe@ellerman.id.au>



Le 05/05/2022 à 14:51, Michael Ellerman a écrit :
> Other arches (sh, mips, hexagon) use standard names for PAGE_SIZE
> related config symbols.
> 
> Add matching symbols for powerpc, which are enabled by default but
> depend on our architecture specific PAGE_SIZE symbols.
> 
> This allows generic/driver code to express dependencies on the PAGE_SIZE
> without needing to refer to architecture specific config symbols.

I guess next step should be to get rid of powerpc specific symbols and 
use generic symbols instead.

We have (only) 111 occurences of it.


> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>   arch/powerpc/Kconfig | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 145af02df3dc..02994361cc7a 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -759,6 +759,22 @@ config PPC_256K_PAGES
>   
>   endchoice
>   
> +config PAGE_SIZE_4KB
> +	def_bool y
> +	depends on PPC_4K_PAGES
> +
> +config PAGE_SIZE_16KB
> +	def_bool y
> +	depends on PPC_16K_PAGES
> +
> +config PAGE_SIZE_64KB
> +	def_bool y
> +	depends on PPC_64K_PAGES
> +
> +config PAGE_SIZE_256KB
> +	def_bool y
> +	depends on PPC_256K_PAGES
> +
>   config PPC_PAGE_SHIFT
>   	int
>   	default 18 if PPC_256K_PAGES

  parent reply	other threads:[~2022-05-18  9:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 12:51 Michael Ellerman
2022-05-05 12:51 ` [PATCH 2/2] arch/Kconfig: Drop references to powerpc PAGE_SIZE symbols Michael Ellerman
2022-05-18  9:41 ` Christophe Leroy [this message]
2022-05-18 13:00   ` [PATCH 1/2] powerpc: Add generic PAGE_SIZE config symbols Michael Ellerman
2022-05-18 13:21     ` Arnd Bergmann
2022-05-18 13:27       ` Christophe Leroy
2022-05-24 11:09 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6cbd41c-4cef-d4d7-324a-b4c3e2498262@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®