From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA0651DDF7 for ; Thu, 7 Aug 2025 13:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754571704; cv=none; b=AykSN3x+FmwOWOdwDDFH1JknY+FwIPUgcMMg+LHEnflvqCkJgDpqVLtk/0XWPMGafEAAlRdrVRqQGL2+EP9o6FuCmAun27X5+XWWF7shtgEWcPvM5mLueQeAa3Nwfk2AinV8zq+a2bSWitMcmFO7Fg9uyEWxikrFrRrO6OYhcAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754571704; c=relaxed/simple; bh=mmyBxkqHpXp2V1j9z6LTAD25za994gTv0/Hssc3cksE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XWStLx7znRGNOLZT1Rxtr8xsuzEQEhJ/WFvLsGDyHkpNID6whhdGPepgsq+s73UMRNrXYt2HICcvyA+3Bms/kUeBRB0OYnBhR0HJ7cxOE6uNZjOpM+SSSNSvlvTU4UsZXlgrxYITOtAC4nqZI0YasAYh9xcf841KchGAcGRPZ7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=LSMmnIqg; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="LSMmnIqg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; bh=EBhCzjneXCGj0erlFreQN427ublgLKEokx3ZEVCX9yQ=; b=LSMmnIqgiE0YWRds6kHJR7n6dI+UgA6UiXVqACK2cB3XtN/OE28NXD2o/BNI5B I/V4Pk+RdmqyQqMbPHD48VEbs9HHGmcPHA8Vj/NN47djuhoMn+RZL3TwyjCo4d5a yGQg7XkwTsTtfxEaywLZFoxN1DlGjPSLpVxAK6BdiDYJE= Received: from [10.42.20.80] (unknown []) by gzsmtp5 (Coremail) with SMTP id QCgvCgCXKhubo5Ro43lrDA--.5300S2; Thu, 07 Aug 2025 21:01:16 +0800 (CST) Message-ID: Date: Thu, 7 Aug 2025 21:01:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/amdgpu: skip disabling audio when device is unplugged To: =?UTF-8?Q?Christian_K=C3=B6nig?= , Alex Deucher Cc: David Airlie , Simona Vetter , Sunil Khatri , Alexandre Demers , Boyuan Zhang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou References: <20250807094719.56145-1-oushixiong1025@163.com> <9a632900-4ebb-40af-8bf8-bf55f8e25c7b@amd.com> From: oushixiong In-Reply-To: <9a632900-4ebb-40af-8bf8-bf55f8e25c7b@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:QCgvCgCXKhubo5Ro43lrDA--.5300S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxZFyDAF13GFyfWF1UWFyfWFg_yoW5tw4rpr 1Fya4Ykw4UZw4jqa1IyF9rZFn5Aa17W3WrurWxJr1SgayDAr9Yqa4rtF18u3s8JrWvvFW2 q347JryUZFn09aDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U0D7-UUUUU= X-CM-SenderInfo: xrxvxxx0lr0wirqskqqrwthudrp/1tbiXA2iD2iUdwxDwgABs7 Should we move audio disabling to hw_fini()? Regards, Shixiong Ou. 在 2025/8/7 18:03, Christian König 写道: > On 07.08.25 11:47, oushixiong1025@163.com wrote: >> From: Shixiong Ou >> >> When Stopping lightdm and removing amdgpu driver are executed, the following >> error is triggered probably: >> >> Unable to handle kernel paging request at virtual address 0000000000005e00 >> ..... >> [ 2] [T10084] Call trace: >> [ 2] [T10084] amdgpu_device_wreg.part.0+0x58/0x110 [amdgpu] >> [ 2] [T10084] amdgpu_device_wreg+0x20/0x38 [amdgpu] >> [ 2] [T10084] dce_v6_0_audio_endpt_wreg+0x64/0xd8 [amdgpu] >> [ 2] [T10084] dce_v6_0_sw_fini+0xa0/0x118 [amdgpu] >> [ 2] [T10084] amdgpu_device_ip_fini.isra.0+0xdc/0x1e8 [amdgpu] >> [ 2] [T10084] amdgpu_device_fini_sw+0x2c/0x220 [amdgpu] >> [ 2] [T10084] amdgpu_driver_release_kms+0x20/0x40 [amdgpu] >> [ 2] [T10084] devm_drm_dev_init_release+0x8c/0xc0 [drm] >> [ 2] [T10084] devm_action_release+0x18/0x28 >> [ 2] [T10084] release_nodes+0x5c/0xc8 >> [ 2] [T10084] devres_release_all+0xa0/0x130 >> [ 2] [T10084] device_unbind_cleanup+0x1c/0x70 >> [ 2] [T10084] device_release_driver_internal+0x1e4/0x228 >> [ 2] [T10084] driver_detach+0x90/0x100 >> [ 2] [T10084] bus_remove_driver+0x74/0x100 >> [ 2] [T10084] driver_unregister+0x34/0x68 >> [ 2] [T10084] pci_unregister_driver+0x24/0x108 >> [ 2] [T10084] amdgpu_exit+0x1c/0x3270 [amdgpu] >> [ 2] [T10084] __do_sys_delete_module.constprop.0+0x1d0/0x330 >> [ 2] [T10084] __arm64_sys_delete_module+0x18/0x28 >> [ 2] [T10084] invoke_syscall+0x4c/0x120 >> [ 2] [T10084] el0_svc_common.constprop.0+0xc4/0xf0 >> [ 2] [T10084] do_el0_svc+0x24/0x38 >> [ 2] [T10084] el0_svc+0x24/0x88 >> [ 2] [T10084] el0t_64_sync_handler+0x134/0x150 >> [ 2] [T10084] el0t_64_sync+0x14c/0x150 >> [ 2] [T10084] Code: f9401bf7 f9453e60 8b150000 d50332bf (b9000016) >> [ 2] [T10084] ---[ end trace 0000000000000000 ]--- >> >> The adev->rmmio has been unmmaped in amdgpu_device_fini_hw(). >> >> So skip disabling audio when device is unplugged. >> >> Signed-off-by: Shixiong Ou >> --- >> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c >> index 276c025c4c03..48b29990da7f 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c >> @@ -23,6 +23,7 @@ >> >> #include >> >> +#include >> #include >> #include >> #include >> @@ -1459,8 +1460,10 @@ static void dce_v6_0_audio_fini(struct amdgpu_device *adev) >> if (!adev->mode_info.audio.enabled) >> return; >> >> - for (i = 0; i < adev->mode_info.audio.num_pins; i++) >> - dce_v6_0_audio_enable(adev, &adev->mode_info.audio.pin[i], false); >> + if (!drm_dev_is_unplugged(adev_to_drm(adev))) { > Good catch, but that looks like a workaround for something done in the wrong place. > > A *_sw_fini() function should not enable/disable HW. > > Regards, > Christian. > >> + for (i = 0; i < adev->mode_info.audio.num_pins; i++) >> + dce_v6_0_audio_enable(adev, &adev->mode_info.audio.pin[i], false); >> + } >> >> adev->mode_info.audio.enabled = false; >> }