From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5559F23F377 for ; Wed, 12 Mar 2025 12:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741782154; cv=none; b=EyAD73SuU0lbtURVBdP8mqQhppAXa9193t6ofAuX1ACby90kWGe2DeBh/sKDqchbI3+iS8cfWJgFL7hcw5B64YGhXl1DHh+YmpmW0pAICrhW4oUlOnyUOk/C5jb2e4Dlh2CsXTgwqEH4hVBk5UZTum2EHzA1qMbVE2Yh+UOQGc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741782154; c=relaxed/simple; bh=b3SPoXq+q0fJCQnjD9EiQdK/XHzu4BaOKr5jHZIcVyg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dD8CuKiSBnjuwfZMd3X6zISEHhcYuN6xE7/ULvFgjb+gkiXU5REssy3R5CrAeOrHve7n3RLDN79BQ3FW6sjmzmsgsrUNsTBYjoo44RBgyejGMQhoLlB3TftHoMOHClHsz7xIyUGf5rnPX3aAWrn04JzPV2uYi3EYDP+2uE6CaFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wlwn1j3/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wlwn1j3/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741782151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DPRWkNl2nLos7QUvYH28gU/BVhbS7HBoq6YbRwrOFbU=; b=Wlwn1j3/x7504qIN0SHWEqcpwzXIryRqSQbSO8KEqlYlOC+MO4zDeybX8V12Rgq4Gr6SSy VIpS0XgfN5gA1szLyIzkahH54vjL2EGsvkM445dWGqY5TmGMSsoo4VFx70tHl8LT59rnGR aaGUfa0ey9l7qXNL5yRUPHoyOJ++IH8= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332-5AqM8TzNPqyTIhOaXODs-w-1; Wed, 12 Mar 2025 08:22:30 -0400 X-MC-Unique: 5AqM8TzNPqyTIhOaXODs-w-1 X-Mimecast-MFC-AGG-ID: 5AqM8TzNPqyTIhOaXODs-w_1741782148 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-308fefb2bd0so29789171fa.1 for ; Wed, 12 Mar 2025 05:22:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741782148; x=1742386948; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DPRWkNl2nLos7QUvYH28gU/BVhbS7HBoq6YbRwrOFbU=; b=tvsW+waDWlhpAvNyeUywefEaSWWcAlz0WJ1X2zW9LVmSKcQJ4aY+e+JlafNJe54Ye7 Zat0w7OPTEE1MK0z6VRaDjZjtdQpChN1vxDg9Jm8vsJ1Pe0zEsRjEo1Y6pIoEOHrRor0 rBeDraO6yk3FNqY2wGVzb1RpABxU4XumUGQmfXQJyQJIFKfLeqJb5EaXBHO8F5Wg8v34 Fs9dkH1Tw7FQ7C3Tzccb1Icphnc5SxoGyaSOh8Y7n7gs7tF+qSlMujp8Sdc8jzHda0R5 vRGQlXqMq37X/P16f3dZtFdiAHinz4PiaboJ1gXS7Ct5bde/mTNLCZlOylReoR+4wiZ7 jMSQ== X-Forwarded-Encrypted: i=1; AJvYcCUsu/rpB83hgZjG/7uZGUWOokHDCCG8eKEFxVE0mu73EOvfdcfw0DsgKdJqns6w6epXIZYf3ik/PHwjOR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxmkTnwmvQoor961IljaXvF9P1Yf5o/kulQ2dHnjn2KJxble6kk D9AYUmN0oW//m8s/S69gc6YRkLRb/ZZe6ZL8FsSfdeq6zB9ck0Nuz2QNGdyy4G1u/Si6/YuHLf+ +cf6Fpf2RDDxiZ5w9w5RPGEoCqExDE1YgSZ8MakoeU4gjb3As+dBjKrHkZXhjRTHBuCJwIQ== X-Gm-Gg: ASbGncv2CBH7tUdm1tVxlHELLgsfCZUl0yVwj7R1u180cl2ByU6p6kYM9G6CU4Z2Q4Q yUwFubc3wFFRuf8R53KSqbGp3m3nTT59CNGh8UxyMy7fWY0g4zjDIb7Tzk3FIn2XDjE85e3gYRA rKS8WJ764jd/kY7YWSvQYVVuzRUfBIj9jGZ4bQBBVojmsNIQcnEX4aan4BDnQa160cM9tVGuAIR EfCNQdJ391l+RikZ7ruP9EY6TMZw1PleJyG6keft4NFq4k2wqL8mWpST1k8fYgcMJ2Y1WuNQpkH WgPOJXpp8bfZSINlvuo/WQ== X-Received: by 2002:a2e:be05:0:b0:30c:c7a:d98 with SMTP id 38308e7fff4ca-30c0c7a0e25mr51188921fa.25.1741782147935; Wed, 12 Mar 2025 05:22:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWfgju5A2/UIZdEYK/IjBij/vjP1ystRZ5v2z4XI80BttFgw4A2UjJNQGinXsNU3xv7Fvzjw== X-Received: by 2002:a2e:be05:0:b0:30c:c7a:d98 with SMTP id 38308e7fff4ca-30c0c7a0e25mr51188761fa.25.1741782147528; Wed, 12 Mar 2025 05:22:27 -0700 (PDT) Received: from [192.168.10.81] ([176.206.122.167]) by smtp.googlemail.com with ESMTPSA id 38308e7fff4ca-30c1b89ec47sm9027231fa.0.2025.03.12.05.22.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 05:22:26 -0700 (PDT) Message-ID: Date: Wed, 12 Mar 2025 13:22:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] KVM: kvm-coco-queue: Support protected TSC To: Isaku Yamahata , kvm@vger.kernel.org Cc: Sean Christopherson , chao.gao@intel.com, rick.p.edgecombe@intel.com, yan.y.zhao@intel.com, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Nikunj A Dadhania , Marcelo Tosatti References: From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/12/24 09:55, Isaku Yamahata wrote: > The current x86 KVM implementation conflicts with protected TSC because the > VMM can't change the TSC offset/multiplier. Disable or ignore the KVM > logic to change/adjust the TSC offset/multiplier somehow. > > Because KVM emulates the TSC timer or the TSC deadline timer with the TSC > offset/multiplier, the TSC timer interrupts are injected to the guest at the > wrong time if the KVM TSC offset is different from what the TDX module > determined. > > Originally the issue was found by cyclic test of rt-test [1] as the latency in > TDX case is worse than VMX value + TDX SEAMCALL overhead. It turned out that > the KVM TSC offset is different from what the TDX module determines. > > The solution is to keep the KVM TSC offset/multiplier the same as the value of > the TDX module somehow. [...] Ignore (or don't call related functions) the > request to change the TSC offset/multiplier. > > [...] With this patch series, SEV-SNP secure TSC can be supported. Thanks, I've squashed these changes (apart from setting vcpu->arch.guest_tsc_protected) into the corresponding patches in kvm-coco-queue. Just one small change is needed in patch 2, to which I will reply. For SEV-SNP, all that's necessary on top should be diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index d92e97baea0f..beddeed90ff0 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -2481,6 +2481,9 @@ static int snp_launch_update_vmsa(struct kvm *kvm, struct kvm_sev_cmd *argp) } svm->vcpu.arch.guest_state_protected = true; + if (snp_secure_tsc_enabled(kvm)) + svm->vcpu.arch.guest_tsc_protected = true; + /* * SEV-ES (and thus SNP) guest mandates LBR Virtualization to * be _always_ ON. Enable it only after setting For the sake of testing, I applied the latest SEV-SNP host patches from https://github.com/AMDESE/linux-kvm/commits/sectsc-host-latest to kvm-coco-queue as well, plus the above hunk; Nikunj can integrate it in the next revision of https://lore.kernel.org/kvm/20250310064347.13986-1-nikunj@amd.com/T/. Paolo