From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D444376BC2 for ; Tue, 24 Feb 2026 10:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771927966; cv=none; b=c70I5o05XXLnwJAbeqDdiZjc1cnmqh31STwX8YBSIQdBOOSKbDLtzOIiM5vMFfO9tm3FkjE3s1Y9IGDX2UVfkeWBvqJSuWBob4IvpPZMzzfP4vfClgwIphqR6lJ3DXa0gOvPDM4rFkknBxUsQQcY7P2Zp27pPKOy4N6sSn7P6f8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771927966; c=relaxed/simple; bh=FCMRXZR8SAuy+rR/oG39tLfH/1KCNmdkdQtzyJsu8Vw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JSCIrDXmXL4iuDpdP0MYXF7CvXXSHrT65lGHiv+ksb6Q197V9AgD98NXrgGQqshjiG/DCuNbb3MlFYzVYCfjH1JkCJVDmgmaMCDpySXuBUkugDaze23qcWUMuD9JFHVATlrBhOfltJalAzqIZe8X36oU95kagy6lZmrrxysjXm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MMsXfLAZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bgzXG40l; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MMsXfLAZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bgzXG40l" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61O9sf0L2727388 for ; Tue, 24 Feb 2026 10:12:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /zUFJH/jB3soteowiXuTedDU0sM6XkQn3T2X92OyF00=; b=MMsXfLAZE5ynACpp FWhZxfOch8YxVJDeYcSsHfthQw5oo/DhMEoqBTJwY99Pk8tMduRE+meYw5fTfkgo 2w+Giycozlkcg1CeqPpjcBSqsNUlGHK4z/5as6cG3Z4CRgPKJ4KKK4h1Hs7qnRs9 W+w358ncbTbBZnmstNNc7CzuqJ5i/jwrhgOEBwstJ0VETln0wmTIOEFY2N9+0CH4 PvGUNYt12JFPTyIJKGVCR2tHeO3spDyFNDULWJNH/dQwl5cT44LMWpwCCcGqPTq0 rfx9UFwvIB0MXJ04okXrCc4LEzvvNue20bY02TjRHE8lrszsfM2/eUvmhZVLJUvL trqH1Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgr69k9tj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 10:12:44 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-894a207e7cdso49307576d6.1 for ; Tue, 24 Feb 2026 02:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771927964; x=1772532764; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/zUFJH/jB3soteowiXuTedDU0sM6XkQn3T2X92OyF00=; b=bgzXG40lX6xeziXyfMHgZdN46GtdVH9ZN5Mg5PVZqS73VWneANFw5/Wa7JXOEhpeYP Gmz1XZ+omAC5IRqv51shOD782oRS/BPUxu2BCUq7unUO3/X6v//P7Vl9jQTyjh5UB4wY yrsxET4W3uIjqR2MUp3XW3C0igeD8BNie1kq1UigJZqfFRaiGoKS/oJcfveK7iVxEgZk ZQyiTgdNf85wMnf+rXpt6RbXA7kkdNSWswCNTvtxEl4ITF7tRucINBe07uCbma0BgAaf Uj7010GUBRTTQ2O/P1+5vqyw4M0oVN5eJuB2V4BTFyaMFRhVQm7HkwbgE+TqInPc1RuT uZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771927964; x=1772532764; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/zUFJH/jB3soteowiXuTedDU0sM6XkQn3T2X92OyF00=; b=Zss+naEDxv3kIoAcq+8k+4Pv2VkwmCLiYWbGEZRzBmFEA/fYqk9lsR25MnRqFq7IBI InylNCaDoMq8giwkIId33apf13eX9sXoFixX9Qul3Dom7jeFZ0SZhaLElaUQtqIv5gFh Dl4b9PEJ6h4OgfkfvgeFlhohk9BlL1aaWE23kmRj+V4B11dWw/7UT4pt5u9Uv1jIb38W VpfxBYh/fOkI8V+sD+LP+pKXu2lKoxlZ5BVFIbA7yqXSgb5GCEG3eisBopiTgx6E6Ec2 ywTtOX/lk4OmAcWpS9kiLq/+yX/IiH/KSpspTUuMS98WyeLjTFrH85oiOuIcb6XZ6g6K X53A== X-Forwarded-Encrypted: i=1; AJvYcCWgcR0FLMhqytbjbmAZqy4yA2YQBp7VEW2EuTJj7vDBVl7B4etrlU40lF0AYrImAZC9kEb5eWW1cWeBlAM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7/wEsuMg8KqmbLOifdIp8XYL4scQZrepxJTfkiLfVlrgrNeeR kzX+omvpdqxEpxI0OhWj7PAGqkizRI2byQJL9RT8mbcJZNM7Cr5uX20Mz+VyAN6j1qbu+2220EF zG4fQt34eE0BQNT+4+JmOjUZOrbiU5YhCj1qhch1j05CFf050f1hbgcC8z2osF9BMsqY= X-Gm-Gg: ATEYQzxyuonCJoFYrt/U5RetVFOhG96BqzU04BkF4gJwnIwYPHCptzGqT9Mya8lB3Ro LZvoPXaUoj8+lNLQdPSkrLQbSTca5nwCy/e+Uwm0dPdumxhkBdPhObREolcNPQNrvSAkG/fkKz/ w1XwsOQDEk6nFZOXgLRifIJHn+lwXA5VlU7rklqPeqwI8EZnwfoH9Cy1KtwmuwqSlIj7lVk9J/7 V17uX6BEKWWvtb2oAeBNnCPkDMuhNnUmBwgu9kS8VnNLQ38ClgOEPXcWSf/HLL59YIz66Qlhn+f fVP7bRbWZx6cdtWAIH+aHtSUevF+oUG9KbIWRcXiI4qX2Ku4qBXLxOkkWKUtMhCyyfqJcu7PFst pf7b3JysUHDfQyywzQ9xK8R4a06EIwnRU/HXyI0epPZtepPTWVExD6eJLmojoNNXt+F0nnmA9Hv iYovA= X-Received: by 2002:a05:6214:8095:b0:895:4919:f536 with SMTP id 6a1803df08f44-89979dbc49bmr120768196d6.3.1771927963625; Tue, 24 Feb 2026 02:12:43 -0800 (PST) X-Received: by 2002:a05:6214:8095:b0:895:4919:f536 with SMTP id 6a1803df08f44-89979dbc49bmr120767896d6.3.1771927963147; Tue, 24 Feb 2026 02:12:43 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084e4be53sm411811166b.31.2026.02.24.02.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 02:12:42 -0800 (PST) Message-ID: Date: Tue, 24 Feb 2026 11:12:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/14] ASoC: qcom: qdapm-lpass-dai: correct the error message To: Srinivas Kandagatla , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-12-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260223180740.444311-12-srinivas.kandagatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=O6A0fR9W c=1 sm=1 tr=0 ts=699d799c cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=gJfCF8_cG8V4FlLix1QA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: fBnxreMudQZaAdOuuD4Lmulh2vMzSjZZ X-Proofpoint-GUID: fBnxreMudQZaAdOuuD4Lmulh2vMzSjZZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA4NCBTYWx0ZWRfX/0oMkR2dGAvP vDddDLU+/6dahisKKdLtdI9sE8ujvax71tKBp/4xhnepw0dqXzJ1+rcfZW/nxa/ri6LQGV4h9M7 GVp3kHLW0d3WD7TogHheT1XhjhGlQwyOJqbSBJx7bA0ntOvrW0CWLhU6SbQCA2T1D2FhO/+KSsz C4BNg1aWWYQ7b6oHhdErxi0K0KOtSDJD+WoPbuAhwAti2ZLE2f6Kf5NGCsjt0s29AEgJxJ+97I0 DDdl6ZTQYk4Uh5ybqTBE9+Q9NE3D7to4RCobafW24uJnLJkNXN1o+cWwj+o9K5yGe6GkMyo94s6 jGjUOHHbEZT47U3mWCUYIpf7ibU3h/81AOMmyAwfV+anaqHQzAyKSgM+pmNkW+8gd011M3hEcQu Fzar/kCb7RvWPyr4wwVGhWWZNaFZcjUBzo5F4tXMQ3PCiXRm5BHxGOOe0I38CBVE3md8GguS5bv 453IB8X7XNX44CY56/A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240084 On 2/23/26 7:07 PM, Srinivas Kandagatla wrote: > Fix the error message to reflect the actual graph stop error > instead of graph close error. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c > index f68d4b4974f3..fc246485e326 100644 > --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c > +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c > @@ -150,7 +150,7 @@ static void q6apm_lpass_dai_shutdown(struct snd_pcm_substream *substream, struct > rc = q6apm_graph_stop(dai_data->graph[dai->id]); > dai_data->is_port_started[dai->id] = false; > if (rc < 0) > - dev_err(dai->dev, "fail to close APM port (%d)\n", rc); > + dev_err(dai->dev, "fail to stop APM port (%d)\n", rc); Might also make it "failed" while at it? Konrad