From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB41B3A1686 for ; Thu, 16 Jul 2026 09:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194601; cv=none; b=D6vtUkfnEXGHwmJ77IeALjjKt8Nfk/XAvWliyrjErX61X5TzIzYnYQ1MasHDYXFdn1mDdY8gEW1kMY2utMZyb5qWgh9BzQRim2HIsJ6M2dw/dXN5KHql51gLKqflBzmY6L6miql4LOPQp8Ag4y8l7j8w+2QSyiX99kKBmQKYmP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784194601; c=relaxed/simple; bh=m+4b3aLkvYKYXjk/5jBk13X1toi/h2jJT0j9yCVHa34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MYhLIMJF0FGuwkS85kwjy5fV6wZj7SJnvbnNaLey4/ZQWCelUmS112mEawL0qFAVCYCeJbekD32kX2XTx9RbRujtqGuUTw7vjyHgEN6l5erHrUzCL2QTbr+LnhHPvj7UTjQ8unH+8dJ2sqN4B2MABZfcpHXVvfE6OaGo9jU24o0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ImarmEFv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y+g+lcFu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ImarmEFv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y+g+lcFu" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G7DkwG1734165 for ; Thu, 16 Jul 2026 09:36:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iQneF3Snhi2o+9zW2iPm4mlK7O1KLd3pE5NOe2Pedfg=; b=ImarmEFvRplhQtnn 96EQn0rHWlVLm/2BIio7tnfNugFZSYwdkNTl0hgpbjgS1HGNliGGk7VXOU/Dc7UK C1IGWEIs23ZXlEG9sK40DMsu1sC5Kp1bjcyNggvOiGYmR6CoBCc9oGpJXQKJbZUK yakevVvt5ztCkKKZJcEg0jCJsUCzpYnXQpjdXbpNautrp0V4xjK3teVliJkPSH7o WywlIOVcVrvV5qaMWtRh/Tmsm/73wHnsDxv7EWbWJQ5VfNs/4bK5ktEVWUFaJrO/ 66CkOD7sDDY1JSlyiRCIS0G0hHRwjlKlhTbe05UmaB+p1RkMvkZQac4V6NZv3MBk GjGEvg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fed063nh8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 09:36:39 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c21be5bb4so20415341cf.0 for ; Thu, 16 Jul 2026 02:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784194598; x=1784799398; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iQneF3Snhi2o+9zW2iPm4mlK7O1KLd3pE5NOe2Pedfg=; b=Y+g+lcFuCuW8WY/8qVtVpBZ0s1Ed53WUxsFjh+D1inETbgXkS/9p2WKZmMkvLlGvsT tX9p797VnRoAFbcnjIA9NCekDYz+RBta5ZOLSJa3aKyoBEKjcd4b8XDBxzVpw+Tk7xTs +t4rZZA3t/aKDOUEawUAl7+xIRIVv1Nq7X0DWlY2Jq4/yAKbwCp9dABV2VUFSagG6VdC OkrazWvLmYIcQ27AetY7LA8tIo+CDiXkydPY5OkyIN5iGrCAmDgqcOK6m8Bq1thGhNGU j5bGCkk1xveslA0zfh+3j14D2l3Mu96HQml2Hh9p+ONpN1y0g2SscVKO3ul4UDFs4NZ/ o1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784194598; x=1784799398; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iQneF3Snhi2o+9zW2iPm4mlK7O1KLd3pE5NOe2Pedfg=; b=NO6lKsv8Bv5ifyOo276eHt3u+uFLh1mDNZmhJ2iinyGtCKKLSwlhG+f6SRyeBt5PjC 6cGVzHuCNbsilS51uqleta1D1Z42IKb6R1PbEHYdNtDiLAN9+KDgNUXkudHrYB7pSbrD vXVlWENtc3Jkx/qloDRtK+mLRkmHfvF6IpCmVrwhSelYp9J0k1HtZ5hcUaTJw7DOXO9S vdXMYs3i/exQ51zK4FlkIHXZx0F+3qPwfUr5K3w/Vm7+J4KLMJk42iho54roIjh6QsPw UVuWfKzSI2V8r2q8YIOX6D9iE0LGVcxhMwage+rJu9d5EOfxv5iQ+73Axoo4zYT9OC0t rTfg== X-Forwarded-Encrypted: i=1; AHgh+RrWmVlkL0ju9xJ36FHdMcEp27Na9vK8ZdiF1DdL+1pU+7QLCVNe1EbKyO9VPCMuP8a4uQIpP32c8eaULtc=@vger.kernel.org X-Gm-Message-State: AOJu0YwiopW2BEeqlY7NR90wQ4EGMdQnqwjY8/sT2GOmamb6RdZZPVbP ABWbxlRy0ISywkNAbdWpjGOXvKb//2YHiIoswQBrAXn+N9x1pWUDjmfchOLhX3PpXWGHw5ND8x5 aciEOzYDohR4ihg6EEz6h3tb8iWI/BlGmxfRGkpAM3yJuQP9Q/mrgLO2x8utM1soKKCc= X-Gm-Gg: AfdE7ckNL8SdB9924QBHcp0B320d56AAsjpHv0dg/A2A3L0teDZyzk8Akm7OL4exKEW /g4o0oyMI3LkDkIWPnbeTtTdKewvgQNQOAYLGFpQXbG8hiIdCQPzqDzCWSATR1hD8QtrY8mRR/Q U9k0f9q/d49ObD5kAJJ3bbGaIdyCrbMgaQijk+dBmnEKIubr0vzy9MxKJb5lirCuJ015DUExLgh muGyz7o2TDvybK6INa69INSoykoAqJWJL1uUrOk+l2eLGyTr9XjpNkjLGd/itnFSrTMB4kcDwfX F+9HIddLPWSn7Cg/QL+nn2CdnjgxrUOp57yMfzq7y6l7LdeH++9XGfRWjMiiac4unTowqEZ7XZs UVdgY0/0VFu8Whz/AiE+BmYEM X-Received: by 2002:a05:622a:389:b0:51c:83f1:bcd4 with SMTP id d75a77b69052e-51cbed7dccbmr25593711cf.0.1784194598020; Thu, 16 Jul 2026 02:36:38 -0700 (PDT) X-Received: by 2002:a05:622a:389:b0:51c:83f1:bcd4 with SMTP id d75a77b69052e-51cbed7dccbmr25593571cf.0.1784194597674; Thu, 16 Jul 2026 02:36:37 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1687126353sm178908166b.13.2026.07.16.02.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 02:36:36 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 11:36:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: geni-qcom: Fix sticky ret causing wrong return value on invalid proto To: Praveen Talari , Mark Brown , "Rafael J. Wysocki (Intel)" Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Kumar Savaliya , kernel test robot , Dan Carpenter References: <20260716-fix_return_error_code-v1-1-3295003aacd5@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260716-fix_return_error_code-v1-1-3295003aacd5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDA5OCBTYWx0ZWRfX0SR2n3bDd0RI gEU7mExcENpdsToUG934n+nEJUAbwc9BqlucX8k/m4OlonA3VO0Jo0nhvRzm6NmMlHaloxGpVTW LT2uLCMAWBJX1HxMpaN6r49AIYUJQlA= X-Proofpoint-GUID: 3oJeLt4XeI0QcJpZfC1G5MvJtu5JMD4b X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDA5OCBTYWx0ZWRfX1we+zAaIpdJn JuUYS4WGzP1ayb63pJcOSWUqFZV4AFuMK/ALu8eLzR4eNuKr/gG6Nd39K9oeRg+n/CbSSVFUvE1 m7p8DNLfNpp/Po/t8pk95BW3V+FxCQsWj43yXbloFbVOYG90LM0TpEFuqAdYuLTCwl6HMuzQ2DP gVSsBabtNzTj9lmjPJm8nqRjVJnXE3ccvKqA39H7h5hnkFult7w7SWM9XCqynYSmNXtqVPgybgV ZkxoniQgW0PpuVv2gpZZILd26A6JH5UZqOxDmRI2xyreN98JUPHkQ0tbomnvSg0PKrIILpS4Z/g oFprbA5FgMUJH0QVefB0H17Rzg4MzngolmlTtS5YGqK2IS+VnjSjIIcBwR24IPCJ3OoT+DTNe+K E5WdEp/1AWWzEIJWy7UD7vHyWcP2om9+ZWYrKh1IQLQUePI6aYF/cLB6e3W5rG5yeTHSbeTcSgM ai3kK6BPNvIrZBK8YnA== X-Authority-Analysis: v=2.4 cv=Xb25Co55 c=1 sm=1 tr=0 ts=6a58a627 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=hRfWpAjuP3xw3JzzUMgA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: 3oJeLt4XeI0QcJpZfC1G5MvJtu5JMD4b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_03,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160098 On 7/16/26 10:25 AM, Praveen Talari wrote: > spi_geni_init() reuses 'ret' after it has already been set by the > runtime PM acquire check earlier in the function. When an invalid > protocol is later detected, the function returns this stale 'ret' > value instead of a proper error code, so it can end up returning 0 > (or some other non-error value) even though the protocol check > failed. > > Fix this by returning -EINVAL directly on both invalid-proto paths. > > Fixes: d8e9ea989acb ("spi: qcom-geni: Fix missing error check on pm_runtime_get_sync()") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202607122241.qzP3QAXF-lkp@intel.com/ > Signed-off-by: Praveen Talari > --- Reviewed-by: Konrad Dybcio Konrad