mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Liao Yuanhong <liaoyuanhong@vivo.com>,
	"open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [Jfs-discussion] [PATCH] JFS: Remove redundant 0 value initialization
Date: Wed, 17 Sep 2025 13:40:33 -0500	[thread overview]
Message-ID: <c6d3d5d7-3a34-4d19-b404-498ea4714bf5@oracle.com> (raw)
In-Reply-To: <20250819032816.426276-1-liaoyuanhong@vivo.com>

Applied.

Thanks,
Shaggy

On 8/18/25 10:28PM, Liao Yuanhong via Jfs-discussion wrote:
> The jfs_log struct is already zeroed by kzalloc(). It's redundant to
> initialize dummy_log->base to 0.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>   fs/jfs/jfs_logmgr.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 270808b6219b..b343c5ea1159 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1199,7 +1199,6 @@ static int open_dummy_log(struct super_block *sb)
>   		init_waitqueue_head(&dummy_log->syncwait);
>   		dummy_log->no_integrity = 1;
>   		/* Make up some stuff */
> -		dummy_log->base = 0;
>   		dummy_log->size = 1024;
>   		rc = lmLogInit(dummy_log);
>   		if (rc) {


      parent reply	other threads:[~2025-09-17 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19  3:28 Liao Yuanhong
2025-08-19  9:16 ` Markus Elfring
2025-09-17 18:40 ` Dave Kleikamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6d3d5d7-3a34-4d19-b404-498ea4714bf5@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=liaoyuanhong@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®