mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Jules Irenge <jbi.octave@gmail.com>,
	devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary
Date: Mon, 21 Oct 2019 01:54:14 -0700	[thread overview]
Message-ID: <c6d923e10359746095d820ef19bd82cacc523b79.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1910210850080.2959@hadrien>

On Mon, 2019-10-21 at 08:52 +0200, Julia Lawall wrote:
> > btw2:
> > 
> > I really dislike all the code inconsistencies and
> > unnecessary code duplication with miscellaneous changes
> > in the rtl staging drivers....
> > 
> > Horrid stuff.
> 
> I'm not sure what you mean by "miscellaneous changes".  Do you mean that
> all issues should be fixed for one file before moving on to another one?
> 
> Or that there are code clones, and all of the clones should be updated at
> the same time?

Neither really.

But realtek drivers are basically code clones where
realtek should prefer to have a single library used
for multiple drivers.

And staging is basically a dumping ground for realtek
wireless drivers.

https://lkml.org/lkml/2019/5/15/1405



  reply	other threads:[~2019-10-21  8:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 14:07 [PATCH v1 0/5] staging: wfx: fix checkpatch warnings Jules Irenge
2019-10-19 14:07 ` [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary Jules Irenge
2019-10-19 14:24   ` Dan Carpenter
2019-10-19 15:09     ` Jules Irenge
2019-10-19 15:17       ` [Outreachy kernel] " Julia Lawall
2019-10-19 18:05       ` Dan Carpenter
2019-10-19 20:02         ` Joe Perches
2019-10-20 19:17           ` Dan Carpenter
2019-10-20 19:29             ` [Outreachy kernel] " Julia Lawall
2019-10-20 19:36             ` Joe Perches
2019-10-20 19:48               ` [Outreachy kernel] " Julia Lawall
2019-10-20 19:52               ` Julia Lawall
2019-10-20 20:16                 ` Joe Perches
2019-10-20 20:29                   ` Julia Lawall
2019-10-21  6:52               ` Julia Lawall
2019-10-21  8:54                 ` Joe Perches [this message]
2019-10-22  8:57               ` Dan Carpenter
2019-10-21  8:21     ` Jerome Pouiller
2019-10-19 14:07 ` [PATCH v1 2/5] staging: wfx: fix warning of line over 80 characters Jules Irenge
2019-10-19 14:07 ` [PATCH v1 3/5] staging: wfx: fix warnings of logical continuation Jules Irenge
2019-10-19 14:07 ` [PATCH v1 4/5] staging: wfx: correct misspelled words Jules Irenge
2019-10-19 14:07 ` [PATCH v1 5/5] staging: wfx: fix warnings of alignment should match open parenthesis Jules Irenge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6d923e10359746095d820ef19bd82cacc523b79.camel@perches.com \
    --to=joe@perches.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®