From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A68254D09EA for ; Mon, 19 Oct 2026 10:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792405453; cv=none; b=rDxcw8ma4vPUcWdCCe1iMagW6zvwaE3cNKXmlOGPT6mxS8Dk4b60q9DlaV/ouCPfWecc7GUE8s05QoLkkiKtN0Nq8F4Xm0q1cRDkr1EVKQf/SFPH2LxsoK1Tgq/ien7e7El87mXwM1/AXgzuOl9I2IoNMFyb5lIGvhlo4UA/0+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792405453; c=relaxed/simple; bh=hwq6n3lMri6f0tS9cV1XHP1OuBW9AhFJjSclegmlXgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=srjJJncJEfVNCiVcEeKO1SAfuleQtnQzZCNjuFSGGaqBfck1XbqyWeMhj7UVxTo6rHhd4c0V4H/qbkkYLxt9+Fucar9rUwlNePK3+an972l1OyRtUgCWzPFzAseqpf8/u9zfeHWIEWvnfz33H8E0A4nJCKc2X39VnHjEwvP6qNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uR5KCq9G; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uR5KCq9G" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so24089375e9.0 for ; Mon, 19 Oct 2026 03:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1792405450; x=1793010250; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZQPRCU8mulrVTcYx+mtCokl0uJBA6jXozBw1EvQlJfk=; b=uR5KCq9G1RH2lqdq1UlEEcHMbz43vLpROotfjGGvjHIDuEgPeKnq9RwDQkivZgKNDC Sq8X4Dn0cwH/Fzh6/IyF7NW1gFENktFgycejmzj9AtTaJvnIjTq99B4cAaQS8FOClx2j 5+X7V0t6CZUfaKMZhkVIc1heItesw9YQrMEOJIBjF3OvJKDBnQliRsZIYFyGKZhK/JPz YYBgX8rwsRXcwPek+NvYVQ7CL6mddfqKlEC+EBwZM//qlagqzpHlBqs8cMyd5JTzhgR2 5vFHodufphnwbuzChUTSKU6jrJ3dBAwiRKZr/oogHRYoVcQpY1pPNfJ+3t5rhvJW2UTg Skjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792405450; x=1793010250; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZQPRCU8mulrVTcYx+mtCokl0uJBA6jXozBw1EvQlJfk=; b=gExqV8revpHLk813mj4qRB9tXbKxej3VrZKlVU7NwyHNsBLUd2BYZdkIgoA3/4ASFv kLNREWMOb8eT7mqgRhlx2IA+9Us/kveQngzanqMhmsyrkEfKhDrjvFmPF4Tw2p4bIB4t rvizt1TR/VuPy5IIYeKjhk4MQihTdgBrYoguS5/9bZVytKI9nZNudRdskZsGB/UdCWPw LmD/o7lTDW/ZR73kii6YKgIpkb6M+teJoiMIuiAYNERmkmAGPyT/3lz3GX8fu255M9MI Emrdloy0NfrXPX176n+8iQoZ5elZmUzS3FUe+T8pi9Jm1rhLS0DDnEpv8CoF/LUBJB+P 5GsA== X-Forwarded-Encrypted: i=1; AKwUvBwrxkBgCxbKTTF9EgSfJcyDuGRB4jDuCYQP+DwyMnUYApJMlVK9u9K+X6EG71D2tZf01bgvRMzkaxYQjLY=@vger.kernel.org X-Gm-Message-State: AFq9FYJ7x9+6lEeI6yBlWK9U/vMPrIkSAW6aOsm+hXcEhyu55/X5Qn2X NPF9DG2AuZK4OFbe6yiYP5qCIrd693MV2XssNHpKKJYDcEiqXNC+7jq6mwyJy9dwGO4= X-Gm-Gg: AYBFou2ngmdyHlAJZQhk846b2uWM3sB4fBsV7ws8d7MBQSY3VSwG1GoQIrD/zSnkWEN PKBdL5Eu7zlh8/XU+rTn7iG7b3ROCeqhZx+2LUWZjBeMpg7Amv7gc7QN5ZiufDQqZyPTKj2XlDk bXGDc3a4CxvO42bGy45JbDIPTyazbD0HfKTcek9y07mLJ/Y5P/7YTzL5asI6eGCoBhAD5kPvgN+ p8qL0fkiMQnCZbInz/q4x1Ohw7NG1u2E1vSnV0ACvfcNsXy72keR9Rg3ETjt7az06sSUB9lJUX+ ISmFcNOpngPEAqw62oj0jla+Gwe+Ywja1tHKY/ywkA2TzQsmyY0Zsbn6sVDb5pcQQnDSpYvKZa4 hKr/TecPB3IyWz3jbdInIN4p7q1gLgf05Hq9irH7bOU3844s68AUtu8KCh16p7QCztw/ppS3ASY +ibXYnwgXmMX21ggHhzUo7rDYaemiEwo0o/t1Ura7B4dhQWNXSD8SAKwVLW2Da+fDb6fUZuHlbf yhlhGwqXSmWMGPsM5YbGg== X-Received: by 2002:a05:600c:4e50:b0:4a1:76c9:5408 with SMTP id 5b1f17b1804b1-4a1d7600190mr157794965e9.11.1792405449821; Mon, 19 Oct 2026 03:24:09 -0700 (PDT) Received: from [192.168.0.167] ([109.76.252.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1e3ebb3aasm187781085e9.0.2026.10.19.03.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 03:24:09 -0700 (PDT) Message-ID: Date: Mon, 19 Oct 2026 11:24:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] phy: core: add generic MIPI C-PHY configuration API To: Anusha Arun Nandi , david@ixit.cz, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, bod@kernel.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gjorgji.rosikopulos@oss.qualcomm.com, jigarkumar.zala@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, linux-media@vger.kernel.org, krzysztof.kozlowski@oss.qualcomm.com, daniel@quora.org, konrad.dybcio@oss.qualcomm.com, christopher.obbard@linaro.org, alex.vinarskis@gmail.com References: <20261017041733.3946816-1-anusha.nandi@oss.qualcomm.com> <20261017041733.3946816-2-anusha.nandi@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/10/2026 00:00, Bryan O'Donoghue wrote: >> +    unsigned int        lanes; > > This statement and how you go about using the data aren't consistent. Re-reading this. unsigned int trios; would be fine too => data_lanes and lane_polarities is a multiple of trios - always three - does it imply that the first three entries in data-lanes == the first trio ? Presumably. That would work too. data-lanes = <4 5 6 1 2 3>; => trios = 2 => data_lanes[4, 5, 6, 1, 2, 3]; trio[0]:lanes == [4, 5, 6]; trio[1]:lanes == [1, 2, 3]; Probably "trios" instead of "lanes" makes more sense here and the driver just always validates that count(data_lanes) % 3 is always false. --- bod