From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14FA435A393 for ; Mon, 29 Jun 2026 10:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729046; cv=none; b=SdV3SYmx3D1IiBtwSVjXWo2l1hfgt7+WLEjPembCR9gFrffGavsP2G8N4hmVu/VxQoUjYgqPtGUKT9t9VdDmM4moFrV/YEwBRnFtbgx7EG1acHAvVLT37bWd/9E3TKQGWcZ07q4dtArCl5w8aXOUUiEqeR8wli8+S3jWxv6/gf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782729046; c=relaxed/simple; bh=yUpVDpfstUTvBShEWh452166LLBk3hB0rm6F58PzqDw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XmZaNznxOmkNutVYXfrWdJ3Fo5Z996z9m8POdyB/zsPZQntyIAjJQ9ynzg95ax1SzKd9Ylj97SqXsI0Mmn93qAZVEU/oCDMJ1ZvWTOL4SD/fad7LPPGrL5JInKYuxZ6EnY8xCMyRe8AjF2YIuZxle6dO47JjI/iHmVf2zGge1js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AjASJJrQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MzKPjC07; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AjASJJrQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MzKPjC07" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATEgw2579076 for ; Mon, 29 Jun 2026 10:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yv3dmN+/b2qLyQGRXAJxgVm9+F8UR7u22dzaZZFmT+0=; b=AjASJJrQfLAXQM+f ZV0sXfYn2I5WKC7JQaI6TjJ9p9mcRhDROQiXBcdi//JioSOmdDaxaDAGUP9hWIIF zpHGwZwz1oVKkiuG6A8sGbdGA+FWkxTwEuqVT2IkgEBHHcYbTXNndYXA0nEL9afP W1IYQtlS9JN9W61NoVE1GzoCi2hNn2wmm6NrmjFLXL7AFYeku8kN2xc9OQNRnjRA qZPMfZNFgRPbVijRwbtxj6p0qKxyW3rPnTApYxEeGfwr5n0qG4UkqvFOev/kyKsC v/1TSnhmYRplztI1FlSmSuh0MjL4ZghnENmfarQNa68f7ZfHL3EBbwIamRoDO6u8 YvfpyA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kp7gwde-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 10:30:44 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bed721a09so1330081cf.0 for ; Mon, 29 Jun 2026 03:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782729043; x=1783333843; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yv3dmN+/b2qLyQGRXAJxgVm9+F8UR7u22dzaZZFmT+0=; b=MzKPjC07LuWH5jXKvipr0vFTt0ytL1O8XZTt9TmzHAeZ6h3WrhL1/6jzYggK+mBIgs noNvqAzsJumKpAIv3ZaAtzZ4Jz/f8sJMRgKl/Ee9eM5DoZQPOfGROEo37MxcZFFezUf/ 5JeygbPPjsPvIqHzQGZOAMeZdAf5A424aIdnzXrQes2siOoCMscMRBox6bDqIXC/431+ NCc8K0sN/wf40kUCurryYifpzT4VPQH+nLwFfrsMFJjSs6fq/7QeFy/8xg/1Pu2Wh5zX Zd2As5lM+v/T8sB+7Gqyxb/Q68YimYGWGGFBL58AUzoDqBJBJHVxaCDVdmk9xz6YvNzA UQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782729043; x=1783333843; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yv3dmN+/b2qLyQGRXAJxgVm9+F8UR7u22dzaZZFmT+0=; b=H/Tnzj2eym1EqOE8vhexYVh+BpWyvF9VtnUEhyQaYsBwZKIkv2Zs3AO7hy0JzprJbv dR6EYIUneKn9BPbUlDwuwsVFEIOdJhKBM6UfcJs7I9RG6IQHvMDkKpANxxwgvKOv7eOJ wRCxG6MDJ4pqiQBmfDXthFCIrxqiHjX8JIOiFUSpsbzfGBulp2ahMpquWDXwhnWcijgJ EsJ7l+tNlQaPt/XVWwMWVtFBS9zWISj0AXlvpV0Vqks7lnbmoHjdFfg8yTdsJNG18+Qv b/VH8Y6quhZuXHEccgatLaxNRbKeoSJvKU0y2R3EPyH5QcyM8CJxpMClbOHzJcOqVPPG XUBw== X-Forwarded-Encrypted: i=1; AFNElJ+I+wCpt5+8kDCILPyiugA9nZMG4NJ2OELmD/60MxZETZIxoX/nQYx1SIvWbN/pi++VaFFf3x0EaWklJ7s=@vger.kernel.org X-Gm-Message-State: AOJu0YyIIDw1At9jNfgT5oWs6EuUJBVHvpmkPkpdmy2z5MaYym975gVT vodM9AB30E1uoB1K9kFg00mXixjXO0x7zJtDeL9jHY6QXq1oda9ZuaeiGmUE6TYygXKrSQHQwTU S1cU0CtVOBQbnmPK2jiUNrlgCtfQp7KNXZtjfUnFg/dEMU3MkBCbUpbpT/WyEAxJfpOs= X-Gm-Gg: AfdE7cleOumqvsP2IB0eG5EKOdhpl0akSZb06RodtgI+I9I8+MwuS8xpFHK0omzrsCI gbm/+aF3FxqiWxxGVG7Tra74+gnKNZInLVZbPt6pzc/NCfDeRwODxUy97rBwEYyS9rNj8V/tQ9Q ExzmHWP9VOTeOtDVqP7JYyLtF9VE7D3ydMtfjTqeHqC94OhnVLYuEfxxTcC2e8t2bGCmk07tm2u kQlExsgYn6wqx4rE16TbZWTB+Oox0qjbYeW+5fTDXAKsdpHyQdOVJC2eIk4+PnC6qlTE1cdRQy/ PAlgEh9n36Rav2KD/JTwP/QQxyFX6xSZSzuAUgt/uWyVZTsNCFkYR+iDL4PcflB+KOv1Xsww98i HHOEiG5hfhPijmFAvXuBPtCmHPy7TUd4Ib4c= X-Received: by 2002:ac8:5f0b:0:b0:51a:8fd2:8ed2 with SMTP id d75a77b69052e-51a8fd2910fmr82101651cf.7.1782729042709; Mon, 29 Jun 2026 03:30:42 -0700 (PDT) X-Received: by 2002:ac8:5f0b:0:b0:51a:8fd2:8ed2 with SMTP id d75a77b69052e-51a8fd2910fmr82101141cf.7.1782729041983; Mon, 29 Jun 2026 03:30:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c122db5dba3sm481538266b.22.2026.06.29.03.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 03:30:41 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 12:30:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/8] clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-5-c939c22ded0c@oss.qualcomm.com> <5f32d4c2-f90d-4f66-96b1-c9c7987ac18e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfX9BYeX4qKiO1Q fx+chTMdofrqVcX2dcl5WxW/haOs1ArJMM060hNICgesNomlp5C/p/B4tMh04aFtalOG2yB+v7G ZrTdgDAuSyKLaQsDtCoS+Sdyokd1pbs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA4NSBTYWx0ZWRfX1NXJkeTimHqt PBfzji7JQwRvElBovNBveXEZU+ErlEN9a0xtpKbBUqECn+h8EGbYTXIdkgrYoy9T1m1VlejbhNA a/FywffFcBZ19t0Rxk/1FElkSeJW4EDLHxwWRibgMqziLDcnsdSoqBkU/e1/2EQTmX78uqa1nOh vQZ+nBhQI6UEmNQJ6uR9ZXeT1RxBYCziqIHwHSEsQejA+XzIF6CNrE9RFtffrWCesTwIpwe/uFp 2H3VklqyLTkcdJt8Ys8aKQUxYRspcgGAo+kqj09FP5otOb06Xx6hb/dzJJiS09Mv9/kdpivr4US ExYdLDChxcnV4xkFv47fxXMG3Qf2cniF2Cs3BVYI6H2NsqHKUm3udJJD4Fsp+q+12AcRbOxkYEP 9sR1xNiZoOxszggge88JslnCjHZM7csKsrAIlbZtMIFNi4qti0i4KcDvP4Pub8KGjqODPDMZOJ4 jqCtHKCfGaSqvW6dEag== X-Proofpoint-ORIG-GUID: S8MkSmywPseMc84jgaJbFbw6q0TChO6P X-Authority-Analysis: v=2.4 cv=MZJcfZ/f c=1 sm=1 tr=0 ts=6a424954 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=nIBEM5H7OJN-vwckHmUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: S8MkSmywPseMc84jgaJbFbw6q0TChO6P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290085 On 6/26/26 5:53 AM, Qiang Yu wrote: > On Mon, Jun 22, 2026 at 03:03:39PM +0200, Konrad Dybcio wrote: >> On 6/22/26 2:49 PM, Qiang Yu wrote: >>> On Mon, Jun 22, 2026 at 01:35:45PM +0200, Konrad Dybcio wrote: >>>> On 6/22/26 7:11 AM, Qiang Yu wrote: >>>>> Mahua is based on Glymur but uses a different QREF topology, requiring >>>>> distinct regulator lists and clock descriptors for its PCIe clock >>>>> references. >>>>> >>>>> Add mahua-specific regulator arrays and clk descriptor table, and use >>>>> match_data to select the correct descriptor table per compatible string at >>>>> probe time. >>>>> >>>>> Signed-off-by: Qiang Yu >>>>> --- >> >> [...] >> >>>> You're also missing PCIe_1_CLKREF_EN (+0x48) (for PCIe5) >>>> which goes through CXO1_>TX->RPT0->RPT1->RPT2->RX2 >>> >>> I have removed PCIe_1_CLKREF_EN in dts node because PCIe5 PHY doesn't >>> require QREF. So I didn't provide its structure here. >> >> I don't quite get what you mean. I see that it is there in the graph > > I double-checked with the HW team — QREF is not required for CXO0. In TCSR > HPG, I think the QREF components you are seeing are in an old version > diagram, but it says the QREF for CXO0 will be removed. In the updated > diagram, PCIe5, USB2_0, USB2_1, USB4_0 and USB4_1 PHYs get refclk directly > from CXO0. > > In theory, we don't need to vote clkref_en and QREF LDOs for these PHY > instances, and I got confirmation from the PCIe HW team for PCIe5 PHY. > > I also compared the description of the TCSR_CLKREF_EN register between > glymur and mahua on ipcatlog. Unfortunately, only > TCSR_USB4_1_CLKREF_EN_USB4_ENABLE is marked as "not in use". I believe > this is because these registers are not documented well in ipcatlog. > > So I think part of the regulator lists you commented for USB instances is > not required, and their dts node also can to be changed to use CXO as > refclk instead of TCSR_CLKREF_EN. But the mapping between the USB instance > names in the QREF diagram and the TCSR_CLKREF_EN registers is not clear — > I cannot find TCSR_USB4_0_CLKREF_EN_USB4_ENABLE, but there is a USB4_0 PHY > in the diagram. Can we leave the USB regulator list as NULL or we just > add them as it is harmless? I believe the internal discussions we had indeed point to the TX/RPT elements having been removed somewhere in the chip dev process, so the regulators can go, in my understanding. As for the refclk toggles themselves, my understanding is that they are still meaningful. Although, we should be able to just smoketest that - set all of these registers to 0 and see if the related IPs still work normally Konrad