From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A075EC28B2B for ; Fri, 19 Aug 2022 07:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347165AbiHSHmp (ORCPT ); Fri, 19 Aug 2022 03:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347144AbiHSHmm (ORCPT ); Fri, 19 Aug 2022 03:42:42 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EFD7CCE3E; Fri, 19 Aug 2022 00:42:37 -0700 (PDT) X-UUID: ac2a3019fb664eaebc80487541f66bf5-20220819 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xRra99ybeDU1VvzdrVMw86yXkS8LgIZdc8GNqbtCaOw=; b=p7ToznoCPDfmE76ARNVQLvU6hK9DWBauDsmYSbnCvzFvOQrCMRx6j5P4XwCwYMFfQjrAWnR2zKmT5aRN4kdPZ28s9XmFd7frgxf/+Qe32+Hx4RpKKK4Ti8rkNflcyecRGHCzu7tr7ntpTQXBHIQxT8D2U0eeOxqMYDSK4q308qw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:6c3d19b9-27de-4aff-a722-8d1ab8afefd8,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_ Ham,ACTION:release,TS:0 X-CID-META: VersionHash:84eae18,CLOUDID:2477219d-da39-4e3b-a854-56c7d2111b46,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: ac2a3019fb664eaebc80487541f66bf5-20220819 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 312840282; Fri, 19 Aug 2022 15:42:31 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 19 Aug 2022 15:42:29 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 19 Aug 2022 15:42:29 +0800 Message-ID: Subject: Re: [PATCH v25 4/4] media: platform: mtk-mdp3: add MediaTek MDP3 driver From: Bo-Chen Chen To: Hans Verkuil , Moudy Ho , Mauro Carvalho Chehab , "Rob Herring" , Matthias Brugger , Krzysztof Kozlowski CC: Chun-Kuang Hu , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , Benjamin Gaignard , AngeloGioacchino Del Regno , , , Ping-Hsun Wu , daoyuan huang Date: Fri, 19 Aug 2022 15:42:29 +0800 In-Reply-To: References: <20220817095629.29911-1-moudy.ho@mediatek.com> <20220817095629.29911-5-moudy.ho@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-08-18 at 13:02 +0200, Hans Verkuil wrote: > Hi Moudy, > > I noticed one more thing (and it is probably better to post a v26 > after all): > > On 17/08/2022 11:56, Moudy Ho wrote: > > This patch adds driver for MediaTek's Media Data Path ver.3 (MDP3). > > It provides the following functions: > > color transform, format conversion, resize, crop, rotate, flip > > and additional image quality enhancement. > > > > The MDP3 driver is mainly used for Google Chromebook products to > > import the new architecture to set the HW settings as shown below: > > User -> V4L2 framework > > -> MDP3 driver -> SCP (setting calculations) > > -> MDP3 driver -> CMDQ (GCE driver) -> HW > > > > Each modules' related operation control is sited in mtk-mdp3-comp.c > > Each modules' register table is defined in file with "mdp_reg_" > > prefix > > GCE related API, operation control sited in mtk-mdp3-cmdq.c > > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c > > Probe, power, suspend/resume, system level functions are defined in > > mtk-mdp3-core.c > > > > v4l2-compliance 1.22.1, 32 bits, 32-bit time_t > > First of all, the v4l2-compliance output belongs to the cover letter, > not > to a commit log for a patch. > > More importantly, I can tell that v4l2-compliance was a prepackaged > version, > but you need to compile it from the git repo yourself: > > git clone git://linuxtv.org/v4l-utils.git > cd v4l-utils > ./bootstrap.sh > ./configure > make > sudo make install > > Running v4l2-compliance should start with this (or something close): > > v4l2-compliance 1.23.0-4941, 64 bits, 64-bit time_t > v4l2-compliance SHA: 71112d214762 2022-07-28 15:31:13 > > I need to see the SHA to confirm that you tested with a sufficiently > new > v4l2-compliance version. Prepackaged v4l2-compliance binaries tend to > be too old, at least for the purpose of compliance checking a new > driver. > > Regards, > > Hans > Hello Hans, Because there are some issues for Moudy's mail account, I help him reply the mail: Thanks for your review and comment, those two errors you mentioned have been corrected accordingly. I will test it with the latest version of v4l2-compliance, and it will be released in v26 together with the testing report. BRs, Bo-Chen > > Compliance test for mtk-mdp3 device /dev/video0: > > Driver Info: > > Driver name : mtk-mdp3 > > Card type : MediaTek MDP3 > > Bus info : platform:14001000.mdp3-rdma0 > > Driver version : 6.0.0 > > Capabilities : 0x84204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > > Device Capabilities > > Device Caps : 0x04204000 > > Video Memory-to-Memory Multiplanar > > Streaming > > Extended Pix Format > >