mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Werner Sembach <wse@tuxedocomputers.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>,
	mario.limonciello@amd.com,
	"Florent DELAHAYE" <kernelorg@undead.fr>,
	Michel-Ekimia <contact@ekimia.fr>,
	"Konrad J Hambrick" <kjhambrick@gmail.com>,
	"Benoit Grégoire" <benoitg@coeus.ca>,
	mumblingdrunkard <mumblingdrunkard@protonmail.com>,
	"Matt Hansen" <2lprbe78@duck.com>,
	"Tilman Vaeth" <tilman-vaeth@web.de>,
	"Christian Homberg" <Christianhomberg@gmail.com>,
	mccricardo <mcc.ricardo@gmail.com>,
	bnewell <bnewell@fullaware.com>,
	"Bernhard Übelacker" <bernhardu@mailbox.org>,
	"Ton Gur" <kvantorrr@mail.ru>, Alessandro <sandro.it@gmail.com>,
	"Pedro Rodrigues" <pedro.pfxr@gmail.com>,
	"Amaury TC" <amaurytc@gmail.com>, crysman <crysman@seznam.cz>,
	Moataz <Moataz.zakaria@gmail.com>, wilk <j.cubizolles@free.fr>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Bradley Morgan" <brads@mainlining.org>,
	"Nikolas Joshua Britton" <nbritton@exabit.io>,
	"Doug Calobrisi" <doug@calobrisi.com>,
	"Helge Deller" <deller@gmx.de>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Alexey Fomenko" <alexey.fomenko@intel.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Maciej Grochowski" <Maciej.Grochowski@sony.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org
Subject: Re: [RFT] Change E820 memory map handling
Date: Tue, 17 Nov 2026 19:44:31 +0100	[thread overview]
Message-ID: <c6e794c9-bb12-43b5-a289-1b191f9f5a41@tuxedocomputers.com> (raw)
In-Reply-To: <20261110-superm1-genoa-mess-v1-0-bdcb3a6f2463@kernel.org>

Hi,

Am 10.11.26 um 19:50 schrieb Mario Limonciello (AMD):
> Commit 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map")
> removes every EFI MMIO descriptor of at least 256KB from E820.  This
> makes host bridge space covered by those descriptors available for PCI
> BAR allocation and avoids maintaining quirks for every affected system.
>
> This helped a number of systems, but caused a regression on AMD Genoa
> which has a hole that is intentionally in this list and shouldn't be
> reassigned.
>
> Ilpo has produced a patch series[1] that changes the policy for reservations
> that may actually help this issue.  To validate whether it works we need
> to test removing the E820 reservation, which has a risk at causing problems
> with systems.
>
> On this RFT I've CCed everyone that I could find a public address for that
> commented on the original issue that lead to commit 07eab0901ede ("efi/x86:
> Remove EfiMemoryMappedIO from E820 map").
>
> I would like to ask that this branch be tested.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/log/?h=superm1/genoa-mess
>
> Here is the flow I would like to see:
>   1. Test 7.4-rc2 (vanilla - no changes please)
>   2. Test this branch (superm1/genoa-mess)
>   3. If this branch fails, please revert this commit from the branch and test again.
>      commit 35c9c60ea8c1c ("Revert "x86/PCI: Add E820 quirks for Clevo NL4XLU and Lenovo Yoga C940"")
>
> In all cases please check whether your original issue exists and comment if it does.
>
> I would like to know BOTH positive and negative testing with this series so we can have an idea
> if this approach is viable.

I noticed that you only removed the quirk from 2 devices: 
https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/commit/?h=superm1/genoa-mess&id=35c9c60ea8c1c05631837f4094a09c51f00bec4b

Do you only want these 2 devices tested or for example also the X170KM-G?

Best regards,

Werner

>
> Link: https://lore.kernel.org/linux-pci/20261106134341.39493-1-ilpo.jarvinen@linux.intel.com/ [1]
> Cc: Florent DELAHAYE <kernelorg@undead.fr> # Clevo NL4XLU
> Cc: Michel-Ekimia <contact@ekimia.fr> # Clevo NL51CU2 (not currently quirked)
> Cc: Konrad J Hambrick <kjhambrick@gmail.com> # Clevo X170KM-G
> Cc: Werner Sembach <wse@tuxedocomputers.com> # Clevo X170KM-G
> Cc: Benoit Grégoire <benoitg@coeus.ca> # Lenovo Yoga C940-14IIL
> Cc: mumblingdrunkard <mumblingdrunkard@protonmail.com> # Lenovo Yoga C940-14IIL
> Cc: Matt Hansen <2lprbe78@duck.com> # Lenovo IdeaPad 3 15IIL05
> Cc: Tilman Vaeth <tilman-vaeth@web.de> # Lenovo IdeaPad 5 14IIL05
> Cc: Christian Homberg <Christianhomberg@gmail.com> # Lenovo IdeaPad 5 14IIL05 (81YH)
> Cc: mccricardo <mcc.ricardo@gmail.com> # Lenovo IdeaPad 5 14IIL05
> Cc: bnewell <bnewell@fullaware.com> # Lenovo IdeaPad Slim 7 14IIL05 (82A4)
> Cc: Bernhard Übelacker <bernhardu@mailbox.org> # Lenovo V15-IIL (82C500JUGE)
> Cc: Ton Gur <kvantorrr@mail.ru> # Lenovo IdeaPad 3 15IIL05
> Cc: Alessandro <sandro.it@gmail.com> # Lenovo IdeaPad 3 (exact model not posted)
> Cc: Pedro Rodrigues <pedro.pfxr@gmail.com> # Lenovo IdeaPad (exact model not posted)
> Cc: Amaury TC <amaurytc@gmail.com> # Lenovo BS145-15IIL (82HB)
> Cc: crysman <crysman@seznam.cz> # Acer Spin 5 SP513-54N
> Cc: Moataz <Moataz.zakaria@gmail.com> # Acer Spin 5 SP513-54N
> Cc: wilk <j.cubizolles@free.fr> # Acer Spin 5 SP513-54N
>
> These are the patches to be tested by checking that branch.
> ---
> Ilpo Järvinen (14):
>        resource: Mark free space assigned
>        parisc/PCI: Clean up resource debug print & use dynamic debug
>        PCI: Don't size or assign disabled BARs
>        PCI: Use __ffs64() for resource_size_t typed align
>        PCI: Prevent zero align from reaching __ffs64()
>        linux/log2.h: Add 64-bit roundup/down_pow_of_two_u64() variants
>        PCI: Derive aligns[] array size in a define
>        PCI: Honor alignment overrides
>        PCI: Place resources to either edge of the window
>        PCI: Separate align/raw size calculation from pbus_size_mem()
>        PCI: Calculate bridge window with optional sizes from scratch
>        PCI: Move size/align calculation fully into __pbus_size_mem()
>        PCI: Fix composite resource sizing
>        PCI: Add debug printing to window sizing
>
> Mario Limonciello (3):
>        x86/PCI: Add E820 quirks for Clevo NL4XLU and Lenovo Yoga C940
>        Revert "efi/x86: Remove EfiMemoryMappedIO from E820 map"
>        Revert "x86/PCI: Add E820 quirks for Clevo NL4XLU and Lenovo Yoga C940"
>
>   arch/alpha/kernel/pci.c          |   3 +-
>   arch/arm/kernel/bios32.c         |   5 +-
>   arch/m68k/kernel/pcibios.c       |   4 +-
>   arch/mips/pci/pci-generic.c      |   5 +-
>   arch/mips/pci/pci-legacy.c       |   5 +-
>   arch/parisc/kernel/pci.c         |  20 +--
>   arch/powerpc/kernel/pci-common.c |   5 +-
>   arch/sh/drivers/pci/pci.c        |   5 +-
>   arch/x86/pci/i386.c              |   5 +-
>   arch/x86/platform/efi/efi.c      |  45 -------
>   arch/xtensa/kernel/pci.c         |   5 +-
>   drivers/char/agp/intel-gtt.c     |   5 +-
>   drivers/gpu/drm/i915/i915_gmch.c |   5 +-
>   drivers/pci/pci.c                |   4 +-
>   drivers/pci/pci.h                |   6 +
>   drivers/pci/setup-bus.c          | 263 +++++++++++++++++++++++++--------------
>   drivers/pci/setup-res.c          | 246 ++++++++++++++++++++++++++++++++----
>   include/linux/log2.h             |  52 ++++++++
>   include/linux/pci.h              |  15 ++-
>   kernel/resource.c                |   3 +-
>   20 files changed, 510 insertions(+), 196 deletions(-)
> ---
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> change-id: 20261110-superm1-genoa-mess-2195512e39e7
>

      parent reply	other threads:[~2026-11-17 18:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 18:50 Mario Limonciello (AMD)
2026-11-17 14:12 ` Nikolas Joshua Britton
2026-11-17 18:44 ` Werner Sembach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6e794c9-bb12-43b5-a289-1b191f9f5a41@tuxedocomputers.com \
    --to=wse@tuxedocomputers.com \
    --cc=2lprbe78@duck.com \
    --cc=Christianhomberg@gmail.com \
    --cc=Maciej.Grochowski@sony.com \
    --cc=Moataz.zakaria@gmail.com \
    --cc=alexey.fomenko@intel.com \
    --cc=amaurytc@gmail.com \
    --cc=benoitg@coeus.ca \
    --cc=bernhardu@mailbox.org \
    --cc=bnewell@fullaware.com \
    --cc=brads@mainlining.org \
    --cc=contact@ekimia.fr \
    --cc=crysman@seznam.cz \
    --cc=deller@gmx.de \
    --cc=doug@calobrisi.com \
    --cc=eric.auger@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=j.cubizolles@free.fr \
    --cc=kernelorg@undead.fr \
    --cc=kjhambrick@gmail.com \
    --cc=kvantorrr@mail.ru \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mcc.ricardo@gmail.com \
    --cc=mumblingdrunkard@protonmail.com \
    --cc=nbritton@exabit.io \
    --cc=pedro.pfxr@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sandro.it@gmail.com \
    --cc=superm1@kernel.org \
    --cc=tilman-vaeth@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®