From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>, "David S. Miller" <davem@davemloft.net>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: correct per TX/RX ring statistics
Date: Thu, 23 Apr 2020 15:46:37 -0700 [thread overview]
Message-ID: <c6e9fbce-247b-d101-2d15-217332bc9459@gmail.com> (raw)
In-Reply-To: <1587681857-19734-1-git-send-email-opendmb@gmail.com>
On 4/23/2020 3:44 PM, Doug Berger wrote:
> The change to track net_device_stats per ring to better support SMP
> missed updating the rx_dropped member.
>
> The ndo_get_stats method is also needed to combine the results for
> ethtool statistics (-S) before filling in the ethtool structure.
>
> Fixes: 37a30b435b92 ("net: bcmgenet: Track per TX/RX rings statistics")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks for catching that!
--
Florian
next prev parent reply other threads:[~2020-04-23 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 22:44 Doug Berger
2020-04-23 22:46 ` Florian Fainelli [this message]
2020-04-23 23:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6e9fbce-247b-d101-2d15-217332bc9459@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®