From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ekansh Gupta <quic_ekangupt@quicinc.com>,
linux-arm-msm@vger.kernel.org, ekangupt@qti.qualcomm.com,
linux-kernel@vger.kernel.org, bkumar@qti.qualcomm.com,
fastrpc.upstream@qti.qualcomm.com, stable <stable@kernel.org>
Subject: Re: [PATCH v1] misc: fastrpc: Reassign memory ownership only for remote heap
Date: Fri, 12 May 2023 13:40:14 +0100 [thread overview]
Message-ID: <c6f903e6-ccf2-701f-cfe3-34abacde278b@linaro.org> (raw)
In-Reply-To: <ZCQOaMcObl0vYqlg@kroah.com>
On 29/03/2023 11:09, Greg KH wrote:
> On Tue, Mar 21, 2023 at 08:53:33PM +0000, Srinivas Kandagatla wrote:
>>
>>
>> On 21/03/2023 10:21, Ekansh Gupta wrote:
>>> The userspace map request for remote heap allocates CMA memory.
>>> The ownership of this memory needs to be reassigned to proper
>>> owners to allow access from the protection domain running on
>>> DSP. This reassigning of ownership is not correct if done for
>>> any other supported flags.
>>>
>>> When any other flag is requested from userspace, fastrpc is
>>> trying to reassign the ownership of memory and this reassignment
>>> is getting skipped for remote heap request which is incorrect.
>>> Add proper flag check to reassign the memory only if remote heap
>>> is requested.
>>>
>>> Fixes: 532ad70c6d44 ("misc: fastrpc: Add mmap request assigning for static PD pool")
>>> Cc: stable <stable@kernel.org>
>>> Tested-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>>> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
>>
>> Thanks for fixing this, without this fix the code inside if condition was a
>> dead code.
>>
>>
>> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Are you going to be collecting these and sending them on? If not,
> please do.
Sorry for long delay,
I will take care of collecting fastrpc patches and send it.
--srini
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-05-12 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 10:21 Ekansh Gupta
2023-03-21 20:53 ` Srinivas Kandagatla
2023-03-29 10:09 ` Greg KH
2023-05-12 12:40 ` Srinivas Kandagatla [this message]
2023-05-12 14:54 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f903e6-ccf2-701f-cfe3-34abacde278b@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=bkumar@qti.qualcomm.com \
--cc=ekangupt@qti.qualcomm.com \
--cc=fastrpc.upstream@qti.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ekangupt@quicinc.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®