From: James Morse <james.morse@arm.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Reinette Chatre <reinette.chatre@intel.com>,
Yury Norov <yury.norov@gmail.com>,
Dave Martin <dave.martin@arm.com>,
fenghuay@nvidia.com, peternewman@google.com,
Babu Moger <Babu.Moger@amd.com>, Borislav Petkov <bp@alien8.de>,
shameerali.kolothum.thodi@huawei.com, bobo.shaobowang@huawei.com,
D Scott Phillips OS <scott@os.amperecomputing.com>,
carl@os.amperecomputing.com, Koba Ko <kobak@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Xin Hao <xhao@linux.alibaba.com>,
baolin.wang@linux.alibaba.com, lcherian@marvell.com,
amitsinght@marvell.com, Ingo Molnar <mingo@redhat.com>,
David Hildenbrand <david@redhat.com>,
H Peter Anvin <hpa@zytor.com>, Rex Nie <rex.nie@jaguarmicro.com>,
Jamie Iles <quic_jiles@quicinc.com>,
dfustini@baylibre.com, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] fs/resctrl: Optimize code in rdt_get_tree()
Date: Fri, 13 Jun 2025 17:57:33 +0100 [thread overview]
Message-ID: <c6f9a69e-0c91-408c-97fe-d17b9f938756@arm.com> (raw)
In-Reply-To: <20250613073733.3642679-2-tan.shaopeng@jp.fujitsu.com>
Hello!
On 13/06/2025 08:37, Shaopeng Tan wrote:
> schemata_list_destroy() has to be called if schemata_list_create() fails.
>
> rdt_get_tree() calls schemata_list_destroy() in two different ways:
> directly if schemata_list_create() itself fails and
> on the exit path via the out_schemata_free goto label.
>
> Remove schemata_list_destroy() call on schemata_list_create() failure.
> Use existing out_schemata_free goto label instead.
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
next prev parent reply other threads:[~2025-06-13 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 7:37 [PATCH] cpumask: Remove unnecessary cpumask_nth_andnot() Shaopeng Tan
2025-06-13 7:37 ` [PATCH] fs/resctrl: Optimize code in rdt_get_tree() Shaopeng Tan
2025-06-13 16:57 ` James Morse [this message]
2025-06-13 18:01 ` Reinette Chatre
2025-06-21 14:40 ` [PATCH] cpumask: Remove unnecessary cpumask_nth_andnot() Yury Norov
2025-06-17 1:06 [PATCH] fs/resctrl: Optimize code in rdt_get_tree() Shaopeng Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f9a69e-0c91-408c-97fe-d17b9f938756@arm.com \
--to=james.morse@arm.com \
--cc=Babu.Moger@amd.com \
--cc=amitsinght@marvell.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=carl@os.amperecomputing.com \
--cc=dave.martin@arm.com \
--cc=david@redhat.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hpa@zytor.com \
--cc=kobak@nvidia.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=rex.nie@jaguarmicro.com \
--cc=scott@os.amperecomputing.com \
--cc=sdonthineni@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tan.shaopeng@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®