From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sboyd@kernel.org>
Cc: <collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
<tglx@linutronix.de>, <maz@kernel.org>,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Subject: Re: [RESEND PATCH v3 01/10] spmi: pmic-arb: handle spurious interrupt
Date: Thu, 2 Dec 2021 20:43:46 +0800 [thread overview]
Message-ID: <c6f9beb7-98ec-4a5a-a887-b8841c982b04@quicinc.com> (raw)
In-Reply-To: <829e2ce0-888a-b859-9e94-4b92d6c10d4a@linaro.org>
On 2021/12/2 10:39, Bryan O'Donoghue wrote:
> On 02/12/2021 00:00, Fenglin Wu wrote:
>> Call handle_bad_irq() for handling spurious interrupt. While at it,
>> add an error print in cleanup_irq() for any spurious interrupt which
>> is fired but not having interrupt handler registered.
>
> Being excruciatingly pedantic, I'd suggest breaking this up into two
> patches, one for the ratelimit one for the logical change to the irq
> handling flow.
>
The original patch actually only prints a message for any interrupt
that's fired but not
registered, and it got reviewed and commented to add logic to handle
spurious interrupt
like this.I might have misunderstood the comments so I combined them
together, I agreed
theyare not very related and I can separate them and send them again.
Thanks.
>> Signed-off-by: Abhijeet Dharmapurikar<adharmap@codeaurora.org>
>> Signed-off-by: David Collins<collinsd@codeaurora.org>
>> Signed-off-by: Fenglin Wu<quic_fenglinw@quicinc.com>
>> ---
>> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index bbbd311..da629cc 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -489,6 +489,8 @@ static void cleanup_irq(struct spmi_pmic_arb
>> *pmic_arb, u16 apid, int id)
>> u8 per = ppid & 0xFF;
>> u8 irq_mask = BIT(id);
>> + dev_err_ratelimited(&pmic_arb->spmic->dev, "%s apid=%d
>> sid=0x%x per=0x%x irq=%d\n",
>> + __func__, apid, sid, per, id);
>> writel_relaxed(irq_mask, pmic_arb->ver_ops->irq_clear(pmic_arb,
>> apid));
>> if (pmic_arb_write_cmd(pmic_arb->spmic, SPMI_CMD_EXT_WRITEL,
>> sid,
>> @@ -502,10 +504,10 @@ static void cleanup_irq(struct spmi_pmic_arb
>> *pmic_arb, u16 apid, int id)
>> irq_mask, ppid);
>> }
>> -static void periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16
>> apid)
>> +static int periph_interrupt(struct spmi_pmic_arb *pmic_arb, u16 apid)
>> {
>> unsigned int irq;
>> - u32 status, id;
>> + u32 status, id, handled = 0;
>
> If handled were an int
>
>> u8 sid = (pmic_arb->apid_data[apid].ppid >> 8) & 0xF;
>> u8 per = pmic_arb->apid_data[apid].ppid & 0xFF;
>> @@ -520,7 +522,10 @@ static void periph_interrupt(struct
>> spmi_pmic_arb *pmic_arb, u16 apid)
>> continue;
>> }
>> generic_handle_irq(irq);
>> + handled++;
>> }
>> +
>> + return (handled) ? 0 : -EINVAL;
>> }
>
> you could "return handled;" and then have
>
> if (periph_interrupt(pmic_arb, apid))
> handled++;
>
> later on
>
> Its not important I suppose but please do at least break this up into
> two separate patches.
>
Got it, will update it. Thanks
> ---
> bod
next prev parent reply other threads:[~2021-12-02 12:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 0:00 [RESEND PATCH v3 00/10] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 01/10] spmi: pmic-arb: handle spurious interrupt Fenglin Wu
2021-12-02 2:39 ` Bryan O'Donoghue
2021-12-02 12:43 ` Fenglin Wu [this message]
2021-12-02 0:00 ` [RESEND PATCH v3 02/10] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq Fenglin Wu
2021-12-02 2:39 ` Bryan O'Donoghue
2021-12-02 12:52 ` Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 03/10] spmi: pmic-arb: check apid against limits before calling irq handler Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 04/10] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 05/10] spmi: pmic-arb: correct duplicate APID to PPID mapping logic Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 06/10] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 07/10] bindings: spmi: spmi-pmic-arb: mark interrupt properties as optional Fenglin Wu
2021-12-10 22:10 ` Rob Herring
2021-12-02 0:00 ` [RESEND PATCH v3 08/10] spmi: pmic-arb: make interrupt support optional Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 09/10] spmi: pmic-arb: increase SPMI transaction timeout delay Fenglin Wu
2021-12-02 0:00 ` [RESEND PATCH v3 10/10] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format Fenglin Wu
2021-12-02 13:58 ` Rob Herring
2021-12-10 2:05 ` Stephen Boyd
2021-12-14 5:50 ` Fenglin Wu
2021-12-10 22:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6f9beb7-98ec-4a5a-a887-b8841c982b04@quicinc.com \
--to=quic_fenglinw@quicinc.com \
--cc=adharmap@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®