From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3981630FC13 for ; Tue, 18 Nov 2025 11:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763466404; cv=none; b=uYxufD+gqSjvDsl6G/dI/RBPyvuMW9ApIrmFSam6EhMmvqPx+2MKHRxKXS1u8Vka0b6Lc+XcFbapJLZvHCx/18VGeHjVJt9t9/6gmqpyzURB9K7BzJQ7eihf3VG7emwZDgSOQsAdCNW7qIZLJWbrjFi/Owr7wvvwefcgJb0dmkI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763466404; c=relaxed/simple; bh=3tdQzlCbe0Y1DhaDg1LZSbowfoTXLvkluyB2GTOUvI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WDmnZX2sBq6CkJveef90Gx5k9WAs5WQme2LSHazRwjy2BJpc3GS66x18mMTi8GVeQpkVflqsppsxlodSrO3rz6yPMIS+qu9mXzHFW4JTs2o2MGAqJkVYqqhkNZLoWtnJQOIsveXZzDbcljizyh4sKn3L3Jzh+P5kpLtmNT/v2+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WH0w9LnT; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ksV9mjgr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WH0w9LnT"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ksV9mjgr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763466401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G50nyUS6RKtYR6MLsNJYK4QZ6bz7S7uMs82ckDdodyw=; b=WH0w9LnT2nFmIyUIE3lYQ7KHRzK75RrITspaM1K3/63hLIylTpnnciyda3Zo9R4U//zerB khF2cE+sWoOKsN5SeNV+X4D2LsP7r9O9AGkL3cBLBoxHg1+UQtI0xnUQ1WFmoR5OvAT0JM BrmtwIwcCSsbA28w6tKs3muZExmPZ/c= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-SpTNa8xfOMuBKmu0MJYyYA-1; Tue, 18 Nov 2025 06:46:40 -0500 X-MC-Unique: SpTNa8xfOMuBKmu0MJYyYA-1 X-Mimecast-MFC-AGG-ID: SpTNa8xfOMuBKmu0MJYyYA_1763466399 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47788165c97so6245815e9.0 for ; Tue, 18 Nov 2025 03:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763466399; x=1764071199; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G50nyUS6RKtYR6MLsNJYK4QZ6bz7S7uMs82ckDdodyw=; b=ksV9mjgro1LBGlPmSzmGo86o4KtL/94/ilVas49hVsX4Ta89qEx+e0ixLhD2/WShDR ckX+bUodj9cfW7TExGhAT3uLlmcZRaUxb+Umwn/5QEjnFJtUdw2WSjfZuI4gj1TedahY zu6bZ65iWmOWPXxMIWbMHu52jzrJ9sbK4WPkNDvI4Mmzf5ymdjpOyvH32NLsr/3rwBLp oX3SYyxAPar5SXz1IpNB9BYfnSDtNwCWpOhfRvBSZpyOnRVL5K0IgE1tS4Qgg5W5dM8V GKMxR0WNmNGEu0YO+xGMx0PB+UzY2XzOa6CeicM1jxea33miCj1l0czXyNsIQHGOhsjM k5Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763466399; x=1764071199; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G50nyUS6RKtYR6MLsNJYK4QZ6bz7S7uMs82ckDdodyw=; b=ViXJQXGRlKmAWh4okPnT9L3uL+NscW7dVJYZCWjMHyRmvgPtp2Cv+aehY2waLJBDxY B27hO8HoiehIP6v9wQkoZSyGfpfx5JrUOhv+Tq+Ve77O46f+w2IDPGwHHFQdUriokEmG 5xXumnsMAPvpxrUGAQftM6weyYxgcX3MtPV+y2U6LnQa1Z0Xw4+j+wNePHYnlaJhCZUu tr/DxG7d1vpRPS77rbaZ/iIFcnWURKdw0jEe3ZlzFoF3jQlbG+NcaarfzzG/90S1JVOj aCS9+sKjqd/x7LV4xD0W2ql4K3381romROpSb8MXhrVYxgYQHjYTgiyDUubiLJDStKIj /46A== X-Forwarded-Encrypted: i=1; AJvYcCU80eL0UidX3GVYZgOHD0XA5Q8/5nSIIxuLAHCKHqLld7URi4gleIQ3KLhhJBhKpHjWRsXMlQ1s6Cnkv80=@vger.kernel.org X-Gm-Message-State: AOJu0YxYXJr36xQUJR1VS0YJjnKkGNYaqrVuiRVZKA3osjxRTOWVwMD8 oiOosLaFXWFKLtXXpr4dZlmHWYA9wc858XM9eWQztt16A2NiaqVkQejf+kugAoyjcmVamZWG3/L qiFuS7pr0NybOpUo1GrJcGuB78SpPNE/V9EwHOnJhukJvokZ27SRikywyvcNF1T+G7w== X-Gm-Gg: ASbGnctnUTafBqWUyJlaXXEoERpkB4bSfGKJyheIpMvO6bjdThz+uj8sg33CtXr+oFf +vfG+B09F3P702yUNytYVAJJy1rMXa3/eJ25uQPybGM0PCb/6bkf0vzY+Gj/Ftu9Gbs1vHf/vhK 19CO2NerqqdPdwuc2rjIdcE1DD4dUIUHQn6+jswHI1a+0BsqUo0NvDE5zP6O/H4/CrsUqriTOGN ZeW6X/mT9HjrWrAsT+NgJnQiYYkjy0811XdoqE4+uryxjEBYshoK9zbjAFAsv1mp0Sx+dXBJjDI pQmmI4qUZpYDptod7q+I8+NW4DYU85vfnBELtVAbfPl8m1n4a006USfBzwdTixznzvayiu/Svr7 q8t+FzdfXxolc X-Received: by 2002:a05:600c:3b12:b0:477:67ca:cdbb with SMTP id 5b1f17b1804b1-4778febd327mr129228305e9.36.1763466398689; Tue, 18 Nov 2025 03:46:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuf9QXTTEdA8gMcfFBDPoA6vL2L3+p/2KXiQoIKGU1o5Q+h8ztlweTgXipAxyEIVY8MRihPg== X-Received: by 2002:a05:600c:3b12:b0:477:67ca:cdbb with SMTP id 5b1f17b1804b1-4778febd327mr129228085e9.36.1763466398265; Tue, 18 Nov 2025 03:46:38 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4779525d2bcsm216280495e9.5.2025.11.18.03.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 03:46:37 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 12:46:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] team: Move team device type change at the end of team_port_add To: "Nikola Z. Ivanov" , jiri@resnulli.us, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzbot+a2a3b519de727b0f7903@syzkaller.appspotmail.com References: <20251112003444.2465-1-zlatistiv@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251112003444.2465-1-zlatistiv@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/12/25 1:34 AM, Nikola Z. Ivanov wrote: > @@ -1233,6 +1231,10 @@ static int team_port_add(struct team *team, struct net_device *port_dev, > } > } > > + err = team_dev_type_check_change(dev, port_dev); > + if (err) > + goto err_set_dev_type; Please don't add unneeded new labels, instead reuse the exiting `err_set_slave_promisc`. Thanks, Paolo