From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbcGDMXi (ORCPT ); Mon, 4 Jul 2016 08:23:38 -0400 Received: from mout02.posteo.de ([185.67.36.66]:60025 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbcGDMXg (ORCPT ); Mon, 4 Jul 2016 08:23:36 -0400 Subject: Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements To: Bijosh Thykkoottathil , "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "christoph.muellner@theobroma-systems.com" References: Cc: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Martin Kepplinger Message-ID: Date: Mon, 4 Jul 2016 14:23:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil: > Removed unwanted return statements from the function > mma8452_set_freefall_mode. You could've said "Don't unnecessarily save a return value.", but whatever :) Thanks for your review! > > Signed-off-by: Bijosh Thykkoottathil Reviewed-by: Martin Kepplinger > --- > drivers/iio/accel/mma8452.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index e225d3c..d4a6d44 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state) > val |= MMA8452_FF_MT_CFG_OAE; > } > > - val = mma8452_change_config(data, chip->ev_cfg, val); > - if (val) > - return val; > - > - return 0; > + return mma8452_change_config(data, chip->ev_cfg, val); > } > > static int mma8452_set_hp_filter_frequency(struct mma8452_data *data, >