From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422693AbcIZQO6 (ORCPT ); Mon, 26 Sep 2016 12:14:58 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:36501 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbcIZQOz (ORCPT ); Mon, 26 Sep 2016 12:14:55 -0400 From: Nikita Yushchenko Subject: Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path References: <20160924183110.s4lxuigycpxegamq@sirena.org.uk> <1474886150-16207-1-git-send-email-nikita.yoush@cogentembedded.com> <20160926160831.e5gd4t4fqhkxgzii@sirena.org.uk> To: linux-kernel@vger.kernel.org Message-ID: Date: Mon, 26 Sep 2016 19:14:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160926160831.e5gd4t4fqhkxgzii@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I doubt that copying 7 lines into error path is better than having a tiny >> logic with return values, but still here it is. > > Consider what happens if someone wants to change the code... I believe that "undo poweron" and "poweroff" sequences still will have to remain the same. This having two copies of code is more error-prone than having one. Nikita