From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970016AbdI0CGv (ORCPT ); Tue, 26 Sep 2017 22:06:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968086AbdI0CGt (ORCPT ); Tue, 26 Sep 2017 22:06:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B722880F90 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jasowang@redhat.com Subject: Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1506067355-5771-1-git-send-email-jasowang@redhat.com> <20170926222528-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Wed, 27 Sep 2017 10:06:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170926222528-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 27 Sep 2017 02:06:49 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年09月27日 03:26, Michael S. Tsirkin wrote: > On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote: >> Hi: >> >> This series tries to implement basic tx batched processing. This is >> done by prefetching descriptor indices and update used ring in a >> batch. This intends to speed up used ring updating and improve the >> cache utilization. Test shows about ~22% improvement in tx pss. > > > >> Please review. >> >> Jason Wang (5): >> vhost: split out ring head fetching logic >> vhost: introduce helper to prefetch desc index >> vhost: introduce vhost_add_used_idx() > Please squash these new APIs into where they are used. > This split-up just makes review harder for me as > I can't figure out how the new APIs are used. Ok. Thanks > > >> vhost_net: rename VHOST_RX_BATCH to VHOST_NET_BATCH > This is ok as a separate patch. > >> vhost_net: basic tx virtqueue batched processing >> >> drivers/vhost/net.c | 221 ++++++++++++++++++++++++++++---------------------- >> drivers/vhost/vhost.c | 165 +++++++++++++++++++++++++++++++------ >> drivers/vhost/vhost.h | 9 ++ >> 3 files changed, 270 insertions(+), 125 deletions(-) >> >> -- >> 2.7.4