From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD153D963 for ; Thu, 11 Apr 2024 21:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712869420; cv=none; b=ioXk3LZ3bX+wH3VQOPKBTUWjA6WTzzll+1mnEL3zmbrL8dB57J1Nke5Xt7u8kiw5K/94NQxZXlo7be/mE6TJMOz0VjwMYrN/KD8WQE4P+nxLjAqLm9LI1q1dRjax5Gf2jSjuuyrRWeq6OoFxLtBXFWK4m/zb/5v+iC6S5J3m5iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712869420; c=relaxed/simple; bh=USS40zQsBMhtx3Ma6IF6kBjkQLS4UZzF4Q8diqd0fBk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gvLndY0b1v1M9NSGETNlA1kKcH+RKIvSxamUSUgaZD6uhbksluS71vGHtuGUQtEzrmtuHnjkDuWZSL6EAxFAJlJE3TBFbhsp+yS3MTRhr8ZLdJ3DcuxoN01tHjdDz+1ywSx9Kzt8JGtsyUh31uuSZehyXYfhEuGra/H/gK+RwYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DccNodpL; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DccNodpL" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7d67d1073easo4780439f.0 for ; Thu, 11 Apr 2024 14:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712869418; x=1713474218; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xKSNhAEAUoGr18OfXzKlJNw9tSZ1pFsX9+MsxZurOGo=; b=DccNodpL1nCZSZFcDj776zauWCm3gS/MmS9z49DddHaoIKA0Gam85vX4B3Bqgb+3i0 UD0CbvB39icRexDOmASqdhPu6gOrd3WDUdaHqt7+EL8kc5ih7a6OhTPLTdtYxooyovmo 2nZaHK39Y/jGe9nLP0r3dsRfUCHIJLkZw/X5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712869418; x=1713474218; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xKSNhAEAUoGr18OfXzKlJNw9tSZ1pFsX9+MsxZurOGo=; b=UUqqCnWZxFYfQmFPSo3Jb00QT3gLd05AEmlnndqdpTOhc+uV9WmDZvD5qlW5jRKBg8 PVMyFY3pbjh0yl6E2yOYtBix2nW+5RCgf2HUuQR+50UxSXHuGS0q7BXAzGosNusU8Khy cqXjV/JiQBJpCtSowipvYZ6Dfm60+pi3t6eqF72AkpF0wLJ5+z69u7So9p1pvkjEm3F2 FnaAwbjv6nEOTYESwMTCg1bbaPIOeYsfF2me992yCAznxoP6/oTHmmqQIORKuWFI6ujO CgX8WXAsHnlF/jFgOoShOqFBx0Phdmk2RQI3LPNEcROKLtjoUWy3WRtHMPNj+x0wiINJ 3htw== X-Gm-Message-State: AOJu0YxeYXIdJ0bHZM2yg72rd2xo4afV5Q7XyM5zAxPOXBAnNcM8BvgG qUwhCzRSugme37PwkmVnJUBles0ASiaXZXsR0xr4Gu+HwlSWirvohsN+my34FXA= X-Google-Smtp-Source: AGHT+IELOp/nPA0gReoI7Px7Grz+6hiKdJvkUw6ZPqxXx9mOXozDS0Pedvh3eAFaEzum78aI8MgSSw== X-Received: by 2002:a92:4b01:0:b0:368:80b8:36fa with SMTP id m1-20020a924b01000000b0036880b836famr657225ilg.2.1712869418258; Thu, 11 Apr 2024 14:03:38 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id a18-20020a927f12000000b0036a3636ec23sm582207ild.10.2024.04.11.14.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 14:03:37 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 15:03:37 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/clone3: Correct log message for waitpid() failures To: Mark Brown , Christian Brauner , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20240409-kselftest-clone3-waitpid-v1-1-2b31e4aaac16@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240409-kselftest-clone3-waitpid-v1-1-2b31e4aaac16@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/9/24 14:40, Mark Brown wrote: > When logging an error from calling waitpid() on the child we print a > misleading error message saying that the error we report was returned by > the chilld. Fix this to say the error is from waitpid(). > > Signed-off-by: Mark Brown > --- > tools/testing/selftests/clone3/clone3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c > index 3c9bf0cd82a8..eb108727c35c 100644 > --- a/tools/testing/selftests/clone3/clone3.c > +++ b/tools/testing/selftests/clone3/clone3.c > @@ -95,7 +95,7 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode) > getpid(), pid); > > if (waitpid(-1, &status, __WALL) < 0) { > - ksft_print_msg("Child returned %s\n", strerror(errno)); > + ksft_print_msg("waitpid() returned %s\n", strerror(errno)); > return -errno; > } > if (WEXITSTATUS(status)) > > --- > base-commit: 8cb4a9a82b21623dbb4b3051dd30d98356cf95bc > change-id: 20240405-kselftest-clone3-waitpid-68c4833cf5ff > > Best regards, Applied to linux-kselftest next for Linux 6.10-rc1. thanks, -- Shuah