From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/clone3: Check that the child exited cleanly
Date: Thu, 11 Apr 2024 15:03:22 -0600 [thread overview]
Message-ID: <c70a1402-4664-4200-94a5-239c7bc37392@linuxfoundation.org> (raw)
In-Reply-To: <20240409-kselftest-clone3-signal-v1-1-bbe49156171d@kernel.org>
On 4/9/24 14:39, Mark Brown wrote:
> When the child exits during the clone3() selftest we use WEXITSTATUS() to
> get the exit status from the process without first checking WIFEXITED() to
> see if the result will be valid. This can lead to incorrect results, for
> example if the child exits due to signal. Add a WIFEXTED() check and report
> any non-standard exit as a failure, using EXIT_FAILURE as the exit status
> for call_clone3() since we otherwise report 0 or negative errnos.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/clone3/clone3.c | 5 +++++
> 1 file changed, 5 insertions(+)
Applied to linux-kselftest next for Linux 6.10-rc1.
thanks,
-- Shuah
prev parent reply other threads:[~2024-04-11 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 20:39 Mark Brown
2024-04-11 21:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c70a1402-4664-4200-94a5-239c7bc37392@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®