From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.148 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794054866; b=q2DsnewT7ybNrWhWQnLWfD5JRZmZN4YGKP7VQ5QAIKmQ2naQWzvvdlbE20uxM4fgF3rc Q7GYQinI/j8QhEPV2Cb7rM7zwzFb5epixUjFLCGOGYpsgwu6TxMQ5RNnPh+IeZ266ux51 TXcl+4NK6dsQAY+niJ3+SS1mu9pPiUTWKaFDhRuk+WIC/OaQ+c3QYCQ7V0xm1lS/YyxoF cpC4NhAcH2xuduU2y9kl1CEPjVD79AmdRrHeVAaNSvjL5X/c1Nw/VNLfm2YQySTtpju1r T+Dp14gtkgK8Q09oGbfRDvJ2Be7VBKRiVoMSQB6Ngw0VvhadBsQIqb7d35KlqDPfFVQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794054866; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:X-ThreadId:Date:From:To:Cc:Message-Id:In-Reply-To: References:Subject:Content-Type:Content-Transfer-Encoding; bh=9W0gqXHySUVAdfm5cgv/j9VwTU1fsDH68oG9t0v3Rrw=; b=EyfLWxUCRSGTYhieBZqWlXWyB6MhszmxnOdC8jnHk2w1InfaZi8ki7La/IX+Dpstqk4d cRb3Lm9NLxM/HmaSe6Cg4zz07Fk88L8LPrImwdj2vSqnDoFo3bPXodzYbNs7xCFlfve3V oujfaGsxXl4DoMz0GboGDRq1VerOLgSovghEC1LJbDbKGeL1bqAlNOy1k7+Fem4IRNF0A 5btEAfAvyWC2OUSpn7l17WINt5GpXa7IcoMw7ZORtkL5P+HGf9y/aj6y3WGLdkHvsz8/E OOsS+dSIN/m46vfv5o+PYpmY788jipwsZeMiKYcuAiQz28dpjQXetGAz8DAcItF0zYw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=hmh.eng.br; spf=pass smtp.mailfrom=hmh.eng.br; dkim=pass header.d=hmh.eng.br header.i=@hmh.eng.br header.a=rsa-sha256 header.s=fm1 header.b=KcEnS467; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=LniY3leB; arc=none smtp.remote-ip=103.168.172.148 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0EA606A326 for ; Sat, 7 Nov 2026 12:34:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6A0EA606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hmh.eng.br Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hmh.eng.br Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=hmh.eng.br header.i=@hmh.eng.br header.a=rsa-sha256 header.s=fm1 header.b=KcEnS467; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=LniY3leB Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 7592DEC01CE for ; Sat, 7 Nov 2026 07:34:24 -0500 (EST) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-03.internal (MEProxy); Sat, 07 Nov 2026 07:34:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hmh.eng.br; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1794054864; x=1794141264; bh=9W0gqXHySUVAdfm5cgv/j9VwTU1fsDH68oG9t0v3Rrw=; b= KcEnS467ndIClp5C6PbG/a6K6E/5pLkya/ZZ0bpm6nb6xUHJbJzV/fqW+abxrnSB YRq5tQJb3Lop+7BEw7aiGyNYes3vmPIBxY9QNw8aWzNx+a6kk8Ao6Ly/9U+smyIV dc51GKjYz2Nd21XJNEw71peaGVaLNuSW77iYSA3BzcGw6toZ2CzCv9vkZ+vA30FA u9eAANWPD4sB56BD/UByqS5thHy7+cHj5xZrKxZOfu4BHpW033MmbBe3MnKkdDjs Aw4Z94I8znq0GT1y/TAIDSvjOVWzHXAT8ms0wG95tsRPWvqH0xRltEOQRhTn3+3v c4ekqrIjRCuBpK4qX7sXoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794054864; x= 1794141264; bh=9W0gqXHySUVAdfm5cgv/j9VwTU1fsDH68oG9t0v3Rrw=; b=L niY3leBDGVSIScktI7pKt4gjtTMRMddDx2am7Hj3qDvfNt1iPc/Lgs2Yfzu/O7Nx /c09yo5AJWxQoMqN6YDEJfBeXMDGmyTjJILlTAEWDh1xcujlnfqlDInPkQrI2p+y n/Yzu27zky44xqX3IlVDzNlrmKitIiiOKWJSpqj+uqsS+S8g1bhgDb0F/oABdu/8 QYipJCm0QsH/KCtAKIDMPkLe9u0NZgVpgQZ8XBFqxMiwTzofSZ75NVo7zFDSpnnG VI1f+jqB5F0m9fDJ92gSi1p+92PD/2GQlzAwCPdJBGjAXOYPMcNBiRb7WH9FQr+h rQasJlwxXyC4EYnkf5fLA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=hmh.eng.br a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794054864; d=hmh.eng.br; mf=PGhtaEBobWguZW5nLmJyPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm1:rsa-sha256:C20BcOcek2tovdz1R5Vx6Xowfnv7g5CQX0l4TzOstjtF+Tr u/fH+XKMWMTAXaawKef719YyIgX9Fswp9UNp0WsX2t3aDmUQ/DtxxhpwOgmEhOH1 mS7jYiHT9ocRVc/DaL8Bc5syny0FmqLhrsMA6qVMmYGn9/bjNMn9xc31iGgwE2dF BGS8s05O0fqa8E9fGaIHz7jo2PIRhpcgIIH92rhWx7ftC8Cb8bXNo9Bpw9gn9Snk YCbRnuzNAv+7Fwdd8HdiFA87O4AIkEHRrCUSMqBffBOzjUr+Klu71bPOINZAOm6E JlMxVuAZE0VK2tep/VbIBUifc2hReiObZYNUyMQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:op/+dAocpZMiuBJeSEBQkYVcxAYa42blk0YlxQy9vM4=:6zjITNMaD/z2lGUZax68niVBqihsiRxpOtcZqfJiCuY=; X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGvO4ynNH4DhsGblKpSxWFZ/omv9JAQSsnOL681JtoOZ0QN/UGJbVyR36yNilLqIz GZAG2UXgMqULQPNxKC8OMOy3m2LnLVf6MNpt3DM93/pSn3iU0LMRardGYDKKtN3XYSp6z9 EwGSMFbstxVN59e+Bqe5CDkWBJ36Hfev4eb/mvIoM2wR5Z+L3g+NI2CsOZxLB5Fth7keYT t96vZYFD2tYKJylTwE7+nh2vMAl2RT3QGoayzCAWqTM25Cn0h+2OMO5mOarwqC4AVGBKkR nvtxfT09aUGpxounNJvgzGAHusHgaGcG2l6SWkNx0JW9qRAs1C+tQaOXvwIhhwKxi0HMAK VDiQvCpToWCiQ1eXxAdLK/kcex6EQq3dDkkxXF/OJqalxDBxPp3dZu+PdKDH7FnCUySul6 WMPJPKmartknX2m49VobJ7CjGXNkKP2jpbpGocm29ZmVQXK0nPfOTRAWMX3MZbjSpiT+vj 8mmn6Eb3phsGKUrzdPjbJ0VKY3HBp68mojuzlsabTs7mv3C+CR3r9jgeMMYXat/fRXWpBk xLn2iYRyzuef5LjjtUWzeCRYwqz21CFYkqkZjjYS5isnkZHGsmIMP+CvxoZzUNMmSIpU8S NiLEspcnL5rm98qdAYuPCq/gqQ7cAlJGsNM6QZNjXMVZ/+/jCEaWhUIhu27g X-ME-Proxy: Feedback-ID: ib67041be:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 44F86182007E; Sat, 7 Nov 2026 07:34:23 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-ThreadId: AJ6AS3VwzXO7 Date: Sat, 07 Nov 2026 09:34:03 -0300 From: "Henrique de Moraes Holschuh" To: "Rong Zhang" , "Josh Triplett" Cc: "Mark Pearson" , "Derek J. Clark" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "platform-driver-x86@vger.kernel.org" , "Thinkpad-acpi devel ML" , lkml Message-Id: In-Reply-To: <20d824152b1a889b636ef9877b4d1a8e06dcf460.camel@rong.moe> References: <19f5b65e494ed710a65927311cb68535c87953d3.camel@rong.moe> <20d824152b1a889b636ef9877b4d1a8e06dcf460.camel@rong.moe> Subject: Re: [PATCH] platform/x86: tpacpi: Mark charging LEDs as safe Content-Type: text/plain Content-Transfer-Encoding: 7bit Eh, I better voice something about this... 1. The EC does use the battery led for alarms, and it also has specific high urgency events when it thinks the thing will catch fire or going to forcefully cut power very soon, although this was a relatively later enhancement. Thinkpad ACPI is supposed to log a critical warning and it should attempt to initiate a system shutdown (power off) if it ever receives battery emergency alerts. I was explicitly advised to do it this way by Lenovo bios engineering, in private, a long time ago. 2. Module parameters are the way I dealt with this kind of thing in the past, especially if they are not mutable at runtime. It is vastly better than debugfs for this kind of thing IMHO and the fan control was implemented that way. But the default must be the safer behavior. > OTOH, CONFIG_THINKPAD_ACPI_UNSAFE_LEDS should taint the kernel on the > very beginning. I don't think tainting makes sense as long as it is something you either have to compile for and a distro would never do so as a default, or something you need to load the module with an explicit parameter set. It will not cause system instability, unlike, say, poking around the EC registers directly. A module parameter is a decent compromise IMO: Debugfs is too reachable for userspace to mess with without actually doing an informed opt-in. People respect module parameters a lot more. -- Henrique Holschuh