From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8141730E0C0 for ; Sat, 28 Mar 2026 10:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774694979; cv=none; b=PhdjbE3K1PJk2bBupDgIpzxoKJ9kQP5Bre+5+b2oZ4bkFf2aPGeVH/w24CyfDgYI+xqi3BVvSfY4UTFBtNtvKSJuRdwX6k76AbTkh9dYBAL8Ld4bdTg7FA8pduYEZ7hsa6dP5X9IV0C08XGJhdd8aUom9eyl4Z+P6mMduPTkIGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774694979; c=relaxed/simple; bh=nXo+Z+t9wD8qwriLJvFbxust4+WxxaBdyAGEtQ8SmBM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=icynaxnzNmVXjV34w1oU2tOtY6HLQvrBQx83G3hXDb/zBb7A4wQ6IOLjMiQjGY0pn8mxl+3Y9wM6a0Ovnw5uNdiYoIVbpyu+dOGR/N6pTkEgmBSOKJQtPhR4Uxz6v0T8vSUZHzCkyyZirlye1jbzylfgMDftsrPlG5igdugi2qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=X4tsg6zl; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="X4tsg6zl" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2b0afa0210bso15024515ad.2 for ; Sat, 28 Mar 2026 03:49:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774694978; x=1775299778; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CM66K7bh3C7YvdRkvpH9zwWt4HmV/zowprJjLCrPEpw=; b=mA/GcblndZ9v/wI0JbstU/jsQ8FZFJna4gH1q5G9dd1rQG7/m7uOoNR1GAWv8sZy3N vOAHEi1hu4481DetMOAcSfDf9f5IiUdAR1V71zf9D9WediwrTGNIUrMo5az0GZN1wWyQ 3L7wt3c38RlBQ3gwwQJtHjkCwIRbt0lxu6GPR618drQUFaTd0q3sEFMdzOliJ4ehL8e5 +QFeRpZMMpVgAu7FGyEKeCuQNdhaRSo/UJYR04a+IeW/2tdEb5Fb0qG+q/pgUgvkNJRE uwe01JRRgWwm9PW/MKMbp4ZbfU9YUT58e9pU884Iq89icNPMlzntfL/atzCJWVHbe0GU d4Lg== X-Forwarded-Encrypted: i=1; AJvYcCX7PKdzd6uzDonnUDryrVcxtqlHb+26U9T39WjrKSEYsuVDj/fEbWYd6928PXMeTORo8cbnn5OqQB7X+qI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhod/pyo6Jef8rXQytDXXDjGbYC57L1Sze6iTEDrpXiIeDCV8J 4H9RTk7D9laC3tOexYcYSAkWj/39o/V8FG2bi0jVj0pzHHK1WKnj54kxpSztmL73N3p8MDh6JDT obAeQEes5SEDAxmYCkO16VqyBwd3QbduhpJwbBpHEdLAtCIEXD4l9N9e63WB5EpBNBWQ61RYjMg zCMazfO/wPdEarHto0fzH7ofSUVCE9riiWflKIhbRl8C/kL5iqwPKIrQuVLBup4NjlpiVZRPuAK tP1aE+jJ+hKZP4IXNVvCBBBQw== X-Gm-Gg: ATEYQzzJJCPf3kLHfN+PEVxCkryODcMcAJQ2m+QAua4soy1FVSw3Rx6KKENYKGJEMD9 DaSSFlJCRlWmd3umuQC+cSxKsjiIILq2RqxmmLCa1S1intpDBzFIeoNK5TQalf6w0lYIyphX1Zo QU3WZEwoLTU548LPKORQHiODm47vZKuGegqUmF1iEL0DS+k+6L+4nfeA66yIhImLMeIGgOc/tSR KVh1krVvGY3WkfvpQNmkiBu2Uo8KM5keW3ioNMvKLRxYPdGoji484dhPFOixqhe+ofqJYg3GvWx tRYFMe9WmOB5WhBWqhPOZnDYD+fAHoueJqjjApkkm+605qduFLF8kDRFaTLnA3EbcsDUMjHHbWn RyLTuvTK+FlvUMJec9TnAuDvs+k0VeOpeNj7gJ9askxpa1LnIkoliJbJJ30uTbD2caf7a9UaHIL CNNDCEpL+4 X-Received: by 2002:a17:902:ea08:b0:2b0:ba14:fc70 with SMTP id d9443c01a7336-2b0cdd91799mr65214925ad.42.1774694977245; Sat, 28 Mar 2026 03:49:37 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b24265bbaesm2252255ad.24.2026.03.28.03.49.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2026 03:49:37 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b984798d468so271663566b.1 for ; Sat, 28 Mar 2026 03:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1774694975; x=1775299775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=CM66K7bh3C7YvdRkvpH9zwWt4HmV/zowprJjLCrPEpw=; b=X4tsg6zlHKXIeNxjfKio+IlIh1mAeG0nP2aW5muzVqytIezvGjRmWH/R0jubPYy07C 1XKiJzXw8+AHJK+idiq9UqZgmqwZrJIRyLw7eVjvLl9NhaHuhLIiRObBzYGzA8Bj4H6V 7wcPM6E7QbLJ9d0I09h1u2Mh0l80b4UGZz12M= X-Forwarded-Encrypted: i=1; AJvYcCXwFbinfsMhKQ8mBpzkvdNGhaNdss3v5X1n5ivL8rT9R90ORwlhOoKOOXWkjPuZge3liBilFZy/zbGI/0g=@vger.kernel.org X-Received: by 2002:a17:907:3f23:b0:b98:d58:f75e with SMTP id a640c23a62f3a-b9b502ff9damr346054166b.2.1774694974811; Sat, 28 Mar 2026 03:49:34 -0700 (PDT) X-Received: by 2002:a17:907:3f23:b0:b98:d58:f75e with SMTP id a640c23a62f3a-b9b502ff9damr346053066b.2.1774694974172; Sat, 28 Mar 2026 03:49:34 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7b1dda44sm62951266b.43.2026.03.28.03.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Mar 2026 03:49:33 -0700 (PDT) Message-ID: Date: Sat, 28 Mar 2026 11:49:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 wireless-next] wifi: brcmsmac: use FAM for debug code To: Rosen Penev , Julian Calaby Cc: linux-wireless@vger.kernel.org, "open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS" , "open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS" , open list References: <20260309215907.5789-1-rosenp@gmail.com> Content-Language: en-US From: Arend van Spriel Autocrypt: addr=arend.vanspriel@broadcom.com; keydata= xsFNBGP96SABEACfErEjSRi7TA1ttHYaUM3GuirbgqrNvQ41UJs1ag1T0TeyINqG+s6aFuO8 evRHRnyAqTjMQoo4tkfy21XQX/OsBlgvMeNzfs6jnVwlCVrhqPkX5g5GaXJnO3c4AvXHyWik SOd8nOIwt9MNfGn99tkRAmmsLaMiVLzYfg+n3kNDsqgylcSahbd+gVMq+32q8QA+L1B9tAkM UccmSXuhilER70gFMJeM9ZQwD/WPOQ2jHpd0hDVoQsTbBxZZnr2GSjSNr7r5ilGV7a3uaRUU HLWPOuGUngSktUTpjwgGYZ87Edp+BpxO62h0aKMyjzWNTkt6UVnMPOwvb70hNA2v58Pt4kHh 8ApHky6IepI6SOCcMpUEHQuoKxTMw/pzmlb4A8PY//Xu/SJF8xpkpWPVcQxNTqkjbpazOUw3 12u4EK1lzwH7wjnhM3Fs5aNBgyg+STS1VWIwoXJ7Q2Z51odh0XecsjL8EkHbp9qHdRvZQmMu Ns8lBPBkzpS7y2Q6Sp7DcRvDfQQxPrE2sKxKLZVGcRYAD90r7NANryRA/i+785MSPUNSTWK3 MGZ3Xv3fY7phISvYAklVn/tYRh88Zthf6iDuq86m5mr+qOO8s1JnCz6uxd/SSWLVOWov9Gx3 uClOYpVsUSu3utTta3XVcKVMWG/M+dWkbdt2KES2cv4P5twxyQARAQABzS9BcmVuZCB2YW4g U3ByaWVsIDxhcmVuZC52YW5zcHJpZWxAYnJvYWRjb20uY29tPsLBhwQTAQgAMRYhBLX1Z69w T4l/vfdb0pZ6NOIYA/1RBQJj/ek9AhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQlno04hgD/VGw 8A//VEoGTamfCks+a12yFtT1d/GjDdf3i9agKMk3esn08JwjJ96x9OFFl2vFaQCSiefeXITR K4T/yT+n/IXntVWT3pOBfb343cAPjpaZvBMh8p32z3CuV1H0Y+753HX7gdWTEojGWaWmKkZh w3nGoRZQEeAcwcF3gMNwsM5Gemj7aInIhRLUeoKh/0yV85lNE1D7JkyNheQ+v91DWVj5/a9X 7kiL18fH1iC9kvP3lq5VE54okpGqUj5KE5pmHNFBp7HZO3EXFAd3Zxm9ol5ic9tggY0oET28 ucARi1wXLD/oCf1R9sAoWfSTnvOcJjG+kUwK7T+ZHTF8YZ4GAT3k5EwZ2Mk3+Rt62R81gzRF A6+zsewqdymbpwgyPDKcJ8YUHbqvspMQnPTmXNk+7p7fXReVPOYFtzzfBGSCByIkh1bB45jO +TM5ZbMmhsUbqA0dFT5JMHjJIaGmcw21ocgBcLsJ730fbLP/L08udgWHywPoq7Ja7lj5W0io ZDLz5uQ6CEER6wzD07vZwSl/NokljVexnOrwbR3wIhdr6B0Hc/0Bh7T8gpeM+QcK6EwJBG7A xCHLEacOuKo4jinf94YQrOEMnOmvucuQRm9CIwZrQ69Mg6rLn32pA4cK4XWQN1N3wQXnRUnb MTymLAoxE4MInhDVsZCtIDFxMVvBUgZiZZszN33OwU0EY/3pIgEQAN35Ii1Hn90ghm/qlvz/ L+wFi3PTQ90V6UKPv5Q5hq+1BtLA6aj2qmdFBO9lgO9AbzHo8Eizrgtxp41GkKTgHuYChijI kdhTVPm+Pv44N/3uHUeFhN3wQ3sTs1ZT/0HhwXt8JvjqbhvtNmoGosZvpUCTwiyM1VBF/ICT ltzFmXd5z7sEuDyZcz9Q1t1Bb2cmbhp3eIgLmVA4Lc9ZS3sK1UMgSDwaR4KYBhF0OKMC1OH8 M5jfcPHR8OLTLIM/Thw0YIUiYfj6lWwWkb82qa4IQvIEmz0LwvHkaLU1TCXbehO0pLWB9HnK r3nofx5oMfhu+cMa5C6g3fBB8Z43mDi2m/xM6p5c3q/EybOxBzhujeKN7smBTlkvAdwQfvuD jKr9lvrC2oKIjcsO+MxSGY4zRU0WKr4KD720PV2DCn54ZcOxOkOGR624d5bhDbjw1l2r+89V WLRLirBZn7VmWHSdfq5Xl9CyHT1uY6X9FRr3sWde9kA/C7Z2tqy0MevXAz+MtavOJb9XDUlI 7Bm0OPe5BTIuhtLvVZiW4ivT2LJOpkokLy2K852u32Z1QlOYjsbimf77avcrLBplvms0D7j6 OaKOq503UKfcSZo3lF70J5UtJfXy64noI4oyVNl1b+egkV2iSXifTGGzOjt50/efgm1bKNkX iCVOYt9sGTrVhiX1ABEBAAHCwXYEGAEIACAWIQS19WevcE+Jf733W9KWejTiGAP9UQUCY/3p PgIbDAAKCRCWejTiGAP9UaC/EACZvViKrMkFooyACGaukqIo/s94sGuqxj308NbZ4g5jgy/T +lYBzlurnFmIbJESFOEq0MBZorozDGk+/p8pfAh4S868i1HFeLivVIujkcL6unG1UYEnnJI9 uSwUbEqgA8vwdUPEGewYkPH6AaQoh1DdYGOleQqDq1Mo62xu+bKstYHpArzT2islvLdrBtjD MEzYThskDgDUk/aGPgtPlU9mB7IiBnQcqbS/V5f01ZicI1esy9ywnlWdZCHy36uTUfacshpz LsTCSKICXRotA0p6ZiCQloW7uRH28JFDBEbIOgAcuXGojqYx5vSM6o+03W9UjKkBGYFCqjIy Ku843p86Ky4JBs5dAXN7msLGLhAhtiVx8ymeoLGMoYoxqIoqVNaovvH9y1ZHGqS/IYXWf+jE H4MX7ucv4N8RcsoMGzXyi4UbBjxgljAhTYs+c5YOkbXfkRqXQeECOuQ4prsc6/zxGJf7MlPy NKowQLrlMBGXT4NnRNV0+yHmusXPOPIqQCKEtbWSx9s2slQxmXukPYvLnuRJqkPkvrTgjn5d eSE0Dkhni4292/Nn/TnZf5mxCNWH1p3dz/vrT6EIYk2GSJgCLoTkCcqaM6+5E4IwgYOq3UYu AAgeEbPV1QeTVAPrntrLb0t0U5vdwG7Xl40baV9OydTv7ghjYZU349w1d5mdxg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/03/2026 02:47, Rosen Penev wrote: > On Mon, Mar 9, 2026 at 6:11 PM Julian Calaby wrote: >> >> Hi Arend, >> >> On Tue, Mar 10, 2026 at 8:59 AM Rosen Penev wrote: >>> >>> Debug code requires a separate allocation to duplicate a string. A FAM >>> allows properly sized allocation with a single kfree. >> >> Sorry Rosen for hijacking your patch here. >> >> With these changes, does allocating and copying the string really need >> to be behind a DEBUG ifdef? > I don't know. I didn't write this code. Thanks, Rosen I did before the concept of FAM landed in the kernel. Whether or not the #ifdef DEBUG is warranted is simply a choice. I prefer to have clean separation of functionality and the related data. If the code using the data is all conditional under DEBUG define then the data must be as well. I understand that FAM and compiler support for it has its advantages, but this is more churn than gain. The code is functional as is and removing #defines for the sake of changing to a FAM seems not justified for the advantages which in my opinion are pretty limited in this particular case. Regards, Arend