From: Bibo Mao <maobibo@loongson.cn>
To: cuitao <cuitao@kylinos.cn>,
zhaotianrui@loongson.cn, chenhuacai@kernel.org,
loongarch@lists.linux.dev
Cc: kernel@xen0n.name, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: KVM: remove unused returns.
Date: Thu, 4 Sep 2025 14:15:06 +0800 [thread overview]
Message-ID: <c70e595e-c1ab-2c8a-3f46-3862ecd6e0b8@loongson.cn> (raw)
In-Reply-To: <20250904042622.1291085-1-cuitao@kylinos.cn>
On 2025/9/4 下午12:26, cuitao wrote:
> The default branch has already handled all undefined cases,
> so the final return statement is redundant.
>
> Signed-off-by: cuitao <cuitao@kylinos.cn>
> ---
> arch/loongarch/kvm/exit.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/loongarch/kvm/exit.c b/arch/loongarch/kvm/exit.c
> index 2ce41f93b2a4..e501867740b1 100644
> --- a/arch/loongarch/kvm/exit.c
> +++ b/arch/loongarch/kvm/exit.c
> @@ -778,9 +778,7 @@ static long kvm_save_notify(struct kvm_vcpu *vcpu)
> return 0;
> default:
> return KVM_HCALL_INVALID_CODE;
> - };
> -
> - return KVM_HCALL_INVALID_CODE;
> + }
> };
>
> /*
>
Reviewed-by: Bibo Mao <maobibo@loongson.cn>
next prev parent reply other threads:[~2025-09-04 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 4:26 cuitao
2025-09-04 6:15 ` Bibo Mao [this message]
2025-09-04 6:25 ` Huacai Chen
2025-09-04 6:34 ` Tiezhu Yang
2025-09-04 8:13 ` cuitao
2025-09-04 8:20 ` Huacai Chen
2025-09-04 8:57 ` Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c70e595e-c1ab-2c8a-3f46-3862ecd6e0b8@loongson.cn \
--to=maobibo@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=cuitao@kylinos.cn \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®