From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-223.mta0.migadu.com [91.218.175.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B12C5867FF for ; Wed, 9 Sep 2026 14:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963509; cv=none; b=NY/gaFoksP4mUYGO4i7D+u5ePYOjKoiYM6IZLv8+JjoJ7utUtPIClPH3DOqjClNsqHMGJw8VmDylTlss0Wyn41Y3vs34eRIKD0mD79ek8U6rGP1905+2bPdEmw1vsJ1KyHi36VcmtLvON0Q7p03AGisvtQVEh4ujYIbpRGlyTgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963509; c=relaxed/simple; bh=3IScLMqR1j4WOInzczvg5L6GZZlSpePkJw/WpMCPcyc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mpTFHqZHheTJQL8wXx5kGQGka1QCxPuCJVLrUAlk/W0gRQeaER3L3jOdfvR4DpbXKolEVcZkIVsejkOhE3wJH5nQS0SIwq6N5Qy0u/mgxQjdu2HhXGhNaV6ZxgVaBabJwLTuJVc+TESxMDucZiaUTXgWjRU67iwmGH+lKaO8sx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ufEOUQRT; arc=none smtp.client-ip=91.218.175.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ufEOUQRT" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=3IScLMqR1j4WOInzczvg5L6GZZlSpePkJw/WpMCPcyc=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788963505; v=1; x=1789568305; b=ufEOUQRTG7/mBrkey+CZYxeOlZyr3lX12dp8AwyeHb5ZXuEgwKJpJ3LL60LCSDJBfazOBtRg Fb0XfiP2hDLmR+pTfct/9AXZb73X2y8ZMT6Y0ePV2bsVzpKGff0JYrRjrVbvGpffqciQEgNW86f LP2HAcp5hOv1H2X75NCjBGfE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id a8c734c53a6dca85; Wed, 09 Sep 2026 14:18:24 +0000 X-Mizu-Trace-ID: a8c734c53a6dca85 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 9 Sep 2026 22:18:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH nf-next] netfilter: flowtable: check namespace before iterating flows To: Phil Sutter Cc: Pablo Neira Ayuso , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260909081705.1512600-1-qingfang.deng@linux.dev> Content-Language: en-US From: Qingfang Deng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 9/9/2026 7:16 PM, Phil Sutter wrote: > A second caller of nf_flow_table_gc_cleanup is > nf_flow_table_indr_cleanup in net/netfilter/nf_flow_table_offload.c. Is > the net_eq-check needed there as well? If not, could you please update > the patch description with a statement explaining why? No. Its callback uses the device bound to the flowtable, which belongs to the same namespace. Kind regards, Qingfang