From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdF1PE3 (ORCPT ); Wed, 28 Jun 2017 11:04:29 -0400 Received: from foss.arm.com ([217.140.101.70]:42852 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbdF1PEV (ORCPT ); Wed, 28 Jun 2017 11:04:21 -0400 Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Kevin Hilman Subject: Re: [PATCH] clk: scpi: error when clock fails to register To: Jerome Brunet , Michael Turquette , Stephen Boyd References: <20170628135345.9337-1-jbrunet@baylibre.com> From: Sudeep Holla Organization: ARM Message-ID: Date: Wed, 28 Jun 2017 16:04:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170628135345.9337-1-jbrunet@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/06/17 14:53, Jerome Brunet wrote: > Current implementation of scpi_clk_add just print a warning when clock > fails to register but then keep going as if nothing happened. The > provider is then registered with bogus data. > > This may latter lead to an Oops in __clk_create_clk when > hlist_add_head(&clk->clks_node, &hw->core->clks) is called. > What's the path of this call ? I see one in devm_clk_hw_register but that's one which failed. Also one of the reason for keeping it continuing is, if firmware fails on some non-critical clock, that's fine rather than punishing the entire set of clocks and may even fail the boot. -- Regards, Sudeep